Page MenuHomePhabricator
Create Task
Maniphest T134027

Improper default settings for grants
Closed, ResolvedPublic
Actions

Description

autoreview, torunblocked are two rights that are not in MediaWiki core. These two rights should be removed from the default settings.

Details

SubjectRepoBranchLines +/-
Remove these two rights autoreview and torunblocked from mediawikimediawiki/coremaster+0 -2
Remove these two rights autoreview and torunblocked from mediawikimediawiki/coreREL1_27+0 -2
Add new $wgGrantPermissions introduced in 1.27mediawiki/extensions/FlaggedRevsREL1_27+3 -0
Add new $wgGrantPermissions introduced in 1.27mediawiki/extensions/FlaggedRevsmaster+3 -0
Add new $wgGrantPermissions introduced in 1.27mediawiki/extensions/TorBlockREL1_27+1 -1
Add new $wgGrantPermissions introduced in 1.27mediawiki/extensions/TorBlockmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nbdd0121 created this task.Apr 30 2016, 1:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2016, 1:22 AM
Aklapper changed the task status from Open to Stalled.Apr 30 2016, 2:26 PM

Hi @Nbdd0121, thanks for taking the time to report this!
Unfortunately this report lacks some information. If you have time and can still reproduce the problem, please add a more complete description to this report and also explains where "grants" come into play.
Ideally, exact and clear steps to reproduce should allow any other person to follow these steps (without having to interpret those steps) and see the same results. Problems that others can reliably reproduce can get fixed faster. Thanks!

Nbdd0121 added a comment.Apr 30 2016, 2:34 PM

@Aklapper "Grants" is the new feature introduced in MediaWiki 1.27 (which is migrated from OAuth plugin), and in DefaultSettings.php, two rights, torunblock and autoreview are listed. I am saying that these two rights are not expected to be there. This is an improper implementation, so reproducing is easy: do a fresh installation and navigate to Special:ListGrants, and you will see these two rights are there.

Aklapper changed the task status from Stalled to Open.Apr 30 2016, 4:55 PM
Aklapper triaged this task as Medium priority.
Aklapper added a project: MW-1.27-release.

Thanks!

gerritbot subscribed.May 22 2016, 4:01 PM

Change 290069 had a related patch set uploaded (by Paladox):
Remove these two rights autoreview and torunblocked from mediawiki

https://gerrit.wikimedia.org/r/290069

gerritbot added a project: Patch-For-Review.May 22 2016, 4:01 PM
• demon removed a project: MW-1.27-release.May 31 2016, 4:00 PM
• demon subscribed.

This isn't really 1.27-specific, untagging.

Nbdd0121 added a comment.May 31 2016, 4:10 PM
In T134027#2341426, @demon wrote:

This isn't really 1.27-specific, untagging.

This needs to be fixed before the release.

• demon added a project: MW-1.27-release.May 31 2016, 4:21 PM

You're right, sorry.

MGChecker subscribed.May 31 2016, 8:09 PM
Restricted Application added a subscriber: Luke081515. · View Herald TranscriptMay 31 2016, 8:09 PM
gerritbot added a comment.Jun 10 2016, 4:10 PM

Change 293748 had a related patch set uploaded (by Chad):
Add new $wgGrantPermissions introduced in 1.27

https://gerrit.wikimedia.org/r/293748

gerritbot added a comment.Jun 10 2016, 4:13 PM

Change 293749 had a related patch set uploaded (by Chad):
Add new $wgGrantPermissions introduced in 1.27

https://gerrit.wikimedia.org/r/293749

gerritbot added a comment.Jun 10 2016, 4:14 PM

Change 293748 merged by jenkins-bot:
Add new $wgGrantPermissions introduced in 1.27

https://gerrit.wikimedia.org/r/293748

gerritbot added a comment.Jun 10 2016, 4:15 PM

Change 293749 merged by jenkins-bot:
Add new $wgGrantPermissions introduced in 1.27

https://gerrit.wikimedia.org/r/293749

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 10 2016, 5:00 PM
gerritbot added a comment.Jun 10 2016, 6:10 PM

Change 293777 had a related patch set uploaded (by Chad):
Add new $wgGrantPermissions introduced in 1.27

https://gerrit.wikimedia.org/r/293777

gerritbot added a comment.Jun 10 2016, 7:28 PM

Change 293794 had a related patch set uploaded (by Chad):
Add new $wgGrantPermissions introduced in 1.27

https://gerrit.wikimedia.org/r/293794

gerritbot added a comment.Jun 10 2016, 7:29 PM

Change 293797 had a related patch set uploaded (by Chad):
Remove these two rights autoreview and torunblocked from mediawiki

https://gerrit.wikimedia.org/r/293797

gerritbot added a comment.Jun 10 2016, 7:31 PM

Change 293777 merged by jenkins-bot:
Add new $wgGrantPermissions introduced in 1.27

https://gerrit.wikimedia.org/r/293777

gerritbot added a comment.Jun 10 2016, 7:33 PM

Change 293794 merged by jenkins-bot:
Add new $wgGrantPermissions introduced in 1.27

https://gerrit.wikimedia.org/r/293794

gerritbot added a comment.Jun 10 2016, 7:37 PM

Change 290069 merged by jenkins-bot:
Remove these two rights autoreview and torunblocked from mediawiki

https://gerrit.wikimedia.org/r/290069

gerritbot added a comment.Jun 10 2016, 7:38 PM

Change 293797 merged by jenkins-bot:
Remove these two rights autoreview and torunblocked from mediawiki

https://gerrit.wikimedia.org/r/293797

• demon closed this task as Resolved.Jun 10 2016, 7:44 PM
• demon claimed this task.
ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.28-release-notes.Jun 10 2016, 8:00 PM
MGChecker removed projects: MW-1.28-release-notes, Patch-For-Review.Jun 10 2016, 9:19 PM
Tgr added a parent task: T142308: Most extensions which add a user right should also add or extend a grant.Sep 9 2016, 2:07 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL