Page MenuHomePhabricator
Create Task
Maniphest T134189

Regression: no longer validating gateway-specific required fields server side
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

rEDOI8329b0e9 removes the check_not_empty parameter on DonationData::getValidationErrors and DataValidator::validate.

It was still being used in GatewayAdapter::revalidate to specify gateway-specific required variables and should be restored.

Details

SubjectRepoBranchLines +/-
Restore check_not_emptymediawiki/extensions/DonationInterfacemaster+14 -4
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.May 2 2016, 6:22 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 2 2016, 6:22 PM
• DStrine added projects: Fundraising Sprint Internet Exploring, Unplanned-Sprint-Work.May 3 2016, 8:14 PM
• DStrine set the point value for this task to 1.
• DStrine moved this task from Triage to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.
gerritbot subscribed.May 4 2016, 6:49 PM

Change 286934 had a related patch set uploaded (by Ejegg):
Restore check_not_empty

https://gerrit.wikimedia.org/r/286934

gerritbot added a project: Patch-For-Review.May 4 2016, 6:49 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Internet Exploring board.May 4 2016, 7:13 PM
gerritbot added a comment.May 4 2016, 7:20 PM

Change 286934 merged by jenkins-bot:
Restore check_not_empty

https://gerrit.wikimedia.org/r/286934

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Internet Exploring board.May 4 2016, 8:36 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Internet Exploring board.May 5 2016, 4:33 AM
Ejegg closed this task as Resolved.May 5 2016, 4:35 AM
Ejegg claimed this task.
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)).May 10 2016, 1:02 PM
gerritbot added a comment.May 28 2016, 7:16 PM

Change 291530 had a related patch set uploaded (by Subramanya Sastry):
T134189: Serialize content in HTML tables using HTML tags

https://gerrit.wikimedia.org/r/291530

ssastry subscribed.May 28 2016, 7:17 PM

Sorry .. fat fingers and used the wrong phab task id.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL