Page MenuHomePhabricator

Regression: no longer validating gateway-specific required fields server side
Closed, ResolvedPublic1 Story Points

Description

rEDOI8329b0e9 removes the check_not_empty parameter on DonationData::getValidationErrors and DataValidator::validate.

It was still being used in GatewayAdapter::revalidate to specify gateway-specific required variables and should be restored.

Details

Related Gerrit Patches:
mediawiki/extensions/DonationInterface : masterRestore check_not_empty

Event Timeline

Ejegg created this task.May 2 2016, 6:22 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 2 2016, 6:22 PM

Change 286934 had a related patch set uploaded (by Ejegg):
Restore check_not_empty

https://gerrit.wikimedia.org/r/286934

Change 286934 merged by jenkins-bot:
Restore check_not_empty

https://gerrit.wikimedia.org/r/286934

Ejegg closed this task as Resolved.May 5 2016, 4:35 AM
Ejegg claimed this task.

Change 291530 had a related patch set uploaded (by Subramanya Sastry):
T134189: Serialize content in HTML tables using HTML tags

https://gerrit.wikimedia.org/r/291530

Sorry .. fat fingers and used the wrong phab task id.