Page MenuHomePhabricator

Email notification about "someone edited the description on Flow board" should point to the diff, not the page
Open, Needs TriagePublic

Description

I've received an email: [user] edited the description on [Flow board].

I have a button I can click on. That button shows me the page. It should be more relevant to have access to the diff, to take action if needed (on my case, it was a vandalism).

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 12 2016, 2:59 PM

I believe the only issue with this is that Flow does not currently support multi-revision diffs, so we can't send you to the aggregate diff of multiple edits.

I believe the only issue with this is that Flow does not currently support multi-revision diffs, so we can't send you to the aggregate diff of multiple edits.

I was going to say, "I think this feature exists, but it's not exposed in the frontend". It turns out it's not exposed in the backend, either, kinda...

Patch coming (just for the URL working part).

Change 289111 had a related patch set uploaded (by Mattflaschen):
Actually use old revision on header diffs, if specified

https://gerrit.wikimedia.org/r/289111

I believe the only issue with this is that Flow does not currently support multi-revision diffs, so we can't send you to the aggregate diff of multiple edits.

AFAK, we don't show grouped edits for Flow description edits.

In T135136#2299371, @Mattflaschen wrote:

Patch coming (just for the URL working part).

Thanks!

Change 289111 merged by jenkins-bot:
Actually use old revision on header diffs, if specified

https://gerrit.wikimedia.org/r/289111

The URL works now. Compare https://www.mediawiki.org/w/index.php?title=Project_talk:Sandbox/Flow_test&action=compare-header-revisions&header_oldRevision=t558ikre0rpy5s83&header_newRevision=t558jope6lmm2s5q to https://www.mediawiki.org/w/index.php?title=Project_talk:Sandbox/Flow_test&action=compare-header-revisions&header_newRevision=t558jope6lmm2s5q .

We could link from the notifications now, but we should probably first add something like the "One/X intermediate revision(s)" messages from core (diff-multi-sameuser/diff-multi-otherusers/diff-multi-manyusers) to avoid confusing people.

Trizek-WMF closed this task as Resolved.Jun 9 2016, 3:09 PM
Trizek-WMF assigned this task to Mattflaschen-WMF.

Thanks! :)

Catrope reopened this task as Open.Jun 9 2016, 3:13 PM

AIUI @Mattflaschen-WMF didn't mean that the link in the notifications had been changed, only that it's now possible to link to a multi-rev diff. We should first add text explaining that it's a multi-rev diff before we go and change the notif links.

I should have tested it first.
The goal is to have a direct access to the changes made by an other user.