Email notification about "someone edited the description on Flow board" should point to the diff, not the page
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Trizek-WMF
	May 12 2016, 2:59 PM

Description

I've received an email: [user] edited the description on [Flow board].

I have a button I can click on. That button shows me the page. It should be more relevant to have access to the diff, to take action if needed (on my case, it was a vandalism).

Details

	Subject	Repo	Branch	Lines +/-
	Actually use old revision on header diffs, if specified	mediawiki/extensions/Flow	master	+1 -1

Customize query in gerrit

Event Timeline

Trizek-WMF created this task.May 12 2016, 2:59 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 12 2016, 2:59 PM

• jmatazzoni added a project: Collaboration-Team-Triage.May 16 2016, 9:48 PM

• jmatazzoni moved this task from Untriaged to Near-Term Interest on the Collaboration-Team-Triage board.

I believe the only issue with this is that Flow does not currently support multi-revision diffs, so we can't send you to the aggregate diff of multiple edits.

In T135136#2299185, @Catrope wrote:

I believe the only issue with this is that Flow does not currently support multi-revision diffs, so we can't send you to the aggregate diff of multiple edits.

I was going to say, "I think this feature exists, but it's not exposed in the frontend". It turns out it's not exposed in the backend, either, kinda...

Patch coming (just for the URL working part).

Change 289111 had a related patch set uploaded (by Mattflaschen):
Actually use old revision on header diffs, if specified

https://gerrit.wikimedia.org/r/289111

gerritbot added a project: Patch-For-Review.May 16 2016, 11:48 PM

In T135136#2299185, @Catrope wrote:

I believe the only issue with this is that Flow does not currently support multi-revision diffs, so we can't send you to the aggregate diff of multiple edits.

AFAK, we don't show grouped edits for Flow description edits.

In T135136#2299371, @Mattflaschen wrote:

Patch coming (just for the URL working part).

Thanks!

Change 289111 merged by jenkins-bot:
Actually use old revision on header diffs, if specified

https://gerrit.wikimedia.org/r/289111

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).May 31 2016, 6:58 PM

The URL works now. Compare https://www.mediawiki.org/w/index.php?title=Project_talk:Sandbox/Flow_test&action=compare-header-revisions&header_oldRevision=t558ikre0rpy5s83&header_newRevision=t558jope6lmm2s5q to https://www.mediawiki.org/w/index.php?title=Project_talk:Sandbox/Flow_test&action=compare-header-revisions&header_newRevision=t558jope6lmm2s5q .

We could link from the notifications now, but we should probably first add something like the "One/X intermediate revision(s)" messages from core (diff-multi-sameuser/diff-multi-otherusers/diff-multi-manyusers) to avoid confusing people.

Thanks! :)

AIUI @Mattflaschen-WMF didn't mean that the link in the notifications had been changed, only that it's now possible to link to a multi-rev diff. We should first add text explaining that it's a multi-rev diff before we go and change the notif links.

I should have tested it first.
The goal is to have a direct access to the changes made by an other user.

• Mattflaschen-WMF removed • Mattflaschen-WMF as the assignee of this task.Aug 13 2016, 1:41 AM

Aklapper edited projects, added Growth-Team; removed Collaboration-Team-Triage.Oct 12 2019, 4:13 AM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:59 PM

Pppery removed a project: Patch-For-Review.Apr 1 2023, 7:52 PM

Email notification about "someone edited the description on Flow board" should point to the diff, not the pageOpen, Needs TriagePublicActions

Description

Details

Event Timeline

Email notification about "someone edited the description on Flow board" should point to the diff, not the page
Open, Needs TriagePublic
Actions