Page MenuHomePhabricator

Remove deprecated window.gM function (from jqueryMsg)
Closed, ResolvedPublic

Description

We should remove the deprecated window.gM function (from jqueryMsg). It's been deprecated since basically ever (prior to rSVN105974) and logging warnings since MW 1.23 (aad0185da5269da7e059be9f1fabfb8b3ccffb87).

Search results in extensions:

Searching 90199 files for "gM" (case sensitive, whole word)

extensions/Contest/resources/contest.special.contest.js:
   57: 								alert( window.gM( 'contest-contest-reminder-failed', data.contestantcount ) );

extensions/EducationProgram/resources/ep.enlist.js:
  262: 			this.$dialog.append( $( '<p>' ).text( gM(

extensions/EducationProgram/resources/ep.js:
   48: 				return gM.apply( this, arguments );

extensions/EducationProgram/resources/ep.pager.js:
  220: 						alert( window.gM( 'ep-pager-delete-selected-fail', ids.length ) );

4 matches across 4 files

Event Timeline

matmarex created this task.May 12 2016, 4:57 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 12 2016, 4:57 PM

Change 430007 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] mediawiki.jqueryMsg: Remove deprecated window.gM() method

https://gerrit.wikimedia.org/r/430007

Restricted Application added a project: Performance-Team. · View Herald TranscriptApr 30 2018, 11:03 PM
Krinkle claimed this task.Apr 30 2018, 11:03 PM
Krinkle added a project: MW-1.32-release.

Change 430007 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.jqueryMsg: Remove deprecated window.gM() method

https://gerrit.wikimedia.org/r/430007