Remove deprecated window.gM function (from jqueryMsg)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	May 12 2016, 4:57 PM

Description

We should remove the deprecated window.gM function (from jqueryMsg). It's been deprecated since basically ever (prior to rSVN105974) and logging warnings since MW 1.23 (aad0185da5269da7e059be9f1fabfb8b3ccffb87).

Search results in extensions:

Searching 90199 files for "gM" (case sensitive, whole word)

extensions/Contest/resources/contest.special.contest.js:
   57: 								alert( window.gM( 'contest-contest-reminder-failed', data.contestantcount ) );

extensions/EducationProgram/resources/ep.enlist.js:
  262: 			this.$dialog.append( $( '<p>' ).text( gM(

extensions/EducationProgram/resources/ep.js:
   48: 				return gM.apply( this, arguments );

extensions/EducationProgram/resources/ep.pager.js:
  220: 						alert( window.gM( 'ep-pager-delete-selected-fail', ids.length ) );

4 matches across 4 files

Details

	Subject	Repo	Branch	Lines +/-
	mediawiki.jqueryMsg: Remove deprecated window.gM() method	mediawiki/core	master	+12 -25

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Krinkle	T135148 Remove deprecated window.gM function (from jqueryMsg)
Resolved	Krinkle	T135150 Contest extension shouldn't use the deprecated window.gM function
Resolved	Krinkle	T135151 EducationProgram extension shouldn't use the deprecated window.gM function

Event Timeline

matmarex created this task.May 12 2016, 4:57 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 12 2016, 4:57 PM

matmarex created subtask T135150: Contest extension shouldn't use the deprecated window.gM function.May 12 2016, 4:58 PM

matmarex created subtask T135151: EducationProgram extension shouldn't use the deprecated window.gM function.

Danny_B moved this task from Unsorted to Needs removal on the Technical-Debt board.May 20 2016, 11:17 PM

Change 430007 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] mediawiki.jqueryMsg: Remove deprecated window.gM() method

https://gerrit.wikimedia.org/r/430007

gerritbot added a project: Patch-For-Review.Apr 30 2018, 11:02 PM

Krinkle edited projects, added MediaWiki-ResourceLoader; removed JavaScript, WMF-General-or-Unknown.Apr 30 2018, 11:03 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptApr 30 2018, 11:03 PM

Krinkle claimed this task.Apr 30 2018, 11:03 PM

Krinkle added a project: MW-1.32-release.

matmarex closed subtask T135151: EducationProgram extension shouldn't use the deprecated window.gM function as Resolved.May 1 2018, 12:34 AM

Change 430007 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.jqueryMsg: Remove deprecated window.gM() method

https://gerrit.wikimedia.org/r/430007

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)).May 3 2018, 7:00 PM

Krinkle closed this task as Resolved.May 3 2018, 8:38 PM

Krinkle removed projects: MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), Patch-For-Review.