Page MenuHomePhabricator

EducationProgram extension shouldn't use the deprecated window.gM function
Closed, ResolvedPublic

Description

EducationProgram extension shouldn't use the deprecated window.gM function. It's about to be removed.

extensions/EducationProgram/resources/ep.enlist.js:
  262: 			this.$dialog.append( $( '<p>' ).text( gM(

extensions/EducationProgram/resources/ep.js:
   48: 				return gM.apply( this, arguments );

extensions/EducationProgram/resources/ep.pager.js:
  220: 						alert( window.gM( 'ep-pager-delete-selected-fail', ids.length ) );

Event Timeline

matmarex created this task.May 12 2016, 4:59 PM

Change 430004 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/EducationProgram@master] Replace use of deprecated window.gM() with mw.msg()

https://gerrit.wikimedia.org/r/430004

Change 430004 merged by jenkins-bot:
[mediawiki/extensions/EducationProgram@master] Replace use of deprecated window.gM() with mw.msg()

https://gerrit.wikimedia.org/r/430004

matmarex closed this task as Resolved.May 1 2018, 12:34 AM
matmarex assigned this task to Krinkle.
matmarex removed a project: Patch-For-Review.

Change 430013 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/EducationProgram@wmf/1.32.0-wmf.1] Replace use of deprecated window.gM() with mw.msg()

https://gerrit.wikimedia.org/r/430013

Change 430013 merged by jenkins-bot:
[mediawiki/extensions/EducationProgram@wmf/1.32.0-wmf.1] Replace use of deprecated window.gM() with mw.msg()

https://gerrit.wikimedia.org/r/430013