EducationProgram extension shouldn't use the deprecated window.gM function
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	May 12 2016, 4:59 PM

Description

EducationProgram extension shouldn't use the deprecated window.gM function. It's about to be removed.

extensions/EducationProgram/resources/ep.enlist.js:
  262: 			this.$dialog.append( $( '<p>' ).text( gM(

extensions/EducationProgram/resources/ep.js:
   48: 				return gM.apply( this, arguments );

extensions/EducationProgram/resources/ep.pager.js:
  220: 						alert( window.gM( 'ep-pager-delete-selected-fail', ids.length ) );

Details

	Subject	Repo	Branch	Lines +/-
	Replace use of deprecated window.gM() with mw.msg()	mediawiki/extensions/EducationProgram	wmf/1.32.0-wmf.1	+6 -47
	Replace use of deprecated window.gM() with mw.msg()	mediawiki/extensions/EducationProgram	master	+6 -47

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T135148 Remove deprecated window.gM function (from jqueryMsg)
		Resolved		Krinkle	T135151 EducationProgram extension shouldn't use the deprecated window.gM function

Event Timeline

matmarex created this task.May 12 2016, 4:59 PM

Danny_B moved this task from Unsorted to Needs refactor on the Technical-Debt board.May 20 2016, 11:21 PM

Change 430004 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/EducationProgram@master] Replace use of deprecated window.gM() with mw.msg()

https://gerrit.wikimedia.org/r/430004

gerritbot added a project: Patch-For-Review.Apr 30 2018, 11:03 PM

Change 430004 merged by jenkins-bot:
[mediawiki/extensions/EducationProgram@master] Replace use of deprecated window.gM() with mw.msg()

https://gerrit.wikimedia.org/r/430004

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).May 1 2018, 12:01 AM

matmarex closed this task as Resolved.May 1 2018, 12:34 AM

matmarex assigned this task to Krinkle.

matmarex removed a project: Patch-For-Review.

Change 430013 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/EducationProgram@wmf/1.32.0-wmf.1] Replace use of deprecated window.gM() with mw.msg()

https://gerrit.wikimedia.org/r/430013

gerritbot added a project: Patch-For-Review.May 1 2018, 12:38 AM

Change 430013 merged by jenkins-bot:
[mediawiki/extensions/EducationProgram@wmf/1.32.0-wmf.1] Replace use of deprecated window.gM() with mw.msg()

https://gerrit.wikimedia.org/r/430013

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)); removed MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).May 1 2018, 10:01 PM