Page MenuHomePhabricator
Create Task
Maniphest T135534

"Editing tabs" dialog shows up again if you click edit after saving without reloading the page
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Cleared prefs to test. I'm in Chrome latest version, Win8.

  1. Edited my user page. Chose "Use the editor I chose last".
  2. Saved the edit.
  3. Edited that page again.
  4. The editing tabs dialog popped-up again (flashing, twice).

Seen at en.wiki and test2 as well.

Details

SubjectRepoBranchLines +/-
Don't show tab preference dialog again if it's already been shownmediawiki/extensions/VisualEditormaster+2 -0
Customize query in gerrit

Event Timeline

• Elitre created this task.May 17 2016, 6:25 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 17 2016, 6:25 PM
• Elitre added subscribers: QuimGil, • Whatamidoing-WMF.May 17 2016, 6:27 PM

Thanks @QuimGil for reporting. Adding @Whatamidoing-WMF as it also affects en.wp.

• Elitre updated the task description. (Show Details)May 17 2016, 6:28 PM
• Whatamidoing-WMF added a project: VisualEditor-MediaWiki.May 18 2016, 5:33 PM
Jdforrester-WMF renamed this task from "Editing tabs" dialog shows up multiple times to "Editing tabs" dialog shows up again if you click edit after saving without reloading the page.May 19 2016, 10:18 AM
Jdforrester-WMF triaged this task as Lowest priority.
Jdforrester-WMF raised the priority of this task from Lowest to Needs Triage.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF subscribed.

I don't consider this a significant issue, as the editing pattern described here isn't at all common.

Jdforrester-WMF triaged this task as Lowest priority.May 19 2016, 10:31 AM
QuimGil added a comment.May 19 2016, 11:42 AM

I am not contesting your Lowest priority, but I wouldn't say that "Edit -> Save -> Edit again" isn't at all common.

Anyway, the dialogs are gone from my editing life indeed, so I guess that most individual users will not care much about this problem either, even if they hit it.

gerritbot subscribed.May 20 2016, 1:37 AM

Change 289803 had a related patch set uploaded (by Alex Monk):
Don't show tab preference dialog again if it's already been shown

https://gerrit.wikimedia.org/r/289803

gerritbot added a project: Patch-For-Review.May 20 2016, 1:37 AM
• AlexMonk-WMF claimed this task.May 20 2016, 1:37 AM
Jdforrester-WMF closed this task as Resolved.May 20 2016, 8:23 AM
Jdforrester-WMF edited projects, added MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3)); removed Patch-For-Review.
gerritbot added a comment.May 20 2016, 8:32 AM

Change 289803 merged by jenkins-bot:
Don't show tab preference dialog again if it's already been shown

https://gerrit.wikimedia.org/r/289803

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.May 24 2016, 1:07 AM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).May 31 2016, 6:58 PM
Jdforrester-WMF edited projects, added MW-1.28-release (WMF-deploy-2016-05-31_(1.28.0-wmf.4)); removed MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).May 31 2016, 7:32 PM
QuimGil awarded a token.May 31 2016, 9:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits