Page MenuHomePhabricator

"Editing tabs" dialog shows up again if you click edit after saving without reloading the page
Closed, ResolvedPublic8 Story Points

Description

Cleared prefs to test. I'm in Chrome latest version, Win8.

  1. Edited my user page. Chose "Use the editor I chose last".
  2. Saved the edit.
  3. Edited that page again.
  4. The editing tabs dialog popped-up again (flashing, twice).

Seen at en.wiki and test2 as well.

Event Timeline

Elitre created this task.May 17 2016, 6:25 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 17 2016, 6:25 PM

Thanks @QuimGil for reporting. Adding @Whatamidoing-WMF as it also affects en.wp.

Elitre updated the task description. (Show Details)May 17 2016, 6:28 PM
Jdforrester-WMF renamed this task from "Editing tabs" dialog shows up multiple times to "Editing tabs" dialog shows up again if you click edit after saving without reloading the page.May 19 2016, 10:18 AM
Jdforrester-WMF triaged this task as Lowest priority.
Jdforrester-WMF raised the priority of this task from Lowest to Needs Triage.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

I don't consider this a significant issue, as the editing pattern described here isn't at all common.

Jdforrester-WMF triaged this task as Lowest priority.May 19 2016, 10:31 AM

I am not contesting your Lowest priority, but I wouldn't say that "Edit -> Save -> Edit again" isn't at all common.

Anyway, the dialogs are gone from my editing life indeed, so I guess that most individual users will not care much about this problem either, even if they hit it.

Change 289803 had a related patch set uploaded (by Alex Monk):
Don't show tab preference dialog again if it's already been shown

https://gerrit.wikimedia.org/r/289803

Change 289803 merged by jenkins-bot:
Don't show tab preference dialog again if it's already been shown

https://gerrit.wikimedia.org/r/289803