Terms sometimes don't seem show up in an entities term box. It works after a purge. This leads to "weird" behavior, especially regarding edits.
This is probably related to 4b52cd637a10303db1911929072e04898d0e9833.
Description
Description
Details
Details
Customize query in gerrit
Related Objects
Related Objects
- Mentioned In
- T136093: Undefined index: entities in /srv/mediawiki/php-1.28.0-wmf.2/extensions/Wikidata/extensions/ArticlePlaceholder/includes/SearchHookHandler.php on line 245
T136270: "No label defined" incorrectly shown in the page title after merging - Mentioned Here
- rEWBA4b52cd637a10: Put termbox rows into parser output
Event Timeline
Comment Actions
problem is with https://gerrit.wikimedia.org/r/#/c/288024/ and use of LabelDescriptionLookup (with EntityInfoTermLookup).
ParserOutput generation happens before/during save and before the terms table is updated. EntityInfoTermLookup, via SqlEntityInfoBuilder) collects terms from the terms table which still has old terms at the time ParserOutput (e.g. html) is generated.
Instead, we should use the LabelsProvider (and DescriptionsProvider), as done previously. These are already available in SimpleEntityTermsView and are associated with the version of the entity being saved.
We still want to provide language fallback. An in-memory term lookup could work or something else.
Comment Actions
Change 291247 had a related patch set uploaded (by Aude):
Fix display of outdated label and description in EntityView header
Comment Actions
Change 291247 merged by jenkins-bot:
Fix display of outdated label and description in EntityView header
Comment Actions
Change 292987 had a related patch set uploaded (by Aude):
Fix display of outdated label and description in EntityView header
Comment Actions
Change 292987 merged by jenkins-bot:
Fix display of outdated label and description in EntityView header
Comment Actions
Change 293048 had a related patch set uploaded (by Aude):
Update Wikibase and ArticlePlaceholder