Page MenuHomePhabricator
Create Task
Maniphest T135855

Empty language parameter in URL creates a confusing result
Closed, ResolvedPublic
Actions

Description

These 2 links, with/without an empty &language= parameter, lead to different results, if the user's interface language is set to anything except English:
https://meta.wikimedia.org/w/index.php?title=Special:Translate&group=page-Tech%2FNews%2F2016%2F21&language=&action=page&filter=
https://meta.wikimedia.org/w/index.php?title=Special:Translate&group=page-Tech%2FNews%2F2016%2F21&action=page&filter=

8tOVP9.png (1×1 px, 205 KB)

They should lead to the same (second) result.

Details

SubjectRepoBranchLines +/-
Move language validation from Special:Translate to ApiQueryMessageCollectionmediawiki/extensions/Translatemaster+91 -175
Customize query in gerrit

Event Timeline

Quiddity created this task.May 20 2016, 4:20 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 20 2016, 4:20 PM
Quiddity triaged this task as Low priority.May 20 2016, 4:20 PM
Nikerabbit lowered the priority of this task from Low to Lowest.May 23 2016, 8:03 AM
Nikerabbit added a project: good first task.
Nikerabbit subscribed.

Should be easy to fix, but because I am not aware of anything generating this kind of URLs, low priority.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 23 2016, 8:03 AM
Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.May 23 2016, 8:03 AM
gerritbot subscribed.Apr 6 2018, 2:44 PM

Change 424607 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Move language validation from Special:Translate to ApiQueryMessageCollection

https://gerrit.wikimedia.org/r/424607

gerritbot added a project: Patch-For-Review.Apr 6 2018, 2:44 PM
gerritbot added a comment.Jun 5 2018, 7:12 PM

Change 424607 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Move language validation from Special:Translate to ApiQueryMessageCollection

https://gerrit.wikimedia.org/r/424607

• Petar.petkovic removed a project: Patch-For-Review.Jun 5 2018, 7:14 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 5 2018, 8:00 PM
Nikerabbit claimed this task.Jun 6 2018, 6:05 AM
Nikerabbit edited projects, added Language-2018-Apr-June; removed good first task.
Nikerabbit moved this task from Backlog to QA on the Language-2018-Apr-June board.
Nikerabbit moved this task from QA to Done on the Language-2018-Apr-June board.Jun 13 2018, 7:04 AM
Nikerabbit closed this task as Resolved.Jun 13 2018, 2:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits