Color of search results extra data is too bright
Closed, ResolvedPublic
Actions

Description

In rMW276c30ebee4b8aa5dfee5822d37d65756f28704d, the color of .mw-search-result-data was changed from "green" (#008000, a darkish green color) to "#0f0", a very bright green. This makes the text much more glaring than was presumably intended.

Details

Subject	Repo	Branch	Lines +/-
Follow-up 276c30e: Use the correct hex for the green we want	mediawiki/core	master	+1 -1
Fix regression: text color in `.mw-search-result-data`	mediawiki/core	wmf/1.28.0-wmf.3	+1 -1
Fix regression: text color in `.mw-search-result-data`	mediawiki/core	master	+1 -1

Customize query in gerrit

Revisions and Commits

rMW MediaWiki
	Concern Raised	rMW276c30ebee4b build: Enforce the rest of the colour-related stylelints

Related Objects

Mentioned Here: rMW276c30ebee4b: build: Enforce the rest of the colour-related stylelints

Event Timeline

Yair_rand created this task.May 25 2016, 10:15 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 25 2016, 10:15 AM

Danny_B added projects: Accessibility, UI-Standardization, MediaWiki-Special-pages.May 25 2016, 11:32 AM

Danny_B moved this task from To triage to Special:LinkSearch on the MediaWiki-Special-pages board.

Danny_B moved this task from Unsorted to Colors on the Accessibility board.

Danny_B merged a task: T136186: Ridiculous neon green color in search results.May 25 2016, 12:43 PM

Danny_B added projects: Regression, MediaWiki-User-Interface.

Danny_B added a subscriber: matmarex.

rMW276c30ebee4b8aa5dfee5822d37d65756f28704d#1818023

Danny_B added a commit: rMW276c30ebee4b: build: Enforce the rest of the colour-related stylelints.May 25 2016, 12:49 PM

Danny_B triaged this task as Unbreak Now! priority.May 25 2016, 12:52 PM

Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 25 2016, 12:52 PM

Change 290706 had a related patch set uploaded (by VolkerE):
Fix green in .mw-search-result-data

https://gerrit.wikimedia.org/r/290706

gerritbot added a project: Patch-For-Review.May 25 2016, 4:05 PM

Change 290706 merged by jenkins-bot:
Fix regression: text color in .mw-search-result-data

https://gerrit.wikimedia.org/r/290706

Change 290710 had a related patch set uploaded (by Jforrester):
Fix regression: text color in .mw-search-result-data

https://gerrit.wikimedia.org/r/290710

There is one more change necessary: /mw-config/config.css line 140
I thought that commenting the diff in diffusion and linking such diff with this task would be enough, but obviously not...
We need to find the way, how to avoid this kind of missing of comments AND avoid duplicate commenting... :-/

Nemo_bis added a project: WMF-Server-Backports.May 26 2016, 10:09 AM

Change 290710 merged by jenkins-bot:
Fix regression: text color in .mw-search-result-data

https://gerrit.wikimedia.org/r/290710

Change 290976 had a related patch set uploaded (by Jforrester):
Follow-up 276c30e: Use the correct hex for the green we want

https://gerrit.wikimedia.org/r/290976

In T136175#2327073, @Danny_B wrote:

There is one more change necessary: /mw-config/config.css line 140
I thought that commenting the diff in diffusion and linking such diff with this task would be enough, but obviously not...
We need to find the way, how to avoid this kind of missing of comments AND avoid duplicate commenting... :-/

The correct way is to respond in the relevant code review system. For MediaWiki, this is now not Phabricator (which is just a downstream copy) but gerrit.

@Jdforrester-WMF I've commented in Gerrit before your cherrypicking. It didn't help either... :-/

Change 290976 merged by jenkins-bot:
Follow-up 276c30e: Use the correct hex for the green we want