Page MenuHomePhabricator
Create Task
Maniphest T136273

Assorted ULS dialog style cleanups
Closed, ResolvedPublic
Actions

Description

Some clean-ups for things that annoyed me while testing ULS.

Details

Show related patches Customize query in gerrit

Event Timeline

Nikerabbit created this task.May 26 2016, 8:15 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 26 2016, 8:15 AM
Nikerabbit added a project: Unplanned-Sprint-Work.May 26 2016, 8:16 AM
gerritbot subscribed.May 26 2016, 8:55 AM

Change 290887 had a related patch set uploaded (by Nikerabbit):
Remove unnecessary div specification from style rule

https://gerrit.wikimedia.org/r/290887

gerritbot added a project: Patch-For-Review.May 26 2016, 8:55 AM

Change 290888 had a related patch set uploaded (by Nikerabbit):
Remove excessive 5% left-padding and replace with consistent padding

https://gerrit.wikimedia.org/r/290888

gerritbot added a comment.May 26 2016, 8:55 AM

Change 290889 had a related patch set uploaded (by Nikerabbit):
Remove border-radius: no border on this element

https://gerrit.wikimedia.org/r/290889

gerritbot added a comment.May 26 2016, 8:55 AM

Change 290890 had a related patch set uploaded (by Nikerabbit):
Give language selection buttons more space

https://gerrit.wikimedia.org/r/290890

gerritbot added a comment.May 26 2016, 8:55 AM

Change 290891 had a related patch set uploaded (by Nikerabbit):
Have the background for input settings not run to the edge of the dialog

https://gerrit.wikimedia.org/r/290891

gerritbot added a comment.May 26 2016, 8:55 AM

Change 290892 had a related patch set uploaded (by Nikerabbit):
Fix the border of font selectors

https://gerrit.wikimedia.org/r/290892

gerritbot added a comment.May 26 2016, 8:55 AM

Change 290893 had a related patch set uploaded (by Nikerabbit):
Remove useless style rule

https://gerrit.wikimedia.org/r/290893

gerritbot added a comment.May 26 2016, 8:55 AM

Change 290894 had a related patch set uploaded (by Nikerabbit):
Set base font size for ULS dialogs to ensure consistent size

https://gerrit.wikimedia.org/r/290894

Nikerabbit moved this task from In Progress to In Review on the Language-Q4-2016-Sprint 3 board.May 26 2016, 8:58 AM
gerritbot added a comment.May 26 2016, 12:09 PM

Change 290920 had a related patch set uploaded (by Nikerabbit):
Remove cursor: pointer for links.

https://gerrit.wikimedia.org/r/290920

gerritbot added a comment.May 26 2016, 12:16 PM

Change 290921 had a related patch set uploaded (by Nikerabbit):
Cleanup settings-* rules in ext.uls.css

https://gerrit.wikimedia.org/r/290921

gerritbot added a comment.May 26 2016, 12:38 PM

Change 290924 had a related patch set uploaded (by Nikerabbit):
Remove styles now in jquery.uls core

https://gerrit.wikimedia.org/r/290924

• santhosh subscribed.May 30 2016, 8:44 AM
In T136273#2329301, @gerritbot wrote:

Change 290890 had a related patch set uploaded (by Nikerabbit):
Give language selection buttons more space

https://gerrit.wikimedia.org/r/290890

Issue:

pasted_file (343×710 px, 39 KB)

gerritbot added a comment.May 30 2016, 8:59 AM

Change 290924 merged by jenkins-bot:
Remove styles now in jquery.uls core

https://gerrit.wikimedia.org/r/290924

gerritbot added a comment.May 30 2016, 8:59 AM

Change 290920 merged by jenkins-bot:
Remove cursor: pointer for links.

https://gerrit.wikimedia.org/r/290920

gerritbot added a comment.May 30 2016, 9:33 AM

Change 290894 merged by jenkins-bot:
Set base font size for ULS dialogs to ensure consistent size

https://gerrit.wikimedia.org/r/290894

gerritbot added a comment.May 30 2016, 9:35 AM

Change 290893 merged by jenkins-bot:
Remove useless style rule

https://gerrit.wikimedia.org/r/290893

gerritbot added a comment.May 30 2016, 9:39 AM

Change 290892 merged by jenkins-bot:
Fix the border of font selectors

https://gerrit.wikimedia.org/r/290892

gerritbot added a comment.May 30 2016, 10:45 AM

Change 290887 merged by jenkins-bot:
Remove unnecessary div specification from style rule

https://gerrit.wikimedia.org/r/290887

gerritbot added a comment.May 30 2016, 10:51 AM

Change 290888 merged by jenkins-bot:
Remove excessive 5% left-padding and replace with consistent padding

https://gerrit.wikimedia.org/r/290888

gerritbot added a comment.May 30 2016, 10:51 AM

Change 290889 merged by jenkins-bot:
Remove border-radius: no border on this element

https://gerrit.wikimedia.org/r/290889

Nikerabbit added a comment.May 31 2016, 5:28 AM

pasted_file (303×727 px, 41 KB)

Issues seen in the photo:

  1. Insufficient and inconsistent padding for buttons with long labels.
  2. Not using all of the available space to show the language names.
  3. Extra and and inconsistent padding for buttons with short labels.
Arrbee edited projects, added Language-Q4-2016-Sprint 4; removed Language-Q4-2016-Sprint 3.May 31 2016, 7:22 AM
Arrbee moved this task from Backlog to In Review on the Language-Q4-2016-Sprint 4 board.
Aklapper added a project: UniversalLanguageSelector.May 31 2016, 8:01 AM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Jun 1 2016, 2:00 AM
gerritbot added a comment.Jun 2 2016, 4:05 AM

Change 290921 merged by jenkins-bot:
Cleanup settings-* rules in ext.uls.css

https://gerrit.wikimedia.org/r/290921

gerritbot added a comment.Jun 3 2016, 8:53 AM

Change 290890 merged by jenkins-bot:
Give language selection buttons more space

https://gerrit.wikimedia.org/r/290890

gerritbot added a comment.Jun 3 2016, 9:00 AM

Change 290891 merged by jenkins-bot:
Have the background for input settings not run to the edge of the dialog

https://gerrit.wikimedia.org/r/290891

Nikerabbit moved this task from In Review to QA on the Language-Q4-2016-Sprint 4 board.Jun 7 2016, 7:13 AM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 8 2016, 3:01 PM
Arrbee moved this task from QA to Done on the Language-Q4-2016-Sprint 4 board.Jun 13 2016, 7:03 AM
Nikerabbit closed this task as Resolved.Jul 20 2016, 1:02 PM

Looks like this was forgotten to be resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL