Page MenuHomePhabricator
Create Task
Maniphest T136322

[Dev] Rename JsonPageLoadStrategy to PageDataClient
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This class isn't strictly a data client yet but we think that renaming it will help change the way we think about it and eventually get there.

Details

SubjectRepoBranchLines +/-
Hygiene: Rename JsonPageLoadStrategy to PageDataClientapps/android/wikipediamaster+21 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Niedzielski created this task.May 26 2016, 3:59 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 26 2016, 3:59 PM
• Niedzielski added a subtask: T136321: [Dev] Transition JsonPageLoadStrategy caching to Retrofit and OkHttp.May 26 2016, 3:59 PM
Dbrant moved this task from Needs Triage to Tech Debt Backlog on the Wikipedia-Android-App-Backlog board.Jun 1 2016, 7:38 PM
Dbrant added a project: Mobile-App-Android-Sprint-90-Thorium.Aug 19 2016, 6:30 PM
• Niedzielski added a subscriber: Dbrant.EditedAug 31 2016, 3:41 PM

@Dbrant, this is unpointed but I like to remove it from the sprint in light of the extra cards coming in for screenshot testing unless someone wants to work on it.

Dbrant removed a project: Mobile-App-Android-Sprint-90-Thorium.Aug 31 2016, 4:10 PM
• Mholloway claimed this task.Sep 30 2016, 8:39 PM
• Mholloway triaged this task as Medium priority.
gerritbot subscribed.Sep 30 2016, 9:36 PM

Change 313624 had a related patch set uploaded (by Mholloway):
Rename JsonPageLoadStrategy to PageDataClient

https://gerrit.wikimedia.org/r/313624

gerritbot added a project: Patch-For-Review.Sep 30 2016, 9:36 PM
gerritbot added a comment.Oct 3 2016, 5:01 PM

Change 313624 merged by jenkins-bot:
Hygiene: Rename JsonPageLoadStrategy to PageDataClient

https://gerrit.wikimedia.org/r/313624

Dbrant set the point value for this task to 1.Oct 3 2016, 5:33 PM
Dbrant added a project: Mobile-App-Android-Sprint-92-Uranium.
Dbrant moved this task from To Do to Done on the Mobile-App-Android-Sprint-92-Uranium board.
Dbrant closed this task as Resolved.Oct 11 2016, 2:12 PM
• Mholloway closed subtask T136321: [Dev] Transition JsonPageLoadStrategy caching to Retrofit and OkHttp as Resolved.Jul 17 2017, 8:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL