Maniphest T136772

ToggleSwitchWidget's circle is not a circle
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Jun 1 2016, 10:35 PM

Tags

Referenced Files

	F4101013: T136772 ToggleSwitch ovoid – Editing Front end - Wikipedia 2016-06-01.png
	Jun 1 2016, 10:49 PM

Subscribers

Jdforrester-WMF

Description

ToggleSwitchWidget's circle in current implementation of OOjs UI (v.0.17.4) is not a circle, but ovoid due to browser rounding errors.

T136772 ToggleSwitch ovoid – Editing Front end - Wikipedia 2016-06-01.png (187×506 px, 15 KB)

Details

	Subject	Repo	Branch	Lines +/-
	MediaWiki theme: Fix ToggleSwitchWidget's grip circle shape	oojs/ui	master	+3 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T130691 Sub-pixel rendering layout issues with `em` or `%` relative units (tracking)
		Resolved		Volker_E	T136772 ToggleSwitchWidget's circle is not a circle

Event Timeline

Volker_E created this task.Jun 1 2016, 10:35 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 1 2016, 10:35 PM

Volker_E updated the task description. (Show Details)Jun 1 2016, 10:49 PM

Volker_E added a project: OOUI.

Volker_E added subscribers: Jdforrester-WMF, matmarex.

Change 292294 had a related patch set uploaded (by VolkerE):
MediaWiki theme: Fix ToggleSwitchWidget's grip circle shape

https://gerrit.wikimedia.org/r/292294

gerritbot added a project: Patch-For-Review.Jun 1 2016, 11:02 PM

We've followed a similar hacky solution at T93636: Indicator distorted in Firefox 31.5.0 & T94494: All icons and indicators blurry on IE 11, Edge 12-13.

Danny_B moved this task from Unsorted to OOUI on the UI-Standardization board.Jun 2 2016, 1:28 AM

Volker_E moved this task from Backlog to Review on the UI-Standardization-Kanban board.Jun 6 2016, 4:59 AM

Jdforrester-WMF moved this task from Backlog to OOjs-UI-0.17.5 on the OOUI board.Jun 7 2016, 10:55 AM

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.5); removed OOUI.

Change 292294 merged by jenkins-bot:
MediaWiki theme: Fix ToggleSwitchWidget's grip circle shape

https://gerrit.wikimedia.org/r/292294

Volker_E closed this task as Resolved.Jun 7 2016, 4:59 PM

Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.Jun 7 2016, 5:07 PM

Volker_E removed a project: Patch-For-Review.

Volker_E added a parent task: T130691: Sub-pixel rendering layout issues with `em` or `%` relative units (tracking).Aug 4 2016, 5:53 PM