Page MenuHomePhabricator
Create Task
Maniphest T93636

Indicator distorted in Firefox 31.5.0
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The alert indicator is distorted (scaled wrongly and truncated). This is visible both on the demo page and in the mention interface we're building for Flow.

Screenshot is from the demo page:

Distorted_Alert_Indicator.png (53×225 px, 2 KB)

It looks right without the background-size: contain (I believe from here):

Non-Distorted_Alert_Indicator.png (53×225 px, 2 KB)

I don't know if removing that is the proper solution, but it's somewhere to look.

Details

SubjectRepoBranchLines +/-
styles: Give icons, indicators `min-width/-height` for cross-browser supportoojs/uimaster+20 -5
Customize query in gerrit

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.Mar 23 2015, 7:21 PM
• Mattflaschen-WMF raised the priority of this task from to Needs Triage.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added a project: OOUI.
• Mattflaschen-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 7:21 PM
matmarex updated the task description. (Show Details)Mar 30 2015, 9:25 PM
matmarex set Security to None.
matmarex mentioned this in T94494: All icons and indicators blurry on IE 11, Edge 12-13.Mar 30 2015, 9:57 PM
Jdforrester-WMF triaged this task as Medium priority.May 4 2015, 6:12 PM
matmarex mentioned this in T102127: NumberInputWidget prone to 1px wobble in MW theme.Jun 11 2015, 4:50 PM
Volker_E mentioned this in T127744: Put current use of SVG (icon) build task and integration on trial.Mar 23 2016, 12:28 AM
Volker_E subscribed.Apr 12 2016, 12:29 AM

Connected to T132415: Edge 12 & 13: `indicatorElement-indicator` and `iconElement-icon` cut off and not scaled properly

gerritbot subscribed.Apr 12 2016, 7:09 AM

Change 282855 had a related patch set uploaded (by VolkerE):
Fix icon and indicator elements' appearance in Fx 31.5, IE 11 & Edge 12

https://gerrit.wikimedia.org/r/282855

gerritbot added a project: Patch-For-Review.Apr 12 2016, 7:09 AM
Volker_E added a comment.Apr 12 2016, 3:46 PM

@Mattflaschen I've tested the demo page without my patch set on Firefox 31.5.0 ESR/OS X and couldn't reproduce the behavior described by you here. What OS was it?

• Mattflaschen-WMF added a comment.Apr 12 2016, 11:25 PM

Almost certainly Debian.

Jdforrester-WMF moved this task from Backlog to OOjs-UI-0.16.6 on the OOUI board.Apr 19 2016, 4:34 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.16.6); removed OOUI.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 4:34 PM
Jdforrester-WMF closed this task as Resolved.Apr 19 2016, 8:25 PM
Jdforrester-WMF assigned this task to Volker_E.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
gerritbot added a comment.Apr 19 2016, 8:40 PM

Change 282855 merged by jenkins-bot:
styles: Give icons, indicators min-width/-height for cross-browser support

https://gerrit.wikimedia.org/r/282855

Catrope mentioned this in T136024: OO.ui.ButtonSelectWidget: Buttons differ in size if they have icons only or label only.May 27 2016, 12:40 AM
Volker_E mentioned this in T136772: ToggleSwitchWidget's circle is not a circle.Jun 1 2016, 11:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL