Page MenuHomePhabricator
Create Task
Maniphest T102127

NumberInputWidget prone to 1px wobble in MW theme
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Esanders
Jun 11 2015, 3:10 PM
Tags
Referenced Files
F4985391: T102127 Edge_Win10 OOjs UI demo 2016-12-05.png
Dec 6 2016, 12:40 AM
F4595517: T142110-NumberInput-wobble-Chrome_Win-before-315456---OOjs-UI-Demos-2016-10-11.png
Oct 12 2016, 8:42 AM
F4595522: T142110-NumberInput-wobble-Chrome_Win-after-315456---OOjs-UI-Demos-2016-10-11.png
Oct 12 2016, 8:42 AM
F4595523: T142110-NumberInput-wobble-IE_Win-before-315456---OOjs-UI-Demos-2016-10-11.png
Oct 12 2016, 8:42 AM
F4595524: T142110-NumberInput-wobble-IE11_Win-after-315456---OOjs-UI-Demos-2016-10-11.png
Oct 12 2016, 8:42 AM
F4591990: T142110 NumberInput wobble Fx_Mac before 315456 - OOjs UI Demos 2016-10-11.png
Oct 12 2016, 5:56 AM
F4591995: T142110 NumberInput wobble Fx_Mac after 315456 - OOjs UI Demos 2016-10-11.png
Oct 12 2016, 5:56 AM
F4591676: T142110 NumberInput wobble before 315456 - OOjs UI Demos 2016-10-11.png
Oct 12 2016, 5:55 AM
View All 12 Files
Subscribers
Aklapper
Esanders
Etonkovidova
Jdforrester-WMF
matmarex
RHo
SamanthaNguyen
Volker_E

Description

T102127 NumberInputWidget wobbles OOjs UI Demos 2016-08-04.png (284×666 px, 21 KB)
(v0.17.7)
Borders don't quite line up sometimes – horizontally and vertically

Details

SubjectRepoBranchLines +/-
MediaWiki theme: Fix misalignment of widgets by applying pixel `min-height`oojs/uimaster+12 -15
NumberInputWidget: Set input to 100% heightoojs/uimaster+5 -0
MediaWiki theme: Ensure framed buttons are same heightoojs/uimaster+17 -6
MediaWiki theme: Address subpixel rendering errors in buttoned widgetsoojs/uimaster+26 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Jun 11 2015, 3:10 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: OOUI.
Esanders added subscribers: Esanders, Aklapper.
matmarex subscribed.Jun 11 2015, 4:50 PM

I'm pretty sure this is caused by rounding errors of the multiplications of tiny em values, same as T94494 and T93636, and therefore hopeless.

matmarex merged a task: T107246: NumberInputWidget has rendering defect in Chrome.Jul 31 2015, 9:32 PM
matmarex added a subscriber: Krinkle.
Volker_E subscribed.Sep 17 2015, 5:15 AM

@matmarex We could maybe set a min-height on this special one...? And at least lower the pain.

matmarex added a comment.Sep 17 2015, 4:45 PM

Maybe? Not sure if that would help. I say we do T94750 and see if that helps.

matmarex added a subtask: T94750: In MediaWiki theme, button height should be controlled only by 'padding' and label 'line-height'.Sep 17 2015, 5:22 PM

(I checked the patch there and it does seem to help.)

Jdforrester-WMF closed subtask T94750: In MediaWiki theme, button height should be controlled only by 'padding' and label 'line-height' as Resolved.Sep 18 2015, 3:22 PM
matmarex added a comment.Sep 19 2015, 7:27 AM

On closer inspection, I can still reproduce with Firefox and IE 11, but not other browsers.

Esanders added a comment.Mar 20 2016, 12:10 PM

There is a multi pixel error on API sandbox:

pasted_file (63×739 px, 1 KB)

matmarex added a comment.Mar 20 2016, 5:52 PM

Yeah, that's because of T97631.

Jdforrester-WMF triaged this task as Low priority.Mar 22 2016, 6:39 PM
Jdforrester-WMF set Security to None.
Krinkle unsubscribed.Mar 22 2016, 7:40 PM
Volker_E mentioned this in T130691: Sub-pixel rendering layout issues with `em` or `%` relative units (tracking).Mar 23 2016, 12:58 AM
Esanders mentioned this in T139220: Cancel and edit icon misaligned in link inspector.Jul 2 2016, 9:24 PM
Volker_E added a parent task: T130691: Sub-pixel rendering layout issues with `em` or `%` relative units (tracking).Aug 4 2016, 5:42 PM
Volker_E claimed this task.Aug 4 2016, 8:30 PM
Volker_E added a project: UI-Standardization-Kanban.
Volker_E updated the task description. (Show Details)
Restricted Application added a project: UI-Standardization. · View Herald TranscriptAug 4 2016, 8:30 PM
gerritbot subscribed.Aug 5 2016, 1:18 PM

Change 297260 had a related patch set uploaded (by VolkerE):
MediaWiki theme: Ensure framed buttons are same height

https://gerrit.wikimedia.org/r/297260

gerritbot added a project: Patch-For-Review.Aug 5 2016, 1:18 PM
Volker_E moved this task from Backlog to Review on the UI-Standardization-Kanban board.Aug 5 2016, 1:25 PM
Volker_E moved this task from Unsorted to OOUI on the UI-Standardization board.Aug 5 2016, 7:22 PM
gerritbot added a comment.Aug 6 2016, 4:07 AM

Change 303338 had a related patch set uploaded (by VolkerE):
MediaWiki theme: Fix misalignment of widgets by applying pixel min-height

https://gerrit.wikimedia.org/r/303338

Volker_E updated the task description. (Show Details)Aug 6 2016, 4:09 AM
Volker_E added subscribers: Jdforrester-WMF, RHo.
Volker_E raised the priority of this task from Low to High.Aug 11 2016, 9:36 PM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.
gerritbot added a comment.Oct 12 2016, 1:17 AM

Change 315456 had a related patch set uploaded (by VolkerE):
MediaWiki theme: Address subpixel rendering errors in NumberInputWidget

https://gerrit.wikimedia.org/r/315456

Volker_E added a comment.EditedOct 12 2016, 5:55 AM
BeforeWith 315456
Chrome 53/OS X
T142110 NumberInput wobble before 315456 - OOjs UI Demos 2016-10-11.png (358×664 px, 25 KB)
T142110 NumberInput wobble after 315456 - OOjs UI Demos 2016-10-11.png (366×674 px, 26 KB)
Firefox 49/OS X
T142110 NumberInput wobble Fx_Mac before 315456 - OOjs UI Demos 2016-10-11.png (283×667 px, 26 KB)
T142110 NumberInput wobble Fx_Mac after 315456 - OOjs UI Demos 2016-10-11.png (284×663 px, 26 KB)
Chrome 53/Win
T142110-NumberInput-wobble-Chrome_Win-before-315456---OOjs-UI-Demos-2016-10-11.png (297×675 px, 12 KB)
T142110-NumberInput-wobble-Chrome_Win-after-315456---OOjs-UI-Demos-2016-10-11.png (297×675 px, 12 KB)
IE 11/Win
T142110-NumberInput-wobble-IE_Win-before-315456---OOjs-UI-Demos-2016-10-11.png (371×842 px, 15 KB)
T142110-NumberInput-wobble-IE11_Win-after-315456---OOjs-UI-Demos-2016-10-11.png (371×842 px, 14 KB)
Volker_E added a comment.Oct 12 2016, 8:47 AM

Seems to tame, but not to solve… :/

gerritbot added a comment.Nov 8 2016, 11:18 PM

Change 315456 merged by jenkins-bot:
MediaWiki theme: Address subpixel rendering errors in buttoned widgets

https://gerrit.wikimedia.org/r/315456

Jdforrester-WMF added a comment.Nov 29 2016, 11:14 PM

Still not Resolved?

Jdforrester-WMF moved this task from Reviewing to Next-up on the OOUI board.Nov 29 2016, 11:19 PM
SamanthaNguyen subscribed.Nov 30 2016, 2:08 AM
Volker_E added a subscriber: Etonkovidova.Dec 2 2016, 1:55 AM
Volker_E added a comment.Dec 6 2016, 12:40 AM

315456 seemed to just have a positive effect on Chrome/Mac OS X.

T102127 Edge_Win10 OOjs UI demo 2016-12-05.png (347×659 px, 36 KB)

Edge 14 Win 10 (via BrowserStack)

Jdforrester-WMF added a comment.Dec 6 2016, 8:42 PM

:-(

Jdforrester-WMF removed a project: Patch-For-Review.Dec 6 2016, 8:42 PM
Volker_E moved this task from Next-up to Reviewing on the OOUI board.Mar 12 2017, 6:15 AM
gerritbot added a comment.Mar 12 2017, 6:40 AM

Change 297260 abandoned by VolkerE:
MediaWiki theme: Ensure framed buttons are same height

Reason:
Abandoned in favor of Ic2935cb5d9 and I9a2d3975927

https://gerrit.wikimedia.org/r/297260

gerritbot added a comment.Mar 12 2017, 6:51 AM

Change 342323 had a related patch set uploaded (by VolkerE):
[oojs/ui] NumberInputWidget: Set input to 100% height

https://gerrit.wikimedia.org/r/342323

gerritbot added a project: Patch-For-Review.Mar 12 2017, 6:51 AM
gerritbot added a comment.Mar 14 2017, 6:17 PM

Change 342323 merged by jenkins-bot:
[oojs/ui] NumberInputWidget: Set input to 100% height

https://gerrit.wikimedia.org/r/342323

Volker_E moved this task from Reviewing to OOjs-UI-0.20.0 on the OOUI board.Mar 14 2017, 7:22 PM
Volker_E edited projects, added OOUI (OOjs-UI-0.20.0); removed OOUI.
gerritbot added a comment.Mar 16 2017, 1:58 AM

Change 303338 abandoned by VolkerE:
MediaWiki theme: Fix misalignment of widgets by applying pixel min-height

Reason:
Resolved through several other patches in the meantime :)

https://gerrit.wikimedia.org/r/303338

Jdforrester-WMF added a comment.Mar 16 2017, 2:05 AM

Resolved?

Volker_E removed a project: Patch-For-Review.Mar 17 2017, 8:00 PM
Volker_E removed a subscriber: gerritbot.
Volker_E closed this task as Resolved.Mar 22 2017, 11:10 PM
Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.Apr 7 2017, 12:12 AM
Volker_E mentioned this in T216578: NumberInputWidget prone to 1px difference, again.Feb 20 2019, 12:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits