Page MenuHomePhabricator

Unhelpful "WMF Cookie statement" and "Developers" footer links shown in print version in Monobook
Closed, ResolvedPublic

Description

Hello,

At the end of the printable versions, the English Wikibooks doesn't display the MediaWiki footer, whereas the French does it. However it shouldn't, because the two last sentences on every French Wikibooks PDF mean nothing without their hyperlinks:
Développeurs
Déclaration sur les cookies

Example:
https://fr.wikibooks.org/w/index.php?title=Programmation_PHP&useskin=monobook k (CTRL+P)
https://en.wikibooks.org/w/index.php?title=PHP_Programming&useskin=monobook (CTRL+P)

So, as their isn't any class "noprint" either in the MediaWiki namespace nor in Translatewiki, I have to ask you: could you please remove these two footer sentences from the French Wikibooks printable versions please?

Then I'll have to reprint them.

Event Timeline

WFM.

Please provide OS and browser version. Try to clear your cache too.

This occurs for several days on Firefox 46.0.1, Windows 10 at least, with an empty cache.
I'm sure that it has nothing to see with my config because the class "noprint" works properly.

I don't see those items you mentioned there, hence why I asked for your browser/OS. I tested in FF 46.0.1, so obviously it isn't browser issue. Do you have any gadgets turned on?

Screenshot with marked issue (or description where to see it) would be handy as well...

Thanks.

The task description talks about "French Wikibooks PDF" and the links provided are the print view (no PDFs involved). What are the exact and full steps to reproduce the problem?

These two sentences are displayed at the bottom of the online printable version, and so they are printed in every PDF.

Please find below the bottom of my linked page above: https://fr.wikibooks.org/w/index.php?title=Programmation_PHP&printable=yes

fr.b bug.PNG (610×1 px, 29 KB)

PS: if I untick all my gadgets and https://meta.wikimedia.org/wiki/User:JackPotte/global.js and empty my cache, it persists, but if I login with my bot account I can't see them.
The only difference might be that my bot isn't bureaucrat.

Guess what, I'm bureaucrat on the French Wiktionary too, and the undesirable sentences are present too:
https://fr.wiktionary.org/w/index.php?title=bug&printable=yes

fr.wikt bug.PNG (273×1 px, 16 KB)

I've finally found the common denominator: this bug only occurs with Monobook, not Vector.

Ah. I can confirm for Monobook on any page, e.g. https://ar.wiktionary.org/w/index.php?title=bug&printable=yes&useskin=monobook&uselang=qqx

The extension WikimediaMessages provides and inserts those items:
./WikimediaMessages.hooks.php: $template->data['footerlinks']['places'][] = 'cookiestatement';

Aklapper renamed this task from Footer into the printable version to Unhelpful "WMF Cookie statement" and "Developers" footer links shown in printable version in Monobook.Jun 2 2016, 12:54 PM
Aklapper added a project: MonoBook.

Maybe we should change the footer structure of monobook to be similar to the one of Vector ? I don't think many people rely on a specific DOM implementation of that.
Would also fix T33219: MonoBook: Footer is malformed

Clarification, in Vector there are two groups, footer-info (with copyright and last modified) and footer-places (with all the links to other pages). On monobook and other 'old' skins, these elements share a group and the print style only hides those elements that it knows to hide (and so not non-default elements added using a hook).

Note: everything in the footer uses IDs instead of classnames...

Jdlrobson subscribed.

Printableversion is deprecated as of T167956

Reopened. This is not printable specific. It happens with normal print as well.
https://fr.wikibooks.org/w/index.php?title=Programmation_PHP&useskin=monobook

Jdlrobson renamed this task from Unhelpful "WMF Cookie statement" and "Developers" footer links shown in printable version in Monobook to Unhelpful "WMF Cookie statement" and "Developers" footer links shown in print version in Monobook.Aug 5 2020, 3:00 PM
Jdlrobson updated the task description. (Show Details)

Change 620428 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/skins/MonoBook@master] Print: Hide accessibility jump links and cookie statement

https://gerrit.wikimedia.org/r/620428

Change 620428 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Print: Hide accessibility jump links and cookie statement

https://gerrit.wikimedia.org/r/620428

Jdlrobson claimed this task.