Page MenuHomePhabricator

Get Poland back on the monuments database
Closed, ResolvedPublic

Description

@Yarl noticed that Poland does not show up in the monuments database. Let’s fix this :)

Event Timeline

Clearly there is no pl data in the database:

MariaDB [s51138__heritage_p]> SELECT COUNT(*) FROM monuments_all WHERE country='pl';
+----------+
| COUNT(*) |
+----------+
|        0 |
+----------+
1 row in set (0.01 sec)
MariaDB [s51138__heritage_p]> SELECT COUNT(*) FROM monuments_all WHERE lang='pl';
+----------+
| COUNT(*) |
+----------+
|        0 |
+----------+

However fill_table_monuments_all.sql does have some Polish data ; as well as monuments_config.py

Hmmm, interesting:

MariaDB [s51138__heritage_p]> SELECT COUNT(*) FROM `monuments_pl-old_(pl)` ;
+----------+
| COUNT(*) |
+----------+
|    10250 |
+----------+
1 row in set (0.00 sec)

So this old/new system was changed in e13eaed and 0b406af.

Anyway, @Yarl, could you check the configuration in monuments_config.py ? The issue definitely comes from there as no data is harvested from it.

$ python update_database.py -countrycode:pl -lang:pl
Working on countrycode "pl" in language "pl"
Retrieving 50 pages from wikipedia:pl.
Unknown error occurred when processing country pl in lang pl
Un-defined converter in config for monuments_pl_(pl): generateRegistrantUrl

This is true for more sources and was mentioned on the database statistics
talk page on Commons during the weekend.

Thanks for finding the source for this!

Hmmm, interesting:

MariaDB [s51138__heritage_p]> SELECT COUNT(*) FROM `monuments_pl-old_(pl)` ;
+----------+
| COUNT(*) |
+----------+
|    10250 |
+----------+
1 row in set (0.00 sec)

This is one of the datasets which would be removed with T136704. So if it shoud be kept please also give a shout there.

I’m closing this as duplicate of T137096. Poland seems fine again. Feel free to reopen if needed.

JeanFred claimed this task.