VisualEditor registers a dependency on "visualeditor-quick-access-characters.json" but it doesn't exist
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Jun 8 2016, 10:17 PM

Details

	Subject	Repo	Branch	Lines +/-
	Make visualeditor-quick-access-characters.json always exist	mediawiki/extensions/VisualEditor	master	+10 -7

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T129976 Provide a structural unit test to confirm each module message exists
		Resolved		• AlexMonk-WMF	T137368 VisualEditor registers a dependency on "visualeditor-quick-access-characters.json" but it doesn't exist

Event Timeline

Jdforrester-WMF created this task.Jun 8 2016, 10:17 PM

Restricted Application added a subscriber: Zppix. · View Herald TranscriptJun 8 2016, 10:17 PM

It doesn't necessarily exist. I think I wrote this so that it's optional, can be created by wiki admins if they want it. Maybe we should set it to -?

But - isn't valid JSON. I guess we could set it to {}?

Krinkle assigned this task to Krenair.Jun 10 2016, 2:41 PM

Per discussion with Krinkle, null is probably better. Note we also have this pattern in Cite (Visualeditor-cite-tool-definition.json) and Citoid (citoid-template-type-map.json).