Page MenuHomePhabricator
Create Task
Maniphest T138473

[Regression] JS exception on fa.wiki
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

I was verifying the deployment of lazy loaded images and after seeing that the images weren't loading I found out this exception in the console:

https://fa.m.wikipedia.org/wiki/%DA%A9%DB%8C%D8%B4_%DB%8C%DA%A9_%D8%A2%D8%AF%D9%85%E2%80%8C%DA%A9%D8%B4:_%D8%A7%D9%81%D8%B4%D8%A7%DA%AF%D8%B1%DB%8C%E2%80%8C%D9%87%D8%A7

TypeError: mw.util is undefined TypeError: mw.util is undefined
Stack trace:
@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=ext.centralauth.centralautologin.clearcookie%7Cext.eventLogging%7Cext.eventLogging.subscriber%7Cext.gadget.mobile-common%7Cjquery.accessKeyLabel%2Cclient%2Ccookie%7Cmediawiki.RegExp%2Capi%2Ccookie%2Cnotify%2Cstorage%2Ctemplate%2Cuser%2Cutil%7Cmediawiki.api.user%7Cmediawiki.page.startup%7Cmediawiki.template.hogan%7Cmobile.browser%2Ccontext%2CmainMenu%2Cmodules%2Coo%2Cuser%2Cview%7Cmobile.loggingSchemas.mobileWebMainMenuClickTracking%7Cmobile.mainMenu.icons%7Coojs%7Cschema.MobileWebMainMenuClickTracking%7Cskins.minerva.scripts.top%7Cuser.defaults&skin=minerva&version=78238850eff1:9:21
jQuery.Callbacks/fire@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:45:104
jQuery.Callbacks/self.add@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:45:656
jQuery.fn.ready@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:49:40
jQuery.fn.init@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:41:250
jQuery@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:1:637
@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=ext.centralauth.centralautologin.clearcookie%7Cext.eventLogging%7Cext.eventLogging.subscriber%7Cext.gadget.mobile-common%7Cjquery.accessKeyLabel%2Cclient%2Ccookie%7Cmediawiki.RegExp%2Capi%2Ccookie%2Cnotify%2Cstorage%2Ctemplate%2Cuser%2Cutil%7Cmediawiki.api.user%7Cmediawiki.page.startup%7Cmediawiki.template.hogan%7Cmobile.browser%2Ccontext%2CmainMenu%2Cmodules%2Coo%2Cuser%2Cview%7Cmobile.loggingSchemas.mobileWebMainMenuClickTracking%7Cmobile.mainMenu.icons%7Coojs%7Cschema.MobileWebMainMenuClickTracking%7Cskins.minerva.scripts.top%7Cuser.defaults&skin=minerva&version=78238850eff1:6:402
execute/runScript/<@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:163:114
jQuery.Callbacks/fire@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:45:104
jQuery.Callbacks/self.add@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:45:656
.Deferred/promise.always@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:46:865
execute/runScript@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:162:986
execute/</checkCssHandles@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:163:814
execute@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:164:519
mw.loader.implement@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=f47W3i0j:170:790
@https://fa.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=ext.centralauth.centralautologin.clearcookie%7Cext.eventLogging%7Cext.eventLogging.subscriber%7Cext.gadget.mobile-common%7Cjquery.accessKeyLabel%2Cclient%2Ccookie%7Cmediawiki.RegExp%2Capi%2Ccookie%2Cnotify%2Cstorage%2Ctemplate%2Cuser%2Cutil%7Cmediawiki.api.user%7Cmediawiki.page.startup%7Cmediawiki.template.hogan%7Cmobile.browser%2Ccontext%2CmainMenu%2Cmodules%2Coo%2Cuser%2Cview%7Cmobile.loggingSchemas.mobileWebMainMenuClickTracking%7Cmobile.mainMenu.icons%7Coojs%7Cschema.MobileWebMainMenuClickTracking%7Cskins.minerva.scripts.top%7Cuser.defaults&skin=minerva&version=78238850eff1:6:321
  • OSX 10.11
  • Firefox 49.0a2 (2016-06-22)

After reloading, the error went away and haven't been able to reproduce properly.

Seems like we have some RL misconfiguration somewhere...

Details

SubjectRepoBranchLines +/-
Explicitly depend on mediawiki.util where neededmediawiki/extensions/MobileFrontendmaster+11 -0
Customize query in gerrit

Related Objects

Event Timeline

• Jhernandez created this task.Jun 23 2016, 11:12 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 23 2016, 11:12 AM
• Jhernandez added a comment.Jun 23 2016, 11:14 AM

I'd argue that this is Unbreak now given that if this happens no images on the page are loaded...

• Jhernandez mentioned this in T134003: Deploy lazy loaded images to a few more wikis.Jun 23 2016, 11:15 AM
• bmansurov added a project: Web-Team-Backlog.Jun 23 2016, 5:01 PM
Jdlrobson removed a project: Web-Team-Backlog.Jun 23 2016, 5:08 PM
Jdlrobson added a project: Web-Team-Backlog.Jun 23 2016, 5:11 PM
• jhobs triaged this task as Unbreak Now! priority.Jun 23 2016, 5:13 PM
• jhobs moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.
• jhobs added projects: Reading-Web-Sprint-75-Quantitative-Paralysis, Unplanned-Sprint-Work.
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptJun 23 2016, 5:13 PM
dr0ptp4kt moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 23 2016, 5:34 PM
gerritbot subscribed.Jun 23 2016, 9:19 PM

Change 295756 had a related patch set uploaded (by Jdlrobson):
Explicitly depend on mediawiki.util where needed

https://gerrit.wikimedia.org/r/295756

gerritbot added a project: Patch-For-Review.Jun 23 2016, 9:19 PM
Jdlrobson subscribed.Jun 23 2016, 9:20 PM

I can't reproduce this and I don't see how this could be related to lazy loading images but I think if there is an issue the above patch should fix it.

Jdlrobson moved this task from To Do to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 23 2016, 9:20 PM
• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 23 2016, 11:52 PM
gerritbot added a comment.Jun 23 2016, 11:58 PM

Change 295756 merged by jenkins-bot:
Explicitly depend on mediawiki.util where needed

https://gerrit.wikimedia.org/r/295756

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-28_(1.28.0-wmf.8)).Jun 24 2016, 12:00 AM
• Jhernandez closed this task as Resolved.Jun 27 2016, 10:17 AM
• Jhernandez claimed this task.

Thanks @Jdlrobson, this should be good enough. I'm closing given how unreproducible this is... Will reopen if the issue shows up.

• Jhernandez renamed this task from JS exception on fa.wiki to [Regression] JS exception on fa.wiki.Jun 30 2016, 9:00 AM
Jdlrobson set the point value for this task to 0.5.Jun 30 2016, 3:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits