Page MenuHomePhabricator
Create Task
Maniphest T138481

Citoid API response with misformatted ISSN field in zotero format
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Investigating doi:10.1039/b309952k properties.

Calling API by citoid.wikimedia.org/api?format=zotero.

Receiving answer containing "ISSN":"undefined1463-9084", but hoping for ISSN:"1463-9084" value only.

Details

SubjectRepoBranchLines +/-
Fix bug where listToString adds undefined to stringmediawiki/services/citoidmaster+17 -7
Customize query in gerrit

Related Objects

Event Timeline

PerfektesChaos created this task.Jun 23 2016, 12:21 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 23 2016, 12:21 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript
Mvolz moved this task from Backlog to IO Tasks on the Citoid board.Jul 29 2016, 2:52 PM
Jdforrester-WMF triaged this task as Low priority.Aug 2 2016, 7:14 PM
Jdforrester-WMF subscribed.

Zotero Translator issue, perhaps?

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Aug 2 2016, 7:14 PM
Jdforrester-WMF moved this task from TR0: Interrupt to External and Administrivia on the VisualEditor board.Aug 9 2016, 7:30 PM
Mvolz closed this task as Resolved.Oct 28 2016, 3:28 PM
Mvolz subscribed.

Rechecked, seems to be working now.

T103478 will be the appropriate task if it pops up again.

PerfektesChaos mentioned this in T103478: Citoid service should validate ISSN in mediawiki format.Jan 6 2017, 1:10 PM
Mvolz renamed this task from Citoid API response with misformatted ISSN field to Citoid API response with misformatted ISSN field in zotero format.Jan 6 2017, 4:38 PM
Mvolz reopened this task as Open.
Mvolz claimed this task.
Mvolz moved this task from IO Tasks to Site specific issues on the Citoid board.Jan 6 2017, 5:00 PM
Mvolz added a comment.Jan 6 2017, 5:40 PM

@PerfektesChaos are you using citoid.mediawikia.org & zotero format for anything? FYI that endpoint is being de-commed at some point: T133001

gerritbot subscribed.Jan 9 2017, 11:37 AM

Change 331246 had a related patch set uploaded (by Mvolz):
Fix bug where listToString adds undefined to string

https://gerrit.wikimedia.org/r/331246

gerritbot added a project: Patch-For-Review.Jan 9 2017, 11:37 AM
Mvolz added a comment.Jan 9 2017, 11:39 AM

Ended up being a genuine bug, it was just that our validation in mediawiki format was masking it ^-^.

Mvolz moved this task from Site specific issues to Service: Scraper & Validation on the Citoid board.Jan 9 2017, 2:16 PM
gerritbot added a comment.Jan 9 2017, 6:35 PM

Change 331246 merged by jenkins-bot:
Fix bug where listToString adds undefined to string

https://gerrit.wikimedia.org/r/331246

• mobrovac moved this task from Service: Scraper & Validation to Waiting on Deploy on the Citoid board.Jan 9 2017, 6:36 PM
• mobrovac edited projects, added User-mobrovac; removed Patch-For-Review.
• mobrovac removed a subscriber: gerritbot.
• mobrovac closed this task as Resolved.Jan 18 2017, 1:22 AM
• mobrovac subscribed.

Deployed, resolving.

Jdforrester-WMF set the point value for this task to 0.Feb 3 2017, 9:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits