Page MenuHomePhabricator
Create Task
Maniphest T103478

Citoid service should validate ISSN in mediawiki format
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Insert citation with VisualEditor for "http://chroniclingamerica.loc.gov/lccn/sn85040224/"

Result:

"The Daily Palo Alto times.". ISSN None Check |issn= value (help). Retrieved 2015-06-23. 

Meta data of the target url:

<meta name="DC.title" content="The Daily Palo Alto times." />
<meta name="DC.publisher" content="Times Pub. Co." />
<meta name="DC.issued" content="1905/1943" />
<meta name="DC.identifier" content="info:lccn/sn85040224" />
<meta name="DC.identifier" content="info:oclcnum/11682912" />
<meta name="DC.identifier" content="urn:issn:None" />
<meta name="DC.type" content="text" />
<meta name="DC.subject" content="California--Palo Alto.--fast--(OCoLC)fst01212098" />
<meta name="DC.subject" content="Palo Alto (Calif.)--Newspapers." />
 
<meta name="DC.language" content="eng" />

<link title="MODS Metadata Schema" rel="schema.mods" href="http://www.loc.gov/standards/mods/mods.xsd" />
<meta name="mods.title" content="The Daily Palo Alto times." />
<meta name="mods.place" content="Palo Alto, Calif." />
<meta name="mods.place" content="California--Santa Clara--Palo Alto" />
<meta name="mods.url" content="http://chroniclingamerica.loc.gov/lccn/sn85040224/" />
<meta name="mods.issn" content="None" />
<meta name="mods.lccn" content="sn85040224" />
<meta name="mods.languageTerm" content="eng" />


<meta name="citation_title" content="The Daily Palo Alto times." />
<meta name="citation_issn" content="None" />

While it is unfortunate, it seems not uncommon for loc.gov to output these kind of values. It produces a user-visible error (surfaced through the template parsing preview), but not a native VE error and it will make its way into page content when saved as-is without looking carefully at the preview.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use stricter validation for ISSNsmediawiki/services/citoidmaster+60 -3
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jun 23 2015, 6:26 AM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Citoid, VisualEditor.
Krinkle subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2015, 6:26 AM
Krinkle renamed this task from Citoid should omit IISN if value from loc.gov is invalid (e.g. "None") to Citoid should omit ISSN if value from loc.gov is invalid (e.g. "None").Jun 23 2015, 6:26 AM
Krinkle set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jun 29 2015, 6:57 PM
Jdforrester-WMF triaged this task as Low priority.Jun 29 2015, 9:24 PM
Mvolz moved this task from Backlog to IO Tasks on the Citoid board.Jul 21 2015, 12:28 PM
Mvolz renamed this task from Citoid should omit ISSN if value from loc.gov is invalid (e.g. "None") to Citoid service should validate ISSN.Oct 28 2016, 3:26 PM
Mvolz raised the priority of this task from Low to Medium.
Mvolz mentioned this in T138481: Citoid API response with misformatted ISSN field in zotero format.Oct 28 2016, 3:28 PM
Mvolz moved this task from IO Tasks to Service: Scraper & Validation on the Citoid board.
PerfektesChaos subscribed.Jan 6 2017, 1:10 PM

From T138481, citoid.wikimedia.org/api?format=zotero still yields "ISSN":"undefined1463-9084".

Mvolz renamed this task from Citoid service should validate ISSN to Citoid service should validate ISSN in mediawiki format.EditedJan 6 2017, 4:37 PM
Mvolz closed this task as Resolved.
Mvolz subscribed.
In T103478#2923298, @PerfektesChaos wrote:

From T138481, citoid.wikimedia.org/api?format=zotero still yields "ISSN":"undefined1463-9084".

Yeah, we validate in mediawiki format (have for a little while, forgot to resolve this task, apparently), in Zotero format we don't. There is probably an underlying bug somewhere though, I will investigate this in the other task.

Jdforrester-WMF set the point value for this task to 0.Jan 10 2017, 11:27 PM
Jdforrester-WMF moved this task from Freezer to External and Administrivia on the VisualEditor board.
Krinkle added a comment.Jan 26 2017, 12:03 AM
In T103478#2923632, @Mvolz wrote:

Yeah, we validate in mediawiki format (have for a little while, forgot to resolve this task, apparently), in Zotero format we don't.

I don't know what "mediawiki format" is, but using these simple steps in VisualEditor, the problem still persists:

  • Add a citation
  • Paste url http://chroniclingamerica.loc.gov/lccn/sn85040224/
  • Results in an error:
    Screen Shot 2017-01-26 at 00.03.07.png (414×824 px, 49 KB)
Mvolz added a comment.Jan 26 2017, 10:03 AM
In T103478#2970911, @Krinkle wrote:
In T103478#2923632, @Mvolz wrote:

Yeah, we validate in mediawiki format (have for a little while, forgot to resolve this task, apparently), in Zotero format we don't.

I don't know what "mediawiki format" is, but using these simple steps in VisualEditor, the problem still persists:

  • Add a citation
  • Paste url http://chroniclingamerica.loc.gov/lccn/sn85040224/
  • Results in an error:
    Screen Shot 2017-01-26 at 00.03.07.png (414×824 px, 49 KB)

Nooooo. :) VE uses mediawiki format, so it means our validation is flawed. Alas.

Mvolz reopened this task as Open.Jan 26 2017, 10:03 AM
Mvolz claimed this task.
gerritbot subscribed.Jan 26 2017, 10:16 AM

Change 334265 had a related patch set uploaded (by Mvolz):
Use stricter validation for ISSNs

https://gerrit.wikimedia.org/r/334265

gerritbot added a project: Patch-For-Review.Jan 26 2017, 10:16 AM
gerritbot added a comment.Feb 1 2017, 12:37 AM

Change 334265 merged by jenkins-bot:
Use stricter validation for ISSNs

https://gerrit.wikimedia.org/r/334265

• mobrovac moved this task from Service: Scraper & Validation to Waiting on Deploy on the Citoid board.Feb 1 2017, 12:38 AM
• mobrovac removed a project: Patch-For-Review.
• mobrovac removed a subscriber: gerritbot.
Stashbot mentioned this in T158675: Update zotero translators on gerrit from the zotero repository on github.Mar 7 2017, 10:08 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2017-03-07T22:08:47Z] <mobrovac@tin> Started deploy [citoid/deploy@5a7e053]: Deploy for T158675 T103478 T159486

Stashbot mentioned this in T159486: setup/deploy scb2005 & scb2006.Mar 7 2017, 10:08 PM
Stashbot added a comment.Mar 7 2017, 10:11 PM

Mentioned in SAL (#wikimedia-operations) [2017-03-07T22:11:24Z] <mobrovac@tin> Finished deploy [citoid/deploy@5a7e053]: Deploy for T158675 T103478 T159486 (duration: 02m 36s)

• mobrovac closed this task as Resolved.Mar 8 2017, 12:13 AM
• mobrovac subscribed.

Deployed, resolving.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 8 2017, 12:13 AM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Mar 28 2017, 11:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits