Page MenuHomePhabricator

When you change the name of a parameter, ParamOrder should get updated to use the new name
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:

  1. Start with a template and some (valid) TemplateData for it.
  2. Change the template, so that parameter_X is now called thingabob_Y.
  3. Decide that you need to update the TemplateData. Decide that, while you're at it, you'll improve the TemplateData.
    1. Rearrange the order of the parameters.
    2. Save the page.
    3. Change parameter_X to thingabob_Y.
    4. Save the page.
    5. Get (accurate) error message that there is an Invalid value for property "paramOrder[13]".

Results:

If you look at the ParamOrder section of the JSON, the parameter order list still shows the old name. If you manually fix the name, it saves with no difficulty.

Details

Related Gerrit Patches:
mediawiki/extensions/TemplateData : masterMove around parameter renaming logic to update paramOrder

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 28 2016, 12:07 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript

Change 296401 had a related patch set uploaded (by Alex Monk):
Move around parameter renaming logic to update paramOrder

https://gerrit.wikimedia.org/r/296401

Jdforrester-WMF triaged this task as High priority.Jun 29 2016, 12:17 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF closed this task as Resolved.Jun 29 2016, 12:41 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.

Change 296401 merged by jenkins-bot:
Move around parameter renaming logic to update paramOrder

https://gerrit.wikimedia.org/r/296401