Page MenuHomePhabricator
Create Task
Maniphest T138911

isbn.py -to13 has fatal error when processing an ISBN13
Closed, ResolvedPublic
Actions

Description

I run isbn.py and it shows this error

$ python pwb.py isbn.py -to13 -family:wikipedia -lang:en -page:List_of_Dragonlance_novels -simulate
Retrieving 50 pages from wikipedia:fa.
Traceback (most recent call last):
  File "pwb.py", line 248, in <module>
    if not main():
  File "pwb.py", line 242, in main
    run_python_file(filename, [filename] + args, argvu, file_package)
  File "pwb.py", line 120, in run_python_file
    main_mod.__dict__)
  File "./scripts/isbn.py", line 1659, in <module>
    main()
  File "./scripts/isbn.py", line 1652, in main
    bot.run()
  File "./scripts/isbn.py", line 1521, in run
    self.treat(page)
  File "./scripts/isbn.py", line 1496, in treat
    new_text = self.isbnR.sub(_isbn10toIsbn13, new_text)
  File "./scripts/isbn.py", line 1458, in _isbn10toIsbn13
    i13 = getIsbn(isbn).toISBN13()
AttributeError: 'ISBN13' object has no attribute 'toISBN13'
<type 'exceptions.AttributeError'>
CRITICAL: Closing network session.

Details

SubjectRepoBranchLines +/-
isbn.py: convertIsbn10toIsbn13 should not fail for ISBN13pywikibot/coremaster+10 -1
Fix isbn.py -to13 operation when ISBN are already in this formatpywikibot/coremaster+5 -1
Added a function toISBN13 in the class ISBN13pywikibot/coremaster+2 -0
Added a function toISBN13 in the class ISBN13pywikibot/coremaster+4 -0
Added a function toISBN13 in the class ISBN13pywikibot/coremaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Yamaha5 created this task.Jun 29 2016, 7:24 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 29 2016, 7:24 AM
Danny_B edited projects, added Pywikibot; removed Pywikibot-Announce.Jul 3 2016, 10:50 AM
Restricted Application added a subscriber: pywikibot-bugs-list. · View Herald TranscriptJul 3 2016, 10:50 AM
jayvdb renamed this task from isbn.py has fatal erro to isbn.py has fatal error.Jul 3 2016, 11:36 AM
jayvdb renamed this task from isbn.py has fatal error to isbn.py -to13 has fatal error when processing an ISBN13.Jul 3 2016, 11:46 AM
jayvdb triaged this task as Medium priority.
jayvdb updated the task description. (Show Details)Jul 3 2016, 12:00 PM
jayvdb raised the priority of this task from Medium to High.Jul 3 2016, 12:10 PM
jayvdb added projects: Pywikibot-Scripts, good first task.
jayvdb subscribed.

This code was modified by 8a87eaecd95 , but the previous code also had the same bug, with the following stacktrace

Retrieving 1 pages from wikipedia:en.
Traceback (most recent call last):
  File "pwb.py", line 222, in <module>
    run_python_file(filename, argv, argvu, file_package)
  File "pwb.py", line 81, in run_python_file
    main_mod.__dict__)
  File "./scripts/isbn.py", line 1553, in <module>
    main()
  File "./scripts/isbn.py", line 1548, in main
    bot.run()
  File "./scripts/isbn.py", line 1422, in run
    self.treat(page)
  File "./scripts/isbn.py", line 1397, in treat
    newText = self.isbnR.sub(_isbn10toIsbn13, newText)
  File "./scripts/isbn.py", line 1359, in _isbn10toIsbn13
    i13 = i.toISBN13()
AttributeError: ISBN13 instance has no attribute 'toISBN13'

The bug comes from 2007. 4c001a42b https://mediawiki.org/wiki/Special:Code/pywikipedia/4262

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 3 2016, 12:10 PM
Aadith1996 claimed this task.Sep 24 2016, 2:40 PM
gerritbot subscribed.Sep 25 2016, 8:09 AM

Change 312720 had a related patch set uploaded (by Aadith1996):
Added a function toISBN13 in the class ISBN13

https://gerrit.wikimedia.org/r/312720

gerritbot added a project: Patch-For-Review.Sep 25 2016, 8:09 AM
Xqt subscribed.Sep 25 2016, 8:21 AM
gerritbot added a comment.Sep 25 2016, 9:02 AM

Change 312724 had a related patch set uploaded (by Aadith1996):
Added a function toISBN13 in the class ISBN13

https://gerrit.wikimedia.org/r/312724

gerritbot added a comment.Sep 25 2016, 9:14 AM

Change 312725 had a related patch set uploaded (by Aadith1996):
Added a function toISBN13 in the class ISBN13

https://gerrit.wikimedia.org/r/312725

gerritbot added a comment.Sep 25 2016, 9:24 AM

Change 312726 had a related patch set uploaded (by Aadith1996):
Added a function toISBN13 in the class ISBN13

https://gerrit.wikimedia.org/r/312726

gerritbot added a comment.Sep 25 2016, 10:14 AM

Change 312720 abandoned by Aadith1996:
Added a function toISBN13 in the class ISBN13

Reason:
SOrry, got confused by gerrit git. The final gerrit can be found at https://gerrit.wikimedia.org/r/#/c/312726/

https://gerrit.wikimedia.org/r/312720

gerritbot added a comment.Sep 25 2016, 10:15 AM

Change 312725 abandoned by Aadith1996:
Added a function toISBN13 in the class ISBN13

Reason:
Sorry, got confused by gerrit git. The final gerrit can be found at https://gerrit.wikimedia.org/r/#/c/312726/

https://gerrit.wikimedia.org/r/312725

gerritbot added a comment.Sep 25 2016, 10:15 AM

Change 312724 abandoned by Aadith1996:
Added a function toISBN13 in the class ISBN13

Reason:
Sorry, got confused by gerrit git. The final gerrit can be found at https://gerrit.wikimedia.org/r/#/c/312726/

https://gerrit.wikimedia.org/r/312724

Aadith1996 added a comment.Sep 25 2016, 10:16 AM

Sorry for the confusion with gerrit.
The final patchset can be found at https://gerrit.wikimedia.org/r/#/c/312726/

AbdealiJK subscribed.Sep 29 2016, 4:03 PM
gerritbot added a comment.Oct 30 2016, 7:39 AM

Change 312726 merged by jenkins-bot:
Fix isbn.py -to13 operation when ISBN are already in this format

https://gerrit.wikimedia.org/r/312726

Magul removed a project: Patch-For-Review.Nov 15 2016, 8:42 PM
gerritbot added a comment.Nov 27 2016, 6:38 AM

Change 323676 had a related patch set uploaded (by Dalba):
isbn.py: convertIsbn10toIsbn13 should not fail for ISBN13

https://gerrit.wikimedia.org/r/323676

gerritbot added a project: Patch-For-Review.Nov 27 2016, 6:38 AM
gerritbot added a comment.Dec 31 2016, 8:32 AM

Change 323676 merged by jenkins-bot:
isbn.py: convertIsbn10toIsbn13 should not fail for ISBN13

https://gerrit.wikimedia.org/r/323676

Magul closed this task as Resolved.Jan 1 2017, 1:12 PM
Xqt mentioned this in T314942: Pywikibot client to load ISBN related data into Wikidata.Sep 2 2022, 10:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL