Page MenuHomePhabricator

Notification page side panel: sorting order of pages is incorrect
Closed, InvalidPublic

Description

Split from comments on T129366: List wikis and pages with unread notifications in the Notification Page left nav

According to the specs the side panel should sort

  1. pages alphabetically
  2. user/user talk pages override alphabetical sorting and should be placed on top of of the list

And

  1. user/user talk pages should have a user icon.

These are summarized in the following quote from T129366: List wikis and pages with unread notifications in the Notification Page left nav.

From the list of pages, the user page (and user talk page) are represented with a user icon, and placed at the top of the list (unlike the other items which are ordered alphabetically).

  1. The list of pages is not sorted alphabetically - the sort order is based on the number of unread messages (as the first criteria) and the most recent timestamp (as the second criteria). Thus, 'Zmevetuna' in the screenshot below is placed before 'Mevetuna' even though they have the same number of msgs, but 'Zmevetuna' msg has the most recent timestamp.

Screen Shot 2016-07-07 at 11.24.40 AM.png (402×1 px, 89 KB)

  1. User pages are not automatically placed at the top of the list. It's illustrated in the above screenshot; the screenshot below is another example of user page/user talk page not given the priority in sorting.

Screen Shot 2016-07-07 at 11.39.04 AM.png (444×356 px, 34 KB)

  1. all messages display the same icon (the article icon).

Event Timeline

Elena writes:

According to the specs the side panel should sort

  • pages alphabetically
  • user/user talk pages override alphabetical sorting and should be placed on top of of the list

Just to clarify, I believe the intended ordering of pages within a given wiki is as follows:

  • User talk pages first (with the correct icon)
  • Then in descending order by number of messages.
  • For pages that tie in number of messages, order alphabetically.

@Pginer-WMF, does that sound right?

@Pginer-WMF, does that sound right?

Yes.

Regarding the talk pages, the main goal was to surface your own one since we now that messages there are considered with priority. If we think that this is also the case for other talk pages, we can do the same (but I don't recall much input from users regarding that).

Regarding the talk pages, the main goal was to surface your own one

Yes, that's what I meant. Thanks.

SBisson added a subscriber: SBisson.

Per @jmatazzoni and @Pginer-WMF , the current order is correct. The user page filter will have to be put on top when it is added in T137502: Display page-less notifications together with the user page