Broken serialization of a table row when a cell is edited to included paragraph breaks
Closed, DuplicatePublic0 Estimated Story Points
Actions

Assigned To

None

Authored By

	• Whatamidoing-WMF
	Jul 8 2016, 6:16 PM

Description

See https://en.wikipedia.org/w/index.php?title=X86&diff=728898840&oldid=728897826

Given a table that (unknown to the user) has its wikitext like this:

{|
|-
| '''5th''' ([[Superscaler]]) || 1993 || [[P5 (microarchitecture)|Pentium]], [[Pentium MMX]],  [[Rise Technology|Rise]] [[mP6]] || [[Superscalar]] [[64-bit]] [[Bus (computing)|databus]], faster FPU, [[MMX (instruction set)|MMX]] (2× 32-bit), [[Socket 7]]
|-
|}

If you add line breaks/new paragraphs to a cell, then you get a table-breaking mess when you save the page:

{|
|-
| '''5th''' ([[Superscaler]])

My new paragraph here

My next paragraph here  

|| 1993 || [[P5 (microarchitecture)|Pentium]], [[Pentium MMX]],  [[Rise Technology|Rise]] [[mP6]] || [[Superscalar]] [[64-bit]] [[Bus (computing)|databus]], faster FPU, [[MMX (instruction set)|MMX]] (2× 32-bit), [[Socket 7]]
|-
|}

There is no way for the editor to know that adding a paragraph to this particular table is going to break everything. Instead, the entire row ought to be saved in the non-single-row format.

Event Timeline

• Whatamidoing-WMF created this task.Jul 8 2016, 6:16 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 8 2016, 6:16 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript

This doesn't need edits necessarily, but, since data-parsoid exists only on original content, this behavior is only triggered on edits. The stx_v:row annotation needs to be ignored by the serializer here since the previous cell has a paragraph break.

[subbu@earth parsoid] cat /tmp/new.html
<table><tr><td><p>a</p><p>b</p></td><td data-parsoid='{"stx_v":"row"}'>bar</td></tr></tbody></table>
[subbu@earth parsoid] parse.js --html2wt < /tmp/new.html
{|
|a

b
||bar
|}

Jdforrester-WMF set the point value for this task to 0.Jul 11 2016, 6:25 PM

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Jdforrester-WMF moved this task from TR0: Interrupt to External and Administrivia on the VisualEditor board.Aug 9 2016, 7:34 PM

Arlolra closed this task as a duplicate of T149209: Parsoid serialised an edit to a wikitext table adding a /n without stripping the double-pipes, breaking the table format (`\n|| align="right" | …`).Dec 10 2016, 12:05 AM

Broken serialization of a table row when a cell is edited to included paragraph breaksClosed, DuplicatePublic0 Estimated Story PointsActions

Description

Event Timeline

Broken serialization of a table row when a cell is edited to included paragraph breaks
Closed, DuplicatePublic0 Estimated Story Points
Actions