Page MenuHomePhabricator
Create Task
Maniphest T139795

Nedersaksies doesn't appear in Compact Language List panel
Closed, ResolvedPublic
Actions

Description

To reproduce:

Observed: Nedersaksies (nds-nl) doesn't appear.

Expected: It must appear under Europe and also when searching for "neder".

One thing I noticed is that the lang attribute of the language link for this language is "nds-NL" rather than "nds-nl" as I'd expect. Maybe browsers or HTMLtidy, or something else at some stage normalizes language code prefixes that are country names to upper case, but this is just a guess. If I go to getInterlanguageList() and change this.getAttribute( 'lang' ) to this.getAttribute( 'lang' ).toLowerCase(), it fixes this issue, but there may be a better solution.

High priority, because all bugs about missing languages are triaged as such.

First reported at https://www.mediawiki.org/wiki/Topic:T7cyivsztzge738k .

Details

SubjectRepoBranchLines +/-
CompactLinks: lowercase language codes for internal usemediawiki/extensions/UniversalLanguageSelectormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Jul 8 2016, 8:31 PM
Restricted Application added a project: UniversalLanguageSelector. · View Herald TranscriptJul 8 2016, 8:31 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript
Amire80 triaged this task as High priority.Jul 8 2016, 8:31 PM
Amire80 moved this task from Backlog to Missing languages on the ULS-CompactLinks board.
Amire80 updated the task description. (Show Details)Jul 8 2016, 8:49 PM
santhosh added subscribers: Nikerabbit, santhosh.Jul 11 2016, 9:40 AM

@Nikerabbit, Do you know from where this uppercase country code comes in nds-NL? It is nds-nl in Names.php. In ULS(jquery uls data) it is nds-nl.

Nikerabbit added a comment.Jul 11 2016, 9:47 AM

All language codes in HTML are supposed to be pretty-formatted with wfBCP47 or Language::getHtmlCode. Hence mapping it back to lower case is what we should do internally in ULS (and then pretty it again when it ends up in HTML).

Arrbee edited projects, added Language-Q1-2016-17 Sprint 2; removed Language-Q1-2016-17 Sprint 1.Jul 13 2016, 8:04 AM
gerritbot subscribed.Jul 26 2016, 1:14 PM

Change 301114 had a related patch set uploaded (by Nikerabbit):
CompactLinks: lowercase language codes for internal use

https://gerrit.wikimedia.org/r/301114

Nikerabbit claimed this task.Jul 26 2016, 1:15 PM

The proposed fix is sufficient to fix this issue. Separate issue is the lack of wfBCP47 in jquery.uls.

Nikerabbit moved this task from Backlog to In Review on the Language-Q1-2016-17 Sprint 2 board.Jul 26 2016, 1:15 PM
gerritbot added a comment.Jul 27 2016, 6:03 AM

Change 301114 merged by jenkins-bot:
CompactLinks: lowercase language codes for internal use

https://gerrit.wikimedia.org/r/301114

Nikerabbit moved this task from In Review to QA on the Language-Q1-2016-17 Sprint 2 board.Jul 27 2016, 6:13 AM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)).Jul 27 2016, 7:00 AM
Amire80 moved this task from Backlog to CX10 on the Language-Engineering July-September 2016 board.Jul 31 2016, 11:27 AM
Nikerabbit moved this task from QA to Done on the Language-Q1-2016-17 Sprint 2 board.Aug 4 2016, 6:47 AM

Confirmed on he and ca Wikipedias.

Amire80 closed this task as Resolved.Aug 9 2016, 8:06 PM

Verified in production.

Amire80 mentioned this in T143527: nds-nl is not consistently lowercased in compact language links.Aug 21 2016, 7:45 PM
Amire80 moved this task from Backlog to Missing languages on the UniversalLanguageSelector board.Oct 31 2017, 12:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits