"Unhandled Exception" error in Diffusion when displaying a repository with only one empty commit
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Aklapper
	Jul 13 2016, 1:06 PM

Description

Go to https://phabricator.wikimedia.org/diffusion/ECOL/
In the list of files and folders, click on "OfflineContentGenerator/" which links to https://phabricator.wikimedia.org/diffusion/external/?uri=https%3A%2F%2Fgerrit.wikimedia.org%2Fr%2Fmediawiki%2Fextensions%2FCollection%2FOfflineContentGenerator&id=a7a79ccc3f7cf774cf42f91991381b2799df0ff6
End up on URL https://phabricator.wikimedia.org/diffusion/EOCS/browse/master/;a7a79ccc3f7cf774cf42f91991381b2799df0ff6 which says:

Unhandled Exception ("Exception")
Expected "<mode> <type> <hash> <size>\t<name>", for ls-tree of "a7a79ccc3f7cf774cf42f91991381b2799df0ff6:", got:

Related Objects

Mentioned In: rPHDEP306bc9730657: Updated git submodules
rPHDEP2d0e4c4eda89: Updated git submodules
Mentioned Here: rEOCGa7a79ccc3f7c: Initial empty repository

Event Timeline

Aklapper created this task.Jul 13 2016, 1:06 PM

Restricted Application added a subscriber: Zppix. · View Herald TranscriptJul 13 2016, 1:06 PM

Paladox subscribed.Jul 13 2016, 1:08 PM

The problem is that rECOL extension-Collection has an empty tree at rEOCGa7a79ccc3f7c: Initial empty repository.

There is probably a better way to handle this than simply throwing an exception at DiffusionBrowseQueryConduitAPIMethod.php:115

Restricted Application added a project: Upstream. · View Herald TranscriptJul 13 2016, 1:28 PM

Restricted Application added a subscriber: TerraCodes. · View Herald Transcript

Upstream report already exists: https://secure.phabricator.com/T10155

• mmodell moved this task from Backlog to Upstreamed on the Phabricator (Upstream) board.Jul 13 2016, 1:35 PM

Aklapper renamed this task from "Unhandled Exception" clicking external submodule (Gerrit URI redirect) in Diffusion to "Unhandled Exception" error in Diffusion when displaying a repository with only one empty commit.Jul 13 2016, 5:03 PM

Aklapper triaged this task as Lowest priority.

Was there a task filled upstream?

It errors out here https://github.com/phacility/phabricator/blob/121e68e3adae4cd21731b79c07ca89676def7e19/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php#L117 so I suppose that needs support for empty tree's?

Paladox added a comment.Sep 8 2016, 3:29 PM

This comment was removed by Paladox.

In T140236#2619473, @Paladox wrote:

Was there a task filled upstream?

See https://phabricator.wikimedia.org/T140236#2457738

Oh thanks.

https://secure.phabricator.com/D16525

• mmodell mentioned this in rPHDEP2d0e4c4eda89: Updated git submodules.Sep 9 2016, 2:17 AM

@mmodell Thank you, are you deploying the fix now?

Paladox moved this task from Backlog to Patch proposed upstream on the Upstream board.Sep 9 2016, 2:29 AM

• mmodell mentioned this in rPHDEP306bc9730657: Updated git submodules.Oct 13 2016, 9:06 AM

This is deployed.

"Unhandled Exception" error in Diffusion when displaying a repository with only one empty commitClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

"Unhandled Exception" error in Diffusion when displaying a repository with only one empty commit
Closed, ResolvedPublic
Actions