Page MenuHomePhabricator
Create Task
Maniphest T140538

Link with annotations gets split on re-render
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

  1. Create a MediaWiki document with
[[Main Page|''italic'' link]]

or

[http://example.org ''italic'' link]
  1. Click on either link and remove the link, then press undo to restore it
  2. Observe you now have two links.

This also happens with freshly typed text (not from Parsoid) but doesn't happen in VE-core.

Details

SubjectRepoBranchLines +/-
TransactionProcessor: Apply annotations to ranges at the highest uniform offsetVisualEditor/VisualEditormaster+130 -9
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jul 16 2016, 3:00 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 16 2016, 3:01 PM
Esanders added a comment.Jul 16 2016, 3:01 PM

Quite probably related to T52098, but interesting that it doesn't happen in core.

gerritbot subscribed.Jul 18 2016, 4:56 PM

Change 299570 had a related patch set uploaded (by Divec):
TransactionProcessor: Apply annotations to ranges at the highest uniform offset

https://gerrit.wikimedia.org/r/299570

gerritbot added a project: Patch-For-Review.Jul 18 2016, 4:56 PM
Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.Jul 18 2016, 7:11 PM
Jdforrester-WMF assigned this task to dchan.Jul 22 2016, 7:04 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added a project: VisualEditor-ContentEditable.
Jdforrester-WMF set the point value for this task to 8.
dchan added a comment.Jul 25 2016, 10:31 AM

You can do it in core with the following example:

  1. Edit <h1><a href=x><i>foo</i>bar</a></h1>
  2. Observe that there is a single link.
  3. Click to remove the link, then undo to restore it
  4. Observe that there are two adjacent links.
gerritbot added a comment.Aug 5 2016, 1:02 AM

Change 299570 merged by jenkins-bot:
TransactionProcessor: Apply annotations to ranges at the highest uniform offset

https://gerrit.wikimedia.org/r/299570

Jdforrester-WMF closed this task as Resolved.Aug 5 2016, 6:40 PM
Jdforrester-WMF edited projects, added MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)); removed Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits