Page MenuHomePhabricator
Create Task
Maniphest T140581

Stop using jQuery UI Selectable for Flickr uploads
Closed, ResolvedPublic
Actions

Description

We should stop using jQuery UI Selectable for Flickr uploads. We've already gotten rid of all other uses of jQuery UI per T96914: Migrate UploadWizard UI elements to OOjs UI; there isn't a direct replacement for Selectable in OOjs UI. But the CheckboxMultiselectWidget introduced per T117782 should be close enough.

Details

SubjectRepoBranchLines +/-
mw.FlickrChecker: Replace jQuery UI Selectable with CheckboxMultiselectWidgetmediawiki/extensions/UploadWizardmaster+32 -47
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Jul 17 2016, 7:04 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptJul 17 2016, 7:04 PM
Restricted Application added subscribers: Zppix, Steinsplitter, Aklapper. · View Herald Transcript
matmarex added a subtask: T140582: Stop relying on jQuery UI styles in UploadWizard.Jul 17 2016, 8:28 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptJul 17 2016, 8:28 PM
gerritbot subscribed.Jul 17 2016, 8:36 PM

Change 299492 had a related patch set uploaded (by Bartosz Dziewoński):
mw.FlickrChecker: Replace jQuery UI Selectable with CheckboxMultiselectWidget

https://gerrit.wikimedia.org/r/299492

gerritbot added a project: Patch-For-Review.Jul 17 2016, 8:36 PM
matmarex mentioned this in T97202: Enable various core modules for mobile to make UploadWizard work.Jul 17 2016, 8:38 PM
matmarex claimed this task.Jul 17 2016, 9:04 PM
matmarex closed subtask T140582: Stop relying on jQuery UI styles in UploadWizard as Resolved.Jul 18 2016, 5:59 PM
gerritbot added a comment.Jul 18 2016, 6:25 PM

Change 299492 merged by jenkins-bot:
mw.FlickrChecker: Replace jQuery UI Selectable with CheckboxMultiselectWidget

https://gerrit.wikimedia.org/r/299492

matmarex closed this task as Resolved.Jul 18 2016, 6:32 PM
matmarex removed a project: Patch-For-Review.
matmarex added a comment.Jul 18 2016, 6:37 PM
BeforeAfter
pasted_file (1×1 px, 607 KB)
pasted_file (1×1 px, 715 KB)
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-19_(1.28.0-wmf.11)).Jul 18 2016, 7:00 PM
matmarex mentioned this in T141529: TypeError: undefined is not an object (evaluating 'uploadObj.ui.div').Jul 28 2016, 3:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits