TypeError: undefined is not an object (evaluating 'uploadObj.ui.div')
This seems to be new in 1.28.0-wmf.12.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | matmarex | T136230 Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day | |||
| Resolved | matmarex | T141529 TypeError: undefined is not an object (evaluating 'uploadObj.ui.div') |
Event Timeline
Comment Actions
Oh, I see it now. The new Flickr file choosing interface from T140581 can be cheated and allows you to select more than 50 files when Shift-clicking. But mw.UploadWizard#addUpload has stricter checks and returns false for every upload after the limit, not adding it; Flickr code doesn't check for it and breaks.
uploadObj = checker.wizard.addUpload( upload ); $( '#mwe-upwiz-filelist' ).append( uploadObj.ui.div );
This is luckily not causing any big problems, the excess files are just ignored. So setting to Low.
I think https://gerrit.wikimedia.org/r/299349 in OOjs UI will resolve this. I've been testing the Flickr chooser change with that, and never ran into this problem.
Comment Actions
This should be resolved with rMW46708622dda3: Update OOjs UI to v0.17.7, which includes the aforementioned patch, and which will be deployed to Wikimedia wikis next week.