Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day
Closed, ResolvedPublic
Actions

Description

Some time ago, before the new Multimedia team started working seriously on UploadWizard again, it was throwing thousands of exceptions every day, according to our logging data.

Date	Uncaught exceptions
20151002	10927
20151003	11431
20151004	15274
20151005	18870
20151006	12872

We're in a lot better situation today, but it's still kind of terrible:

Date	Uncaught exceptions
20160519	1366
20160520	634
20160521	419
20160522	716
20160523	517

So let's focus on this for a bit.

I glanced through recent data and I think 50/day is a reasonable goal to aim for. We should be able to get it down to 150 or so without breaking a sweat, there are lots of identical errors which look kind of obvious (mentioning variables by a name we only use once in the whole codebase, etc.). 50 will be challenging, and any further than that might not really be possible, since by that point we'll be probably left with unreproduceable random failures and useless error messages. We have things like "Script error" or "Out of memory" in the logs that don't really look like we'll be able to guess what causes them.

Related Objects
Search...

Status	Assigned	Task
Resolved	matmarex	T136230 Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day
Duplicate	None	T136231 Uncaught TypeError: str.replace is not a function
Declined	matmarex	T136232 Uncaught TypeError: this.get(...).querySelectorAll is not a function
Resolved	matmarex	T136234 Uncaught TypeError: Cannot read property 'description' of undefined
Resolved	matmarex	T136235 Typed array constructor argument is invalid
Resolved	matmarex	T136236 Uncaught TypeError: Cannot read property 'code' of undefined
Resolved	matmarex	T136237 Uncaught TypeError: Cannot read property 'toLowerCase' of null
Resolved	matmarex	T136238 Uncaught TypeError: Cannot read property 'getMainText' of null
Resolved	matmarex	T136239 Not enough storage is available to complete this operation
Resolved	matmarex	T136819 Various jqueryMsg failures
Resolved	matmarex	T136831 NS_ERROR_NOT_AVAILABLE
Resolved	matmarex	T130610 When chunked uploading very large files, upload progress bar gets stuck with errors in the console about "too much recursion" / "call stack size exceeded" (but upload succeeds?)
Resolved	matmarex	T139129 Uncaught TypeError: Cannot read property 'getName' of null
Resolved	matmarex	T139130 Uncaught TypeError: Cannot read property 'resolve' of undefined / queue[title] is undefined
Resolved	matmarex	T143759 JS mw.Title does not strip Unicode bidi control characters from input, unlike PHP MediaWikiTitleCodec
Open	None	T143810 JS mw.Title does not normalize input to NFC form
Resolved	Anomie	T29849 API: add normalized info also for unicode normalization of titles
Duplicate	None	T139131 TypeError: extension is null
Resolved	matmarex	T139132 Uncaught TypeError: Cannot read property 'parseDom' of undefined
Resolved	matmarex	T139133 Uncaught TypeError: Cannot read property 'warnings' of undefined
Resolved	matmarex	T141529 TypeError: undefined is not an object (evaluating 'uploadObj.ui.div')
Resolved	matmarex	T145341 Unspecified error.

Event Timeline

matmarex created this task.May 25 2016, 7:28 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptMay 25 2016, 7:28 PM

Restricted Application added subscribers: Zppix, Steinsplitter, Aklapper. · View Herald Transcript

matmarex created subtask T136231: Uncaught TypeError: str.replace is not a function.May 25 2016, 7:37 PM

Restricted Application added a subscriber: Matanya. · View Herald TranscriptMay 25 2016, 7:37 PM

matmarex created subtask T136232: Uncaught TypeError: this.get(...).querySelectorAll is not a function.May 25 2016, 7:38 PM

matmarex created subtask T136234: Uncaught TypeError: Cannot read property 'description' of undefined.

matmarex created subtask T136235: Typed array constructor argument is invalid.

matmarex created subtask T136236: Uncaught TypeError: Cannot read property 'code' of undefined.May 25 2016, 7:41 PM

matmarex created subtask T136237: Uncaught TypeError: Cannot read property 'toLowerCase' of null.

matmarex created subtask T136238: Uncaught TypeError: Cannot read property 'getMainText' of null.

matmarex created subtask T136239: Not enough storage is available to complete this operation.May 25 2016, 7:45 PM

Should be enough subtasks for now ;) I'll file more when we fix these. If anyone wants to work on anything, they're free for taking. These are the most common error messages in the few days' sample I was looking through.

matmarex closed subtask T136232: Uncaught TypeError: this.get(...).querySelectorAll is not a function as Declined.Jun 2 2016, 10:00 AM

matmarex created subtask T136819: Various jqueryMsg failures.Jun 2 2016, 12:22 PM

matmarex closed subtask T136819: Various jqueryMsg failures as Resolved.Jun 2 2016, 12:41 PM

matmarex created subtask T136831: NS_ERROR_NOT_AVAILABLE.Jun 2 2016, 2:32 PM

The patterns are rather interesting. Some of the very prominent errors seem to affect just a single user or two on a particular day, and for some reason they occur thousands of times and spam our data. At least two of the ones I'm seeing ("this.get(...).querySelectorAll is not a function" and "clearSelection is not defined") are clearly bogus and probably caused by some buggy browser extensions the user has installed. So… I guess we'll need to identify and filter them out to reach the 50/day target ;)

Here are counts of the most common error messages from the last days, plotted by day and by message ("NULL" signifies all other errors, grouped together):

uploadwizard-exceptions-stats-byday.tsv1 KBDownload

message	20160518	20160519	20160520	20160521	20160522	20160523	20160524	20160525	20160526	20160527	20160528	20160529	20160530	20160531	20160601	20160602
NULL	28	120	101	64	72	126	97	51	114	130	40	123	87	147	95	26
Argument konstruktoru typovaného pole je neplatný.	0	0	0	0	0	1	54	69	0	0	0	0	39	0	0	0
Für diesen Vorgang ist nicht genügend Speicher verfügbar.	0	71	54	0	63	27	43	0	1	0	0	4	97	32	0	2
NS_ERROR_NOT_AVAILABLE:	0	0	0	0	1	2	54	3	0	1	3	1	2	7	1010	0
Not enough storage is available to complete this operation.	7	48	4	4	3	8	5	12	0	5	6	2	0	0	0	3
TypeError: str.replace is not a function	36	146	17	72	49	49	5	27	122	101	204	86	70	275	1	0
TypeError: this.descriptionsDetails.getSerialized(...).descriptions[0] is undefined	0	9	9	7	17	9	9	18	13	8	12	12	17	31	29	1
Typed array constructor argument is invalid	0	120	47	0	4	0	5	10	0	0	46	7	78	0	0	0
Unbekannter Fehler.	0	10	17	0	16	4	10	0	1	0	0	30	31	17	0	0
Uncaught ReferenceError: clearSelection is not defined	0	0	0	0	0	0	0	0	1656	0	0	0	0	0	0	0
Uncaught TypeError: Cannot read property 'code' of undefined	0	17	17	39	29	34	22	31	64	14	48	39	77	63	47	51
Uncaught TypeError: Cannot read property 'description' of undefined	5	47	31	61	64	39	59	51	56	43	46	36	58	61	22	23
Uncaught TypeError: Cannot read property 'getMainText' of null	0	0	25	18	25	7	1	157	16	1	3	32	31	26	5	9
Uncaught TypeError: Cannot read property 'getName' of null	0	4	35	3	10	4	1	0	3	11	7	4	8	25	3	6
Uncaught TypeError: Cannot read property 'toLowerCase' of null	0	20	1	1	0	8	23	0	16	0	11	45	17	0	1	26
Uncaught TypeError: str.replace is not a function	11	203	130	149	190	195	134	194	72	135	101	121	156	181	37	0
Uncaught TypeError: this.get(...).querySelectorAll is not a function	0	522	9	0	0	0	0	0	0	33	12	200	1146	0	0	0
Uncaught TypeError: undefined is not a function	0	29	110	1	4	1	10	0	18	0	217	74	770	0	0	0
Ungültiges Konstruktorargument in typisiertem Array.	0	0	27	0	169	3	21	0	0	0	0	0	146	35	0	0
Unknown operation "tls"	111	1056	1045	981	1026	752	7	7	0	0	0	0	0	0	0	0

select
	message,
	coalesce(sum(case when ts='20160518' then num end), 0) as `20160518`,
	coalesce(sum(case when ts='20160519' then num end), 0) as `20160519`,
	coalesce(sum(case when ts='20160520' then num end), 0) as `20160520`,
	coalesce(sum(case when ts='20160521' then num end), 0) as `20160521`,
	coalesce(sum(case when ts='20160522' then num end), 0) as `20160522`,
	coalesce(sum(case when ts='20160523' then num end), 0) as `20160523`,
	coalesce(sum(case when ts='20160524' then num end), 0) as `20160524`,
	coalesce(sum(case when ts='20160525' then num end), 0) as `20160525`,
	coalesce(sum(case when ts='20160526' then num end), 0) as `20160526`,
	coalesce(sum(case when ts='20160527' then num end), 0) as `20160527`,
	coalesce(sum(case when ts='20160528' then num end), 0) as `20160528`,
	coalesce(sum(case when ts='20160529' then num end), 0) as `20160529`,
	coalesce(sum(case when ts='20160530' then num end), 0) as `20160530`,
	coalesce(sum(case when ts='20160531' then num end), 0) as `20160531`,
	coalesce(sum(case when ts='20160601' then num end), 0) as `20160601`,
	coalesce(sum(case when ts='20160602' then num end), 0) as `20160602`
from (
	select trim(trailing '\r\n' from event_message) as message, ts, num from (
		select event_message, left(timestamp,8) as ts, count(*) as num
		from UploadWizardExceptionFlowEvent_11772722
		where timestamp > '2016' and event_message in (
			select event_message 
			from UploadWizardExceptionFlowEvent_11772722
			where timestamp > '2016'
			group by event_message
			having count(*)>100
		)
		group by event_message, left(timestamp,8)
		union
		select null, left(timestamp,8) as ts, count(*) as num
		from UploadWizardExceptionFlowEvent_11772722
		where timestamp > '2016' and event_message not in (
			select event_message 
			from UploadWizardExceptionFlowEvent_11772722
			where timestamp > '2016'
			group by event_message
			having count(*)>100
		)
		group by left(timestamp,8)
	) u
	order by ts, num, message
) v
group by message;

matmarex closed subtask T136234: Uncaught TypeError: Cannot read property 'description' of undefined as Resolved.Jun 3 2016, 4:50 PM

matmarex closed subtask T136236: Uncaught TypeError: Cannot read property 'code' of undefined as Resolved.

matmarex closed subtask T136237: Uncaught TypeError: Cannot read property 'toLowerCase' of null as Resolved.Jun 3 2016, 4:52 PM

matmarex triaged this task as Normal priority.Jun 4 2016, 5:18 PM

matmarex mentioned this in T137660: Set up Sentry-based(?) logging of client-side JS errors in VE so we can find and fix them.Jun 14 2016, 3:32 PM

message	20160519	20160520	20160521	20160522	20160523	20160524	20160525	20160526	20160527	20160528	20160529	20160530	20160531	20160601	20160602	20160603	20160604	20160605	20160606	20160607	20160608	20160609	20160610	20160611	20160612	20160613	20160614
NULL	115	81	54	50	124	85	45	107	117	34	113	82	139	90	26	55	23	39	37	32	56	112	51	37	51	33	40
Argument konstruktoru typovaného pole je neplatný.	0	0	0	0	1	54	69	0	0	0	0	39	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0
Für diesen Vorgang ist nicht genügend Speicher verfügbar.	71	54	0	63	27	43	0	1	0	0	4	97	32	0	2	0	2	2	0	0	10	1	0	1	6	0	0
NS_ERROR_NOT_AVAILABLE:	0	0	0	1	2	54	3	0	1	3	1	2	7	1010	1	0	21	6	3	4	0	2	10	6	15	1	5
Not enough storage is available to complete this operation.	48	4	4	3	8	5	12	0	5	6	2	0	0	0	5	1	14	8	0	8	2	3	10	13	5	30	18
QuotaExceededError	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	53	52	41	24	53	22
QuotaExceededError: DOM Exception 22	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	40	9	41	165	42	0
Script error.	4	18	6	18	1	7	1	3	10	1	3	1	2	2	2	1	2	1	7	21	4	1	0	0	5	14	3
TypeError: str.replace is not a function	146	17	72	49	49	5	27	122	101	204	86	70	275	1	0	0	0	0	0	0	0	0	0	0	0	0	0
TypeError: this.descriptionsDetails.getSerialized(...).descriptions[0] is undefined	9	9	7	17	9	9	18	13	8	12	12	17	31	29	8	8	20	15	3	5	4	0	0	0	0	0	0
Typed array constructor argument is invalid	120	47	0	4	0	5	10	0	0	46	7	78	0	0	0	2	33	4	0	1	5	8	2	31	0	2	6
Unbekannter Fehler.	10	17	0	16	4	10	0	1	0	0	30	31	17	0	0	0	0	1	0	0	1	0	0	10	3	0	0
Uncaught ReferenceError: clearSelection is not defined	0	0	0	0	0	0	0	1656	0	0	0	0	0	0	0	0	0	390	0	0	0	0	0	0	483	0	0
Uncaught TypeError: Cannot read property 'code' of undefined	17	17	39	29	34	22	31	64	14	48	39	77	63	47	66	46	43	97	46	39	28	0	0	0	0	0	0
Uncaught TypeError: Cannot read property 'description' of undefined	47	31	61	64	39	59	51	56	43	46	36	58	61	22	32	17	19	30	19	35	34	0	0	0	0	0	0
Uncaught TypeError: Cannot read property 'getMainText' of null	0	25	18	25	7	1	157	16	1	3	32	31	26	5	15	13	3	13	66	5	5	18	10	48	26	5	7
Uncaught TypeError: Cannot read property 'getName' of null	4	35	3	10	4	1	0	3	11	7	4	8	25	3	6	3	26	11	7	28	0	0	6	10	22	4	8
Uncaught TypeError: Cannot read property 'resolve' of undefined	1	2	4	4	1	5	5	4	3	5	7	4	6	3	3	7	2	18	3	2	14	9	7	2	9	0	1
Uncaught TypeError: Cannot read property 'toLowerCase' of null	20	1	1	0	8	23	0	16	0	11	45	17	0	1	26	6	36	12	65	0	0	3	6	2	0	0	3
Uncaught TypeError: str.replace is not a function	203	130	149	190	195	134	194	72	135	101	121	156	181	37	0	0	0	0	0	0	0	0	0	0	0	0	0
Uncaught TypeError: this.get(...).querySelectorAll is not a function	522	9	0	0	0	0	0	0	33	12	200	1146	0	0	342	0	0	60	28	0	13	0	24	0	0	0	0
Uncaught TypeError: undefined is not a function	29	110	1	4	1	10	0	18	0	217	74	770	0	0	0	0	0	0	0	0	6	0	0	0	0	0	0
Ungültiges Konstruktorargument in typisiertem Array.	0	27	0	169	3	21	0	0	0	0	0	146	35	0	0	0	0	0	0	0	28	0	0	0	0	0	0
Unknown operation "tls"	1056	1045	981	1026	752	7	7	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0

uploadwizard-stats-exceptions-byday.sql3 KBDownload

uploadwizard-stats-exceptions-byday.tsv3 KBDownload

You should be able to get rid of much of the noise by filtering on event_url. Browser extensions will either have a chrome:// or similar URL or some external domain (if the extension pulls it from the web).

We have things like "Script error" or "Out of memory" in the logs that don't really look like we'll be able to guess what causes them.

Script error means the error message was hidden for security reasons. This only happens when some cross-domain resource was involved and I don't think UW uses any, so those can be ignored.

In T136230#2380113, @Tgr wrote:

You should be able to get rid of much of the noise by filtering on event_url. Browser extensions will either have a chrome:// or similar URL or some external domain (if the extension pulls it from the web).

Ooh, yeah, that would be pretty smart. I don't see any chrome:// URLs, but there are plenty from various weird shady domains.

Filtering out everything that's not from 'https://commons.wikimedia.org':

uploadwizard-stats-exceptions-byday.sql3 KBDownload

uploadwizard-stats-exceptions-byday.tsv2 KBDownload

message	20160519	20160520	20160521	20160522	20160523	20160524	20160525	20160526	20160527	20160528	20160529	20160530	20160531	20160601	20160602	20160603	20160604	20160605	20160606	20160607	20160608	20160609	20160610	20160611	20160612	20160613	20160614
NULL	110	73	32	46	76	84	30	94	102	27	89	46	120	70	13	45	17	20	29	31	53	78	15	4	33	15	18
Argument konstruktoru typovaného pole je neplatný.	0	0	0	0	1	54	69	0	0	0	0	39	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0
Für diesen Vorgang ist nicht genügend Speicher verfügbar.	71	54	0	63	27	43	0	1	0	0	4	97	32	0	2	0	2	2	0	0	10	1	0	1	6	0	0
NS_ERROR_NOT_AVAILABLE:	0	0	0	1	2	54	3	0	1	3	1	2	7	1010	1	0	21	6	3	4	0	2	10	6	15	1	5
Not enough storage is available to complete this operation.	48	4	4	3	8	5	12	0	5	5	2	0	0	0	5	1	14	8	0	8	2	2	7	3	5	18	11
TypeError: str.replace is not a function	146	17	72	49	49	5	27	122	101	204	86	70	275	1	0	0	0	0	0	0	0	0	0	0	0	0	0
TypeError: this.descriptionsDetails.getSerialized(...).descriptions[0] is undefined	9	9	7	17	9	9	18	13	8	12	12	17	31	29	8	8	20	15	3	5	4	0	0	0	0	0	0
Typed array constructor argument is invalid	120	47	0	4	0	5	10	0	0	46	7	78	0	0	0	2	33	4	0	1	5	8	2	31	0	2	6
Unbekannter Fehler.	10	17	0	16	4	10	0	1	0	0	30	31	17	0	0	0	0	1	0	0	1	0	0	10	3	0	0
Uncaught TypeError: Cannot read property 'code' of undefined	17	17	39	29	34	22	31	64	14	48	39	77	63	47	66	46	43	97	46	39	28	0	0	0	0	0	0
Uncaught TypeError: Cannot read property 'description' of undefined	47	31	61	64	39	59	51	56	43	46	36	58	61	22	32	17	19	30	19	35	34	0	0	0	0	0	0
Uncaught TypeError: Cannot read property 'getMainText' of null	0	25	18	25	7	1	157	16	1	3	32	31	26	5	15	13	3	13	66	5	5	18	10	48	26	5	8
Uncaught TypeError: Cannot read property 'getName' of null	4	35	3	10	4	1	0	3	11	7	4	8	25	3	6	3	26	11	7	28	0	0	6	10	22	4	8
Uncaught TypeError: Cannot read property 'resolve' of undefined	1	2	4	4	1	5	5	4	3	5	7	4	6	3	3	7	2	18	3	2	14	9	7	2	9	0	4
Uncaught TypeError: Cannot read property 'toLowerCase' of null	20	1	1	0	8	23	0	16	0	11	45	17	0	1	26	6	36	12	65	0	0	3	6	2	0	0	3
Uncaught TypeError: str.replace is not a function	203	130	149	190	195	134	194	72	135	101	121	156	181	37	0	0	0	0	0	0	0	0	0	0	0	0	0
Ungültiges Konstruktorargument in typisiertem Array.	0	27	0	169	3	21	0	0	0	0	0	146	35	0	0	0	0	0	0	0	28	0	0	0	0	0	0

Note that we load our scripts (most of the time, on most browsers) by reading the source from localStorage and eval-ing it, in which case the URL will be empty. (Plus there are the magic URLs you added in 17b40ce7/f563e187.)

Almost all of the error messages with event_url='' is stuff that is very definitely not coming from our code. (And the magic URLs account for a very small number of entries and in general are mostly harmless.)

mysql:research@dbstore1002.eqiad.wmnet [log]> select event_message, count(*) as n from UploadWizardExceptionFlowEvent_11772722 where event_url='' and timestamp>'2016' group by event_message having n>5;
+---------------------------------------------------------------------------------------------------+------+
| event_message                                                                                     | n    |
+---------------------------------------------------------------------------------------------------+------+
| Die Eigenschaft "code" eines undefinierten oder Nullverweises kann nicht abgerufen werden.        |    9 |
| Die Eigenschaft "getMainText" eines undefinierten oder Nullverweises kann nicht abgerufen werden. |    6 |
| Die Eigenschaft "resolve" eines undefinierten oder Nullverweises kann nicht abgerufen werden.     |    7 |
| Die Eigenschaft "toLowerCase" eines undefinierten oder Nullverweises kann nicht abgerufen werden. |    8 |
| L’objet ne gère pas la propriété ou la méthode « replace »                                        |    9 |
| Object doesn't support property or method 'replace'                                               |   11 |
| Out of memory                                                                                     |    7 |
| Script error.                                                                                     |   81 |
| Unable to get property 'code' of undefined or null reference                                      |    8 |
| Unable to get property 'toLowerCase' of undefined or null reference                               |   13 |
| Uncaught Error: Java exception was raised during method invocation                                |   10 |
| Uncaught ReferenceError: clearOverlappingSelection is not defined                                 |   13 |
| Uncaught ReferenceError: clearSelection is not defined                                            | 2529 |
| Uncaught ReferenceError: initMultiSelection is not defined                                        |   13 |
| Uncaught TypeError: Cannot read property 'addEventListener' of null                               |    9 |
| Uncaught TypeError: Cannot read property 'style' of null                                          |    6 |
| Uncaught TypeError: Failed to execute 'removeChild' on 'Node': parameter 1 is not of type 'Node'. |   10 |
| Uncaught TypeError: this.get(...).querySelectorAll is not a function                              | 2389 |
| Uncaught TypeError: undefined is not a function                                                   | 1184 |
| uncaught exception: out of memory                                                                 |   38 |
+---------------------------------------------------------------------------------------------------+------+
20 rows in set (3.90 sec)

n<=5 yields 32 more rows, which I'm omitting for privacy/security reasons.

uploadwizard-stats-exceptions-byday.sql3 KBDownload

uploadwizard-stats-exceptions-byday.tsv2 KBDownload

matmarex added a subtask: T130610: When chunked uploading very large files, upload progress bar gets stuck with errors in the console about "too much recursion" / "call stack size exceeded" (but upload succeeds?).Jun 30 2016, 11:27 PM

matmarex reopened subtask T136237: Uncaught TypeError: Cannot read property 'toLowerCase' of null as Open.Jun 30 2016, 11:33 PM

matmarex created subtask T139129: Uncaught TypeError: Cannot read property 'getName' of null.Jun 30 2016, 11:50 PM

matmarex created subtask T139130: Uncaught TypeError: Cannot read property 'resolve' of undefined / queue[title] is undefined.

matmarex created subtask T139131: TypeError: extension is null.

matmarex created subtask T139132: Uncaught TypeError: Cannot read property 'parseDom' of undefined.

matmarex created subtask T139133: Uncaught TypeError: Cannot read property 'warnings' of undefined.Jun 30 2016, 11:52 PM

matmarex closed subtask T139129: Uncaught TypeError: Cannot read property 'getName' of null as Resolved.Jul 5 2016, 7:39 PM

matmarex closed subtask T130610: When chunked uploading very large files, upload progress bar gets stuck with errors in the console about "too much recursion" / "call stack size exceeded" (but upload succeeds?) as Resolved.Jul 5 2016, 7:43 PM

matmarex closed subtask T139133: Uncaught TypeError: Cannot read property 'warnings' of undefined as Resolved.

matmarex closed subtask T136238: Uncaught TypeError: Cannot read property 'getMainText' of null as Resolved.Jul 14 2016, 11:32 AM

matmarex closed subtask T139132: Uncaught TypeError: Cannot read property 'parseDom' of undefined as Resolved.Jul 19 2016, 4:59 PM

Commit 046cbe84a29d1e4a3473d7497415f94889ca6182 (https://gerrit.wikimedia.org/r/297120) allows us to finally filter out non-UW exceptions, as all UW code should now be served by ResourceLoader in a single separate load.php request. So if we check for event_url like '%ext.uploadWizard%', we know for sure that all of the results are actually coming from UploadWizard, and we can cease wild goose chases like T136237.

However, it will not include some legitimate entries, e.g. when the browser just reports https://commons.wikimedia.org/wiki/Special:UploadWizard as the URL. So I'll be only using this to exclude specific error messages that appear for like 'https://commons.wikimedia.org/%' but never for like '%ext.uploadWizard%', not for the counts in the chart.

matmarex closed subtask T139130: Uncaught TypeError: Cannot read property 'resolve' of undefined / queue[title] is undefined as Invalid.Jul 19 2016, 7:38 PM

Status update:

uploadwizard-stats-exceptions-byday.sql4 KBDownload

uploadwizard-stats-exceptions-byday.tsv4 KBDownload

This chart excludes errors related to T136237 and T139130 (which I'm pretty sure are not coming from our code, and I can't identify their source).

Most of the remaining logs are from T136235 (Internet-Explorer-specific) and T136831 (Firefox-specific). Both have patches pending.

I think we're pretty close to the goal of <50/day. As long as we don't introduce new ones ;)

matmarex closed subtask T136831: NS_ERROR_NOT_AVAILABLE as Resolved.Jul 26 2016, 10:17 AM

matmarex closed subtask T136235: Typed array constructor argument is invalid as Resolved.

matmarex created subtask T141529: TypeError: undefined is not an object (evaluating 'uploadObj.ui.div').Jul 28 2016, 2:59 PM

matmarex closed subtask T141529: TypeError: undefined is not an object (evaluating 'uploadObj.ui.div') as Resolved.Aug 3 2016, 6:26 PM

matmarex closed subtask T136239: Not enough storage is available to complete this operation as Resolved.Aug 7 2016, 1:59 PM

All subtasks are resolved and I'm pretty sure we're now where I wanted us to be. I'll keep this open for a week or two for new data to come in, make some more charts, and close if it all looks good.

Status update:

uploadwizard-stats-exceptions-byday.sql5 KBDownload

uploadwizard-stats-exceptions-byday.tsv3 KBDownload

Spikes on 2016-07-19, 2016-07-24 and 2016-07-26 are T136235. Spike on 2016-07-28 is T141529. Spikes on 2016-08-12, 2016-08-16 and 2016-08-17 are a return of T136831, I'm reopening that one. The spike on 2016-08-17 also has some other weird stuff that I haven't investigated yet.

(I did some tweaking of the spreadsheets for the chart and the SQL query, to make them more correct, more automatic and prettier, so they differ a bit from previous ones.)

matmarex reopened subtask T136831: NS_ERROR_NOT_AVAILABLE as Open.Aug 23 2016, 12:27 PM

matmarex reopened subtask T139130: Uncaught TypeError: Cannot read property 'resolve' of undefined / queue[title] is undefined as Open.Aug 23 2016, 1:37 PM

matmarex closed subtask T139130: Uncaught TypeError: Cannot read property 'resolve' of undefined / queue[title] is undefined as Resolved.Aug 30 2016, 2:36 PM

matmarex created subtask T145341: Unspecified error..Sep 11 2016, 9:07 PM

Status update:

uploadwizard-stats-exceptions-byday.sql5 KBDownload

uploadwizard-stats-exceptions-byday.tsv3 KBDownload

Spike on 2016-08-16 is T136831, as I said before. Spike on 2016-08-17 is actually three small spikes, T136831 and two instances of T145341, with a couple different errors seen by two users (in Spanish and German). Spike on 2016-08-23 is T136831 again and Error: Permission denied to access property "toString", which I think is probably coming from a browser extension. Spikes on 2016-08-30 and 2016-09-04 are T145341. Huge spikes on 2016-09-05–2016-09-11 are all T145341 too.

So… it's basically all T136831 and T145341, both of which are harmless but noisy. I think we're nearly done here, let's just eliminate them.

matmarex closed subtask T136831: NS_ERROR_NOT_AVAILABLE as Resolved.Sep 13 2016, 7:42 PM

matmarex closed subtask T145341: Unspecified error. as Resolved.

Status update:

uploadwizard-stats-exceptions-byday.sql6 KBDownload

uploadwizard-stats-exceptions-byday.tsv3 KBDownload

During the last two weeks, every day has been below the stated goal of 50 uncaught exceptions per day, so I'm going to close this, yay!

There is still a slow trickle of exceptions that might be legitimately caused by bugs in UploadWizard (as opposed to browser extensions and user scripts and non-UploadWizard deployed code and user's browsers running out of memory), and I'll keep running this query every week or so and trying to sift through the noise. But we're in a pretty good state right now.

matmarex awarded a token.Sep 30 2016, 9:21 PM

matmarex merged a task: T95527: Analyze UploadWizard funnel logs.Nov 2 2016, 9:07 AM

matmarex added a subscriber: gerritbot.

matmarex mentioned this in T94161: Fix failed UploadWizard browsertests Jenkins job .Nov 4 2016, 6:24 PM

matmarex mentioned this in T156694: Create public dashboards for UploadWizard's EventLogging data (exceptions and API errors/warnings).Jan 30 2017, 10:53 PM

matmarex mentioned this in T167699: [EPIC] Enable JS error reporting in the mobile website.Sep 5 2017, 11:51 PM

Get UploadWizard's uncaught exceptions on Commons to fewer than 50/dayClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day
Closed, ResolvedPublic
Actions

Related Objects
Search...