Page MenuHomePhabricator

All audio players have 120px width, regardless of provided options
Closed, ResolvedPublic

Description

All audio players have 120px width, regardless of provided options. This is a regression from T137632.

Details

Related Gerrit Patches:
mediawiki/extensions/TimedMediaHandler : masterRevert "TimedMediaHandler: Don't try to calculate width and height for audio files"
mediawiki/extensions/TimedMediaHandler : masterUnbreak audio thumbnail width

Event Timeline

matmarex created this task.Jul 19 2016, 2:30 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 19 2016, 2:30 PM

Change 299616 had a related patch set uploaded (by Bartosz Dziewoński):
Unbreak audio thumbnail width

https://gerrit.wikimedia.org/r/299616

Change 298872 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "TimedMediaHandler: Don't try to calculate width and height for audio files"

https://gerrit.wikimedia.org/r/298872

Dear Release-Engineering-Team, one of the patches provided above should be merged before today's branch cut (T139212). Please decide which one. I prefer the fix, but the revert would also be fine. There doesn't seem to be anyone maintaining that extension I could ask for timely review.

Wikitext to reproduce the problem:

[[File:Example.ogg|500px|thumb]]
[[File:Example.ogg|thumb]]
[[File:Example.ogg|120px|thumb]]
[[File:Example.ogg|15px|thumb]]

[[File:Example.ogg|500px]]
[[File:Example.ogg]]
[[File:Example.ogg|120px]]
[[File:Example.ogg|15px]]

The width should be respected in all cases (using the thumbnail size from user's preferences if none is provided), it result in a 120px player in all cases now.

Change 299616 merged by jenkins-bot:
Unbreak audio thumbnail width

https://gerrit.wikimedia.org/r/299616

greg added a subscriber: greg.Jul 19 2016, 5:36 PM

Change 299616 merged by jenkins-bot:
Unbreak audio thumbnail width
https://gerrit.wikimedia.org/r/299616

@matmarex are we good if we branch now?

matmarex closed this task as Resolved.Jul 19 2016, 6:59 PM
matmarex removed a project: Patch-For-Review.

Yeah, thanks for the ping!

Change 298872 abandoned by Bartosz Dziewoński:
Revert "TimedMediaHandler: Don't try to calculate width and height for audio files"

Reason:
I submitted a fix instead: https://gerrit.wikimedia.org/r/299616. Hopefully this is no longer needed.

https://gerrit.wikimedia.org/r/298872