All audio players have 120px width, regardless of provided options. This is a regression from T137632.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • demon | T139212 MW-1.28.0-wmf.11 deployment blockers | |||
| Resolved | matmarex | T137632 misleading error about thumbnails for OGG audio files | |||
| Resolved | matmarex | T140763 All audio players have 120px width, regardless of provided options |
Event Timeline
Comment Actions
Change 299616 had a related patch set uploaded (by Bartosz Dziewoński):
Unbreak audio thumbnail width
Comment Actions
Change 298872 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "TimedMediaHandler: Don't try to calculate width and height for audio files"
Comment Actions
Dear Release-Engineering-Team, one of the patches provided above should be merged before today's branch cut (T139212). Please decide which one. I prefer the fix, but the revert would also be fine. There doesn't seem to be anyone maintaining that extension I could ask for timely review.
Comment Actions
Wikitext to reproduce the problem:
[[File:Example.ogg|500px|thumb]] [[File:Example.ogg|thumb]] [[File:Example.ogg|120px|thumb]] [[File:Example.ogg|15px|thumb]] [[File:Example.ogg|500px]] [[File:Example.ogg]] [[File:Example.ogg|120px]] [[File:Example.ogg|15px]]
The width should be respected in all cases (using the thumbnail size from user's preferences if none is provided), it result in a 120px player in all cases now.
Comment Actions
Change 298872 abandoned by Bartosz Dziewoński:
Revert "TimedMediaHandler: Don't try to calculate width and height for audio files"
Reason:
I submitted a fix instead: https://gerrit.wikimedia.org/r/299616. Hopefully this is no longer needed.