Page MenuHomePhabricator
Create Task
Maniphest T141188

Link Item ID in wikibase-item-summary-wbmergeitems-from, wikibase-item-summary-wbmergeitems-to and wikibase-item-summary-wbcreateredirect messages
Open, LowestPublic
Actions

Description

Example: https://www.wikidata.org/w/index.php?title=Q24783333&curid=26746300&diff=358529705&oldid=358529702
Reported at https://www.wikidata.org/w/index.php?title=Wikidata:Contact_the_development_team&oldid=359118161#Links_in_redirect-related_edit_comments

Details

SubjectRepoBranchLines +/-
Revert "Link entity ids in merge and redirect summaries"mediawiki/extensions/Wikibasemaster+3 -3
Link entity ids in merge and redirect summariesmediawiki/extensions/Wikibasemaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Bugreporter created this task.Jul 23 2016, 6:14 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJul 23 2016, 6:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sjoerddebruin awarded a token.Jul 23 2016, 6:29 PM
Bugreporter renamed this task from Link Item ID in wikibase-item-summary-wbmergeitems-to and wikibase-item-summary-wbcreateredirect message to Link Item ID in wikibase-item-summary-wbmergeitems-from, wikibase-item-summary-wbmergeitems-to and wikibase-item-summary-wbcreateredirect message.Jul 23 2016, 6:30 PM
Bugreporter renamed this task from Link Item ID in wikibase-item-summary-wbmergeitems-from, wikibase-item-summary-wbmergeitems-to and wikibase-item-summary-wbcreateredirect message to Link Item ID in wikibase-item-summary-wbmergeitems-from, wikibase-item-summary-wbmergeitems-to and wikibase-item-summary-wbcreateredirect messages.
Thryduulf subscribed.Jul 23 2016, 10:23 PM
matej_suchanek added subscribers: Ricordisamoa, matej_suchanek.Jul 24 2016, 9:13 AM

A patch for this already exists https://gerrit.wikimedia.org/r/#/c/240704/ (T69281) but it seems to have problems

Laddo subscribed.Jul 27 2016, 11:08 AM
gerritbot subscribed.Feb 8 2018, 12:13 PM

Change 409004 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/Wikibase@master] Link entity ids in merge and redirect summaries

https://gerrit.wikimedia.org/r/409004

gerritbot added a project: Patch-For-Review.Feb 8 2018, 12:13 PM
matej_suchanek claimed this task.Feb 8 2018, 12:13 PM
thiemowmde closed this task as Resolved.Feb 8 2018, 1:53 PM
thiemowmde triaged this task as Lowest priority.
thiemowmde edited projects, added patch-welcome, Wikidata-Sprint-2018-01-31; removed Patch-For-Review.
thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde moved this task from Backlog to Done on the Wikidata-Sprint-2018-01-31 board.
gerritbot added a comment.Feb 8 2018, 1:56 PM

Change 409004 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Link entity ids in merge and redirect summaries

https://gerrit.wikimedia.org/r/409004

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 8 2018, 2:00 PM
gerritbot added a project: Patch-For-Review.Feb 9 2018, 6:41 PM
matej_suchanek reopened this task as Open.EditedFeb 9 2018, 6:43 PM

This doesn't work because of T182800. Proposed to revert.

obrazek.png (122×878 px, 16 KB)

matej_suchanek added a comment.Feb 9 2018, 7:20 PM

Possible solution could be substituting (optional) parameter types to summary (with fallback to plain text for legacy summaries).

  • before: /* wbcreateredirect:0||Q24783333|Q7128407 */
  • after: /* wbcreateredirect:0||entity=Q24783333|entity=Q7128407 */

This would slightly increase the amount of data in the database but it could also help with other features, eg. T85560: [Task] Show human readable language names in edit summaries:

  • before: /* wbsetlabel-set:1|cs */
  • after: /* wbsetlabel-set:1|lang=cs */
thiemowmde removed projects: Patch-For-Review, Wikidata-Sprint-2018-01-31.Feb 9 2018, 8:21 PM
thiemowmde removed matej_suchanek as the assignee of this task.Feb 13 2018, 1:28 PM
thiemowmde moved this task from in progress to needs discussion or investigation on the Wikidata board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits