Page MenuHomePhabricator
Create Task
Maniphest T141257

flake8 v3 is incompatible with many v2 plugins and is not stable
Closed, ResolvedPublic
Actions

Description

One of many problems:

Flake8 failed to load plugin "T80" due to No module named engine

12:22:18 flake8 runtests: PYTHONHASHSEED='1675780105'
12:22:18 flake8 runtests: commands[0] | flake8 --version
12:22:18   /home/jenkins/workspace/tox-jessie$ /home/jenkins/workspace/tox-jessie/.tox/flake8/bin/flake8 --version 
12:22:18 Traceback (most recent call last):
12:22:18   File ".tox/flake8/bin/flake8", line 11, in <module>
12:22:18     sys.exit(main())
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/main/cli.py", line 16, in main
12:22:18     app.run(argv)
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/main/application.py", line 299, in run
12:22:18     self._run(argv)
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/main/application.py", line 285, in _run
12:22:18     self.initialize(argv)
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/main/application.py", line 275, in initialize
12:22:18     self.find_plugins()
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/main/application.py", line 143, in find_plugins
12:22:18     self.check_plugins.load_plugins()
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/plugins/manager.py", line 369, in load_plugins
12:22:18     plugins = list(self.manager.map(load_plugin))
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/plugins/manager.py", line 261, in map
12:22:18     yield func(self.plugins[name], *args, **kwargs)
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/plugins/manager.py", line 367, in load_plugin
12:22:18     return plugin.load_plugin()
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/plugins/manager.py", line 167, in load_plugin
12:22:18     raise failed_to_load
12:22:18 flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "T80" due to No module named engine.
12:22:18 ERROR: InvocationError: '/home/jenkins/workspace/tox-jessie/.tox/flake8/bin/flake8 --version'
12:22:18 flake8 runtests: commands[1] | flake8 --doctests
12:22:18   /home/jenkins/workspace/tox-jessie$ /home/jenkins/workspace/tox-jessie/.tox/flake8/bin/flake8 --doctests 
12:22:18 Traceback (most recent call last):
12:22:18   File ".tox/flake8/bin/flake8", line 11, in <module>
12:22:18     sys.exit(main())
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/main/cli.py", line 16, in main
12:22:18     app.run(argv)
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/main/application.py", line 299, in run
12:22:18     self._run(argv)
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/main/application.py", line 285, in _run
12:22:18     self.initialize(argv)
12:22:18   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/main/application.py", line 275, in initialize
12:22:18     self.find_plugins()
12:22:19   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/main/application.py", line 143, in find_plugins
12:22:19     self.check_plugins.load_plugins()
12:22:19   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/plugins/manager.py", line 369, in load_plugins
12:22:19     plugins = list(self.manager.map(load_plugin))
12:22:19   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/plugins/manager.py", line 261, in map
12:22:19     yield func(self.plugins[name], *args, **kwargs)
12:22:19   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/plugins/manager.py", line 367, in load_plugin
12:22:19     return plugin.load_plugin()
12:22:19   File "/home/jenkins/workspace/tox-jessie/.tox/flake8/local/lib/python2.7/site-packages/flake8/plugins/manager.py", line 167, in load_plugin
12:22:19     raise failed_to_load
12:22:19 flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "T80" due to No module named engine.
12:22:19 ERROR: InvocationError: '/home/jenkins/workspace/tox-jessie/.tox/flake8/bin/flake8 --doctests'

Details

SubjectRepoBranchLines +/-
flake8 v3 is not stablepywikibot/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Xqt created this task.Jul 25 2016, 12:28 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJul 25 2016, 12:28 PM
Xqt triaged this task as Unbreak Now! priority.Jul 25 2016, 12:28 PM
Restricted Application added subscribers: Luke081515, TerraCodes. · View Herald TranscriptJul 25 2016, 12:28 PM
jayvdb added a comment.Jul 26 2016, 3:17 AM

flake8 v3 is a rewrite, and not backwards compatible, and is not yet stable. https://gitlab.com/pycqa/flake8/issues/149 is a list of broken plugins.

jayvdb renamed this task from Flake8 failed to load plugin "T80" due to No module named engine to flake8 v3 is incompatible with many v2 plugins and is not stable.Jul 26 2016, 3:18 AM
jayvdb updated the task description. (Show Details)
gerritbot subscribed.Jul 26 2016, 3:19 AM

Change 301057 had a related patch set uploaded (by John Vandenberg):
flake8 v3 is not stable

https://gerrit.wikimedia.org/r/301057

jayvdb added a comment.Jul 26 2016, 4:24 AM

And flake8 v3 is not compatible with Python 2.6

$ git grep OrderedDict
src/flake8/utils.py:        parameters = collections.OrderedDict([
src/flake8/utils.py:        parameters = collections.OrderedDict([
jayvdb added a parent task: T72987: Python 2.6 issues (tracking).Jul 26 2016, 4:25 AM
gerritbot added a comment.Jul 26 2016, 4:46 AM

Change 301057 merged by jenkins-bot:
flake8 v3 is not stable

https://gerrit.wikimedia.org/r/301057

Xqt closed this task as Resolved.Jul 26 2016, 4:57 AM
Xqt assigned this task to jayvdb.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits