Right now [[https://www.mediawiki.org/wiki/Extension:Wikibase_Client/Lua#mw.wikibase.entity:getLabel|mw.wikibase.entity:getLabel]] and [[https://www.mediawiki.org/wiki/Extension:Wikibase_Client/Lua#mw.wikibase.entity:getDescription|mw.wikibase.entity:getDescription]] default to the wiki's content language, even if allowDataAccessInUserLanguage is set to true. They should probably use the user's language in that case.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | None | T112073 Lua in Wikibase (tracking) | |||
| Resolved | hoo | T143277 mw.wikibase.entity:getLabel/:getDescription should obey allowDataAccessInUserLanguage |
Event Timeline
Comment Actions
Sounds reasonable. But we should make sure that we don't split the parser cache on Wikipedia pages. IIRC allowDataAccessInUserLanguage is only enabled on Commons. Is that right?
Comment Actions
If we're one a multilingual wiki (commons, wikidata, meta and test variants), the cache is already split by then (as mw.wikibase.getEntity* splits it), so we can safely use the user's language.
If we're not on a multilingual wiki, the behavior wont change at all.
Comment Actions
Change 313926 had a related patch set uploaded (by Hoo man):
Make mw.wikibase.entity:getLabel/:getDescription obey allowDataAccessInUserLanguage
Comment Actions
Change 313926 merged by jenkins-bot:
Make mw.wikibase.entity:getLabel/:getDescription obey allowDataAccessInUserLanguage