Page MenuHomePhabricator
Create Task
Maniphest T143577

Fix tab behaviour when using two edit tabs with NWE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

  • Clicking 'edit' from NWE does nothing
  • Clicking 'edit source' from read mode highlights the wrong tab (or loading veaction=editsource)
  • Clicking 'edit source' from read mode gives you the VE URL, so reloading takes you back to VE

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+9 -1Switch from NWE to VE using 'Edit' tab
mediawiki/extensions/VisualEditormaster+75 -39Update tab and history state when switching between NWE & VE
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Aug 22 2016, 5:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2016, 5:43 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Aug 22 2016, 5:45 PM
Esanders removed Esanders as the assignee of this task.Aug 22 2016, 5:46 PM
Esanders renamed this task from When using two edit tabs, clicking 'edit' from NWE does nothing to Fix tab behaviour when using two edit tabs with NWE.Aug 22 2016, 6:03 PM
Esanders updated the task description. (Show Details)
Esanders added a subscriber: Krenair.
Esanders edited parent tasks, added: T141149: Provide a Beta Feature of a modern wikitext editor integrated into the visual editor; removed: T104479: Provide a modern wikitext editor .Aug 22 2016, 6:07 PM
Esanders edited parent tasks, added: T142643: In the new wikitext editor, be able to smoothly toggle between editors; removed: T141149: Provide a Beta Feature of a modern wikitext editor integrated into the visual editor.
Krenair edited subscribers, added: • AlexMonk-WMF; removed: Krenair.Aug 22 2016, 10:34 PM
Esanders claimed this task.Aug 25 2016, 8:38 PM
gerritbot added a subscriber: gerritbot.Aug 25 2016, 9:03 PM

Change 306798 had a related patch set uploaded (by Esanders):
Update tab and history state when switching between NWE & VE

https://gerrit.wikimedia.org/r/306798

gerritbot added a project: Patch-For-Review.Aug 25 2016, 9:03 PM
Jdforrester-WMF set the point value for this task to 1.Aug 31 2016, 7:17 PM
gerritbot added a comment.Sep 2 2016, 8:43 PM

Change 306798 merged by jenkins-bot:
Update tab and history state when switching between NWE & VE

https://gerrit.wikimedia.org/r/306798

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)).Sep 2 2016, 9:00 PM
Jdforrester-WMF closed this task as Resolved.Sep 2 2016, 9:39 PM
gerritbot added a comment.Sep 7 2016, 12:04 AM

Change 308907 had a related patch set uploaded (by Esanders):
Switch from NWE to VE using 'Edit' tab

https://gerrit.wikimedia.org/r/308907

gerritbot added a comment.Sep 7 2016, 1:51 AM

Change 308907 merged by jenkins-bot:
Switch from NWE to VE using 'Edit' tab

https://gerrit.wikimedia.org/r/308907

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Sep 7 2016, 2:00 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL