On wikis where uploads are fully disabled, Special:ListGroupRights shouldn't show any upload rights on any user group. Instead of doing that wiki by wiki, we can create a disableduploads.dblist and add it to groupOverrides just as commonsuploads does. I'll atempt to achieve this.
Description
Description
Details
Details
Customize query in gerrit
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 306443 had a related patch set uploaded (by MarcoAurelio):
Remove upload rights on wikis where local uploads are disabled.
Comment Actions
I'm ok with this proposal. It would be even nicer if MediaWiki handled this, by "unregistering" the upload-related permissions when upload is disabled: this way, we would also hide any globally-assigned permission.
Comment Actions
Change 306443 abandoned by MarcoAurelio:
Remove upload rights on wikis where local uploads are disabled
Comment Actions
Change 306443 restored by MarcoAurelio:
Remove upload rights on wikis where local uploads are disabled
Comment Actions
Change 306443 abandoned by MarcoAurelio:
Remove upload rights on wikis where local uploads are disabled
Reason:
I'll start over from scratch.
Comment Actions
Change 405421 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[operations/mediawiki-config@master] Remove upload rights on wikis where local uploads are disabled
Comment Actions
@hashar I can't understand https://integration.wikimedia.org/ci/job/operations-mw-config-composer-hhvm-jessie/10239/console -- could you please explain to me why it is failing? Thanks.
Comment Actions
Change 405421 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove upload rights on wikis where local uploads are disabled
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-01-29T19:39:20Z] <niharika29@tin> Synchronized wmf-config/InitialiseSettings.php: Remove upload rights on wikis where local uploads are disabled T143789 (duration: 00m 56s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-01-29T19:40:24Z] <niharika29@tin> Synchronized wmf-config/CommonSettings.php: Remove upload rights on wikis where local uploads are disabled T143789 (duration: 00m 56s)
Comment Actions
Reverted. The patch above was reverted as it was not working as expected, in spite of working well in mwdebug1002. Specifically I observed the following failures:
- the upload rights (upload et al.) were still avalaible at Special:ListGroupRights.
- wikis with uploads disabled started suddenly to be able to do local uploads
Not sure if this has to be with any duplicates at commonsuploads.dblist or anything else. I'd like this to be reviewed before trying again.
Comment Actions
It is related with T185898 .
if you want to inherit permissions from tag sets, those should be have '+' prefix before dbname in 'groupOverrides' @ "InitialiseSettings.php".
Comment Actions
The previous comments don't explain who or what (task?) exactly this task is stalled on ("If a report is waiting for further input (e.g. from its reporter or a third party) and can currently not be acted on"). Hence resetting task status, as tasks should not be stalled (and then potentially forgotten) for years for unclear reasons.
Comment Actions
Change 790403 had a related patch set uploaded (by Stang; author: Stang):
[operations/mediawiki-config@master] Remove upload rights on wikis where local uploads are disabled
Comment Actions
Change 790403 abandoned by Stang:
[operations/mediawiki-config@master] Remove upload rights on wikis where local uploads are disabled
Reason:
current db structure changed a lot