Page MenuHomePhabricator
Create Task
Maniphest T144007

Wikipedia.org Portal: ceb.wp language link is on two lines
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

It looks like the language link for ceb.wp is actually breaking across columns - can we get this to display on one line?

cep.wp lang link.png (80×342 px, 4 KB)

Details

ProjectBranchLines +/-Subject
wikimedia/portalsmaster+3 -0T144007-preventing languages from spanning columns
Customize query in gerrit

Event Timeline

debt created this task.Aug 26 2016, 2:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2016, 2:31 PM
debt renamed this task from Wikipedia.org Portal: cep.wp language link is on two lines to Wikipedia.org Portal: ceb.wp language link is on two lines.Aug 26 2016, 2:31 PM
debt triaged this task as Medium priority.
debt updated the task description. (Show Details)
Trizek-WMF added a subscriber: Trizek-WMF.Aug 26 2016, 3:26 PM

There is also a problem with Norsk. But It depend on the browser you use.

Jdrewniak claimed this task.Aug 26 2016, 4:12 PM
Aklapper added a project: Wikimedia-Portals.Aug 26 2016, 4:14 PM
debt added a comment.Aug 26 2016, 8:01 PM

thanks, @Trizek-WMF - I've added the Norsk screen capture here.

norsk_lang_link_breaking.png (882×416 px, 146 KB)

Jdrewniak added a comment.Aug 30 2016, 6:57 PM

This is a relatively easy fix. There is a CSS property that limits breaking content across columns:
https://css-tricks.com/almanac/properties/b/break-inside/

Jdrewniak set the point value for this task to 2.Aug 30 2016, 6:57 PM
debt moved this task from Backlog to What's Next on the Discovery-Portal-Sprint board.Sep 6 2016, 5:52 PM
Jdrewniak moved this task from What's Next to In Progress on the Discovery-Portal-Sprint board.Sep 29 2016, 8:58 AM
gerritbot added a subscriber: gerritbot.Sep 29 2016, 9:11 AM

Change 313376 had a related patch set uploaded (by Jdrewniak):
T144007-preventing languages from spanning columns

https://gerrit.wikimedia.org/r/313376

gerritbot added a project: Patch-For-Review.Sep 29 2016, 9:11 AM
Jdrewniak moved this task from In Progress to Needs code review on the Discovery-Portal-Sprint board.Sep 29 2016, 9:11 AM
gerritbot added a comment.Oct 7 2016, 5:54 PM

Change 313376 merged by jenkins-bot:
T144007-preventing languages from spanning columns

https://gerrit.wikimedia.org/r/313376

debt moved this task from Needs code review to Done on the Discovery-Portal-Sprint board.Oct 11 2016, 4:21 PM
debt added a comment.Oct 11 2016, 4:34 PM

This was released into production on Oct 11, 2016 during morning SWAT.

debt closed this task as Resolved.Oct 11 2016, 8:51 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL