Page MenuHomePhabricator
Create Task
Maniphest T144391

Revision Slider re-adds content as a wrong node
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

When user chooses some revision in the slider, and the diff is reloaded then div#mw-content-text gets added as a child of "original div#mw-content-text instead of replacing it.

Details

SubjectRepoBranchLines +/-
Don't nest mw-content-text element when reloading diffmediawiki/extensions/RevisionSlidermaster+6 -2
Do not nest mw-content-text element when reloading a diffmediawiki/extensions/RevisionSliderwmf/1.28.0-wmf.18+2 -2
Do not nest mw-content-text element when reloading a diffmediawiki/extensions/RevisionSlidermaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

WMDE-leszek created this task.Aug 31 2016, 1:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2016, 1:59 PM
Addshore moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Sep 2 2016, 7:32 AM
gerritbot subscribed.Sep 6 2016, 12:50 PM

Change 308720 had a related patch set uploaded (by WMDE-leszek):
Do not nest mw-content-text element when reloading a diff

https://gerrit.wikimedia.org/r/308720

gerritbot added a project: Patch-For-Review.Sep 6 2016, 12:50 PM
WMDE-leszek claimed this task.Sep 6 2016, 12:53 PM
WMDE-leszek moved this task from Proposed to Review on the TCB-Team-Sprint-2016-08-29 board.
WMDE-leszek mentioned this in rERSLbfd7ef2fdd75: Do not nest mw-content-text element when reloading a diff.Sep 6 2016, 12:54 PM
WMDE-leszek mentioned this in rERSLa6c5c5a81c45: Do not nest mw-content-text element when reloading a diff.Sep 6 2016, 4:02 PM
gerritbot added a comment.Sep 6 2016, 4:42 PM

Change 308720 merged by jenkins-bot:
Do not nest mw-content-text element when reloading a diff

https://gerrit.wikimedia.org/r/308720

gerritbot added a comment.Sep 6 2016, 4:46 PM

Change 308767 had a related patch set uploaded (by Addshore):
Do not nest mw-content-text element when reloading a diff

https://gerrit.wikimedia.org/r/308767

gerritbot added a comment.Sep 6 2016, 4:50 PM

Change 308767 merged by jenkins-bot:
Do not nest mw-content-text element when reloading a diff

https://gerrit.wikimedia.org/r/308767

Addshore mentioned this in rERSL2b987c414a0e: Do not nest mw-content-text element when reloading a diff.Sep 6 2016, 4:51 PM
ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)).Sep 6 2016, 5:00 PM
Addshore subscribed.Sep 7 2016, 7:17 AM

Changes reverted in https://gerrit.wikimedia.org/r/#/c/308942 and https://gerrit.wikimedia.org/r/#/c/308943 as they cause some odd things to happen.

WMDE-leszek removed WMDE-leszek as the assignee of this task.Sep 8 2016, 7:36 AM
WMDE-leszek moved this task from Review to Backlog on the TCB-Team-Sprint-2016-08-29 board.
WMDE-leszek moved this task from Backlog to Review on the TCB-Team-Sprint-2016-08-29 board.Sep 8 2016, 8:59 AM
Addshore removed projects: MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)), MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), Patch-For-Review.Sep 12 2016, 9:45 AM
Addshore moved this task from Incoming to Backlog on the Revision-Slider board.Sep 13 2016, 2:55 PM
Lea_WMDE added a project: WMDE-QWERTY-Team-Experimental-Sprint.Sep 22 2016, 1:37 PM
Tobi_WMDE_SW added a project: WMDE-TechWish.Oct 24 2016, 8:13 AM
Addshore moved this task from Proposed to Todo on the WMDE-TechWish board.Oct 24 2016, 8:15 AM
Addshore claimed this task.Oct 24 2016, 8:29 AM
Addshore moved this task from Todo to Sprint ready on the WMDE-TechWish board.
Addshore added a project: User-Addshore.
Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.
gerritbot added a comment.Oct 24 2016, 9:08 AM

Change 317472 had a related patch set uploaded (by Addshore):
Don't nest mw-content-text element when reloading diff

https://gerrit.wikimedia.org/r/317472

gerritbot added a project: Patch-For-Review.Oct 24 2016, 9:08 AM
Addshore moved this task from Sprint ready to Currently in sprint on the WMDE-TechWish board.Oct 24 2016, 9:08 AM
Addshore moved this task from Back Burner 🏛️ to Active 🚁 on the User-Addshore board.
Addshore mentioned this in rERSL1e1c2f594334: Don't nest mw-content-text element when reloading diff.Oct 24 2016, 9:09 AM
gerritbot added a comment.Oct 24 2016, 9:22 AM

Change 317472 merged by jenkins-bot:
Don't nest mw-content-text element when reloading diff

https://gerrit.wikimedia.org/r/317472

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 24 2016, 10:00 AM
Addshore closed this task as Resolved.Oct 24 2016, 2:01 PM
Addshore moved this task from Currently in sprint to Done on the WMDE-TechWish board.
Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Oct 25 2016, 2:23 PM
Tobi_WMDE_SW moved this task from Backlog to Done on the Revision-Slider board.Oct 28 2016, 2:00 PM
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 12:02 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL