Page MenuHomePhabricator
Create Task
Maniphest T145677

Adminstats is showing non-admin users too
Closed, ResolvedPublic
Actions

Description

Adminstats needs an adjustment:
After a core-change, you create a delete-log entry, if you overwrite a redirect with only 1 revision, before that change not, even as normal user. for example this user is shown now at adminstats: https://de.wikipedia.org/w/index.php?title=Spezial%3ALogbuch&type=delete&user=Minos&page=&year=&month=-1&tagfilter=&hide_thanks_log=1&hide_patrol_log=1&hide_tag_log=1&hide_review_log=1&uselang=en, he never was a sysop

gelöscht, um Platz für die Verschiebung von „Dimini-Kultur“ zu machen => deleted page for move

At enwp, these pages get deleted with "G6: Deleted to make way for move"

Related Objects

Event Timeline

Luke081515 created this task.Sep 14 2016, 7:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2016, 7:47 PM
Luke081515 updated the task description. (Show Details)Sep 14 2016, 7:47 PM
Matthewrbowker triaged this task as Medium priority.Sep 14 2016, 7:55 PM
Troubled.asset subscribed.Sep 14 2016, 7:59 PM
FriedhelmW renamed this task from Administats is showing normal users too to Adminstats is showing non-admin users too.Sep 14 2016, 8:07 PM
FriedhelmW subscribed.
doctaxon subscribed.Sep 14 2016, 10:17 PM
doctaxon added a comment.Sep 14 2016, 10:24 PM

But it's right: the user deleted the redirect page anyway, if sysop or not, it has to be logged in the deletion log.

Where is the bug? I suppose, it works fine.

Matthewrbowker added a comment.Sep 14 2016, 10:56 PM
In T145677#2638769, @doctaxon wrote:

Where is the bug? I suppose, it works fine.

My understanding of the specific request was not to remove it, just have the page display differently

PerfektesChaos subscribed.Sep 15 2016, 1:14 PM

Sounds like a different message text is desired, kinda automatic deletion for moved page ... to distinguish sysop rights from terrestric users.

doctaxon added a comment.EditedSep 15 2016, 1:34 PM

Oh, I confused the Logbook with "AdminStats", sorry!

No, it's right, in AdminStats (Xtools) only sysops should be stated.

FriedhelmW added a comment.Sep 15 2016, 2:05 PM
In T145677#2638769, @doctaxon wrote:

Where is the bug? I suppose, it works fine.

The bug is that since August 25 adminstats shows deletions by non-admin users. It should only show admin statistics.

Matthewrbowker added a comment.Oct 11 2016, 6:02 PM

Can someone provide a link that I can use to reproduce the issue? I'm going to work on fixing it this weekend.

FriedhelmW added a comment.Oct 11 2016, 6:08 PM

@Matthewrbowker: Link: https://de.wikipedia.org/w/index.php?title=Spezial%3ALogbuch&type=delete&user=Berihert&page=&year=&month=-1&tagfilter=&subtype=delete

Matthewrbowker added a comment.Oct 11 2016, 6:12 PM

Cool, thank you much. That put me on the right path.

https://tools.wmflabs.org/xtools/adminstats/?project=de.wikipedia.org&begin=2016-07-03&end=

Matthewrbowker closed this task as Resolved.Nov 23 2016, 1:06 AM
Matthewrbowker added a subscriber: MusikAnimal.

I have fixed the page. While it does not filter non-admins, it does now show which users are admins and which aren't.

@MusikAnimal Just so you know, the proper fix is a string replace from http:// to https:// on WebTool::gethttp . I guess the API doesn't serve http only requests anymore.

Stang awarded a token.Dec 2 2016, 3:03 PM
• Samwalton9-WMF mentioned this in T154408: Adminstats isn't labelling administrators properly.Jan 2 2017, 1:19 AM
MusikAnimal moved this task from Backlog to Complete on the XTools board.Jul 23 2017, 7:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL