Page MenuHomePhabricator

Add Create permission to Protectedpages
Closed, DeclinedPublic

Description

In [[Special:Protectedpages]], in the Permission: combo box, there are currently only "Edit" and "Move" selections. Since the "Create" permission (for protecting inexistent pages) has recently been added, it should be there as well.


Version: 1.11.x
Severity: enhancement
URL: http://en.wikipedia.org/wiki/Special:Protectedpages

Details

Reference
bz12583

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:04 PM
bzimport set Reference to bz12583.
bzimport added a subscriber: Unknown Object (MLST).

This is quite tricky to do, because edit/move protections are in a separate table from create protections. As a consequence, implementing limits is very hard if not impossible. Maybe a separate special page (e.g. [[Special:Noncreateablepages]]) would be better.

Roan, I think [[Special:Protectedtitles]] already does it. Anyways, I almost created a patch which would do what is requested here (which means, by applying that patch, we wouldn't need Protectedtitles anymore, and it would practically be merged to Protectedpages). I couldn't figure a few minor bugs so I left it, and (damn) forgot to save my changes (just reverted it!) Now that I look back, I think it is better to first make sure we really want to merge the two special pages, and then actually offer a patch.

I don't know exactly how you've patched it, but I suspect that any implementation of a combined protectedpages-protectedtitles special page would be very ugly database-wise and be shot down by Domas immediately.

Heh. Well what I did was to add lots of IFs in the code, to run the current ProtectedPages code when 'edit' or 'move' are selected, and run the imported code from ProtectedTitles when 'create' is selected! ;) That doesn't have anything to do with the DB-side of the story, but I'm in agreement with you that it makes the code "ugly". That's why I avoid redoing the whole thing unless given a good reason.

The entire idea is to be able to present a mixed list of create-protected and edit/move-protected pages, which is hell.

*** Bug 12977 has been marked as a duplicate of this bug. ***

oysterguitarist wrote:

What about having cascading on the combo box also, I know it shows up with full but, it might be helful to have cascading on there as well.

These really are two different things. One is a list actual pages that are protected, the other is a list of titles that cannot easily be re-created and probably should not exist.

Additionally, the code to do this would need two different pagers and the UI would have various nonsense options like "size" for protected titles. I suppose some fancy JS could try and add/remove options...