Page MenuHomePhabricator
Create Task
Maniphest T146692

bzr, cvs should be valid schemes for URL data types on wikidata.org
Closed, ResolvedPublic
Actions

Description

Similar to https://phabricator.wikimedia.org/T140986, the bzr and cvs schemes should be valid.

The CVS case is interesting because the argument provided to the cvs command is not a URL, which prompted a discussion ( https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_Informatics/FLOSS#CVS_:pserver:_repositories_are_not_URLs ). It turns out there is a cvs scheme described at http://www.iana.org/assignments/uri-schemes/prov/cvs and it could be used instead of the :pserver: notation.

Details

SubjectRepoBranchLines +/-
Properly document and test bzr/cvs schemes in UrlSchemeValidatorsmediawiki/extensions/Wikibasemaster+108 -62
Add bzr and cvs schemesmediawiki/extensions/Wikibasemaster+3 -1
Customize query in gerrit

Event Timeline

dachary created this task.Sep 26 2016, 8:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2016, 8:19 PM
gerritbot subscribed.Sep 26 2016, 8:25 PM

Change 312883 had a related patch set uploaded (by Dachary):
Add bzr and cvs schemes

https://gerrit.wikimedia.org/r/312883

gerritbot added a project: Patch-For-Review.Sep 26 2016, 8:25 PM
dachary added a comment.Sep 26 2016, 8:26 PM

@Lydia_Pintscher I added you to the Subscribers because you participated in https://phabricator.wikimedia.org/T140986. If that is not a good practice, please let me know.

Mbch331 subscribed.Sep 26 2016, 8:38 PM

It looks a bit strange to see cvs added to the list when none of the examples start with cvs, maybe you could rewrite one of the examples to show how it would look like if it started with cvs.

dachary updated the task description. (Show Details)EditedSep 26 2016, 9:03 PM

@Mbch331 right :-) I updated the examples to show the cvs:// form (which is s|^:pserver:|cvs://pserver:| and removing the : after the domain name)

dachary updated the task description. (Show Details)Sep 26 2016, 9:07 PM
gerritbot added a comment.Sep 27 2016, 12:47 PM

Change 312883 merged by jenkins-bot:
Add bzr and cvs schemes

https://gerrit.wikimedia.org/r/312883

hoo closed this task as Resolved.Sep 27 2016, 5:12 PM
hoo assigned this task to dachary.
hoo edited projects, added MediaWiki-extensions-WikibaseRepository; removed Patch-For-Review, Wikidata.org.
hoo subscribed.

Thanks for taking care of this, @dachary.

dachary added a comment.Sep 27 2016, 6:45 PM

Thanks for a *very* quick resolution :-) IIRC it will be active on wikidata in a week or two.

hoo added a comment.Sep 27 2016, 10:43 PM
In T146692#2671555, @dachary wrote:

Thanks for a *very* quick resolution :-) IIRC it will be active on wikidata in a week or two.

Hopefully, depending on when we deploy next.

gerritbot added a comment.Oct 4 2016, 9:21 AM

Change 313971 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Properly document and test bzr/cvs schemes in UrlSchemeValidators

https://gerrit.wikimedia.org/r/313971

gerritbot added a project: Patch-For-Review.Oct 4 2016, 9:21 AM
gerritbot added a comment.Oct 4 2016, 10:04 AM

Change 313971 merged by jenkins-bot:
Properly document and test bzr/cvs schemes in UrlSchemeValidators

https://gerrit.wikimedia.org/r/313971

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL