Page MenuHomePhabricator
Create Task
Maniphest T147631

Undoing the last edit to an item should show a undo summary, not a restore one
Closed, ResolvedPublic
Actions

Description

SubmitEntityAction::undo will use the restore summary if we undo the latest page edit (as it basically restores the page version from before that edit).

This behavior is unexpected for the user, we should rather use an undo summary in these cases as well.

Patches for review:

Details

SubjectRepoBranchLines +/-
Avoid unnecessary diffing/patching in SubmitEntityActionmediawiki/extensions/Wikibasemaster+30 -11
Refactor duplicate/misplaced code in SubmitEntityActionmediawiki/extensions/Wikibasemaster+51 -69
When undoing the latest revision, use undo summarymediawiki/extensions/Wikibasemaster+4 -5
Customize query in gerrit

Event Timeline

hoo created this task.Oct 7 2016, 10:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2016, 10:43 AM
Sjoerddebruin subscribed.Oct 7 2016, 10:43 AM
Nikki subscribed.Oct 7 2016, 10:43 AM
gerritbot subscribed.Oct 8 2016, 9:28 AM

Change 314807 had a related patch set uploaded (by Matěj Suchánek):
When undoing the latest revision, use undo summary

https://gerrit.wikimedia.org/r/314807

gerritbot added a project: Patch-For-Review.Oct 8 2016, 9:28 AM
matej_suchanek claimed this task.Oct 8 2016, 9:29 AM
thiemowmde triaged this task as Low priority.Oct 11 2016, 3:15 PM
thiemowmde moved this task from incoming to consider for next sprint on the Wikidata board.
thiemowmde added projects: Wikidata-Sprint-2016-10-12, patch-welcome.
thiemowmde subscribed.
gerritbot added a comment.Oct 11 2016, 3:34 PM

Change 315287 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Refactor duplicate/misplaced code in SubmitEntityAction

https://gerrit.wikimedia.org/r/315287

thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-10-12 board.Oct 12 2016, 12:34 PM
gerritbot added a comment.Oct 14 2016, 1:45 PM

Change 314807 merged by jenkins-bot:
When undoing the latest revision, use undo summary

https://gerrit.wikimedia.org/r/314807

matej_suchanek reassigned this task from matej_suchanek to thiemowmde.Oct 15 2016, 5:08 PM
gerritbot added a comment.Oct 17 2016, 10:13 AM

Change 316310 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Avoid unnecessary diffing/patching in SubmitEntityAction

https://gerrit.wikimedia.org/r/316310

gerritbot added a comment.Oct 17 2016, 10:27 AM

Change 315287 merged by jenkins-bot:
Refactor duplicate/misplaced code in SubmitEntityAction

https://gerrit.wikimedia.org/r/315287

Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Oct 17 2016, 2:51 PM
Thibaut120094 awarded a token.Oct 17 2016, 10:00 PM
thiemowmde moved this task from Review to Doing on the Wikidata-Sprint-2016-10-12 board.Oct 18 2016, 1:53 PM
thiemowmde updated the task description. (Show Details)Oct 18 2016, 2:00 PM
thiemowmde moved this task from Doing to Review on the Wikidata-Sprint-2016-10-12 board.Oct 18 2016, 4:20 PM
gerritbot added a comment.Oct 18 2016, 5:32 PM

Change 316310 merged by jenkins-bot:
Avoid unnecessary diffing/patching in SubmitEntityAction

https://gerrit.wikimedia.org/r/316310

• Jonas closed this task as Resolved.Oct 18 2016, 7:56 PM
• Jonas updated the task description. (Show Details)
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-10-12 board.
matej_suchanek removed a project: Patch-For-Review.Mar 24 2017, 5:53 PM
matej_suchanek unsubscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL