Add a button to toggle syntax highlighting in Quarry
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Base
	Oct 8 2016, 10:54 AM

Description

Problem

Sometimes people need to create/edit queries on Quarry while from mobile. It is quite glitchy to do it normally in my Firefox for Android now.

Proposed solution

It would be nice to have solution we have in Mediawiki for .js editing and similar: a button to toggle highlight. When pressed, replace the syntax-highlighted textarea with a normal textarea. When clicked again, re-enable syntax highlighting.

Related code

The syntax highlight is done using CodeMirror at line 11 of view.js of the Quarry repository analytics/quarry/web. Please send patches to Gerrit and claim this task.

Details

	Subject	Repo	Branch	Lines +/-
	Add a button to toggle syntax highlighting in Quarry	analytics/quarry/web	master	+21 -8

Customize query in gerrit

Related Objects

Mentioned Here: rANQW849e9421ef49: view.{html,css}: Some design changes
rANQW30762326e706: view.js: Fix getting the Query SQL when highlight is enabled
rANQWd7ddab800c7b: view.html: Unbreak 500
rANQWcd6963859b07: Add a button to toggle syntax highlighting in Quarry

Event Timeline

Base created this task.Oct 8 2016, 10:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 8 2016, 10:54 AM

Framawiki subscribed.Apr 16 2018, 9:45 PM

zhuyifei1999 added a project: Google-Code-in-2019.Dec 22 2019, 5:37 AM

zhuyifei1999 updated the task description. (Show Details)

zhuyifei1999 subscribed.

zhuyifei1999 renamed this task from It should be possible to disable syntax highlight to Add a button to toggle syntax highlighting in Quarry.Dec 22 2019, 5:42 AM

zhuyifei1999 updated the task description. (Show Details)

Imported: https://codein.withgoogle.com/dashboard/tasks/6592552044593152/

zhuyifei1999 updated the task description. (Show Details)Dec 22 2019, 10:45 AM

IAmNetx moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Dec 22 2019, 11:35 AM

Safan41 claimed this task.Dec 28 2019, 2:35 AM

Change 561241 had a related patch set uploaded (by Safan41; owner: Safan41):
[analytics/quarry/web@master] Add a button to toggle syntax highlighting in Quarry

https://gerrit.wikimedia.org/r/561241

gerritbot added a project: Patch-For-Review.Dec 31 2019, 2:03 AM

DannyS712 subscribed.Dec 31 2019, 2:08 AM

Change 561241 merged by jenkins-bot:
[analytics/quarry/web@master] Add a button to toggle syntax highlighting in Quarry

https://gerrit.wikimedia.org/r/561241

Mentioned in SAL (#wikimedia-cloud) [2020-01-01T05:58:50Z] <zhuyifei1999_> Deployed cd69638 on quarry-web-01 T147711

Mentioned in SAL (#wikimedia-cloud) [2020-01-01T06:06:37Z] <zhuyifei1999_> Deployed d7ddab8 on quarry-web-01 T147711

Ammarpad closed this task as Resolved.Jan 1 2020, 6:14 AM

Ammarpad moved this task from Backlog to Done (closed) on the Quarry board.

At least for me, the button doesn't actually disable the syntaxhighlighting...

@DannyS712 Any tracebacks on your side?

In T147711#5769086, @zhuyifei1999 wrote:

@DannyS712 Any tracebacks on your side?

Nope, but when I tried on a different computer it worked fine - must be something on my end.
I did notice, however, that the text boxes are different sizes - at https://quarry.wmflabs.org/query/33797, if you click the button, the text box shrinks and a scroll bar appears. Is this intentional?

Mentioned in SAL (#wikimedia-cloud) [2020-01-01T06:47:38Z] <zhuyifei1999_> Deployed 3076232 on quarry-web-01 T147711

I fixed the shrinking issue for width in 849e942. Height... quarry with syntax highlighing enabled auto resizes; do we want to replicate this?

Nope, but when I tried on a different computer it worked fine - must be something on my end.

Probably browser cache.

In T147711#5769091, @zhuyifei1999 wrote:

I fixed the shrinking issue for width in 849e942. Height... quarry with syntax highlighing enabled auto resizes; do we want to replicate this?

Nope, but when I tried on a different computer it worked fine - must be something on my end.

Probably browser cache.

Not a cache issue, that was my first thought. I think a browser extension might be to blame, but that is outside of the scope of this task

zhuyifei1999 closed this task as Resolved.Jan 1 2020, 7:51 AM

Ammarpad moved this task from Backlog to Done (closed) on the Quarry board.Jan 1 2020, 7:53 AM

Add a button to toggle syntax highlighting in QuarryClosed, ResolvedPublicActions