Add variable to represent group of wikis, rather than using $wgDBname
Open, LowPublic
Actions

Assigned To

None

Authored By

	Reedy
	Oct 11 2016, 11:41 PM

Description

When using OATHAuth with a central DB, it means the account name is going to use the local Sitename... Which is fine if all sites were the same... But we have MediaWiki, Wikipedia... etc

	public function getAccount() {
		global $wgSitename;

		return "$wgSitename:{$this->user->getName()}";
	}

We should force it to something like Wikimedia, possibly in English? As otherwise it could become confusing that the account for Wikipedia 2FA works on MediaWiki

Helps fix like T138423 for WMF wikis too... But that bug is still there for other non WMF wikis

Details

	Subject	Repo	Branch	Lines +/-
	Allow override of Site prefix without changing sitename	mediawiki/extensions/OATHAuth	master	+6 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T147902 OATHAuth doesn't support CentralAuth
		Open		None	T147901 Add variable to represent group of wikis, rather than using $wgDBname

Event Timeline

Reedy created this task.Oct 11 2016, 11:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2016, 11:41 PM

Reedy renamed this task from Don't use sitename when wgOATHAuthDatabase != $wgDBname to Don't use sitename when $wgOATHAuthDatabase != $wgDBname.Oct 11 2016, 11:42 PM

Reedy mentioned this in T147902: OATHAuth doesn't support CentralAuth.Oct 11 2016, 11:57 PM

Reedy added a parent task: T147902: OATHAuth doesn't support CentralAuth.

Reedy updated the task description. (Show Details)Oct 12 2016, 12:13 AM

Reedy triaged this task as Low priority.Oct 12 2016, 12:33 AM

Reedy updated the task description. (Show Details)

bd808 moved this task from Backlog to Need for Deployment on the MediaWiki-extensions-OATHAuth board.Oct 12 2016, 3:12 AM

Is there some sense of a global site group name in CentralAuth? If there isn't then we should just have a config variable for this extension, rather than forcing the string "Wikimedia".

In T147901#2707989, @Parent5446 wrote:

Is there some sense of a global site group name in CentralAuth? If there isn't then we should just have a config variable for this extension, rather than forcing the string "Wikimedia".

Oh god, no, I wasn't meaning to suggest to hardcode in Wikimedia or similar; a new config global was gonna be my suggestion if there wasn't some better way to get it. I was just thinking with a Wikimedia centric head on.

Of course, CentralAuth has this as a much larger and systematic problem... T86741 and I'm sure there's another task or two kicking about.

I propose we just define a $wgOATHAuthAccountPrefix or similar. If it's defined, use that instead of $wgSitename, and set it to Wikimedia or something similar in WMF config

Change 318926 had a related patch set uploaded (by Reedy):
Allow override of Site prefix without changing sitename

https://gerrit.wikimedia.org/r/318926

gerritbot added a project: Patch-For-Review.Oct 31 2016, 2:17 PM

Reedy moved this task from Need for Deployment to In Progress on the MediaWiki-extensions-OATHAuth board.Oct 31 2016, 2:41 PM

Change 318926 merged by jenkins-bot:
Allow override of Site prefix without changing sitename

https://gerrit.wikimedia.org/r/318926

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 7 2016, 8:00 PM

https://gerrit.wikimedia.org/r/320266 will put the config on WMF wikis, and .2 will have the code in place

This should be a message key, not a plain string. Not all languages use the Latin alphabet; even those that do might adapt the spelling of proper nouns.

In T147901#2784532, @Tgr wrote:

This should be a message key, not a plain string. Not all languages use the Latin alphabet; even those that do might adapt the spelling of proper nouns.

The variable should hold a message key? Or this should just be based on a message key? And if said message is not disabled, use it? Do we use the sites language, or the users language on that site?

And in WMF case, translated in WikimediaMessages?

It was to try and mitigate T138423, so we wouldn't have mixed rtl and ltr in the same string...

I would go with a variable which is a message key (given that a message with the site/farm name probably already exists for other purposes). And set it via WikimediaMessages, yeah.

In T147901#2789749, @Tgr wrote:

I would go with a variable which is a message key (given that a message with the site/farm name probably already exists for other purposes). And set it via WikimediaMessages, yeah.

I've just had a quick look on WikimediaMessages, there doesn't seem to be a message that is just "Wikimedia"... Curious

Reedy renamed this task from Don't use sitename when $wgOATHAuthDatabase != $wgDBname to Add variable to represent group of wikis, rather than using $wgDBname.Nov 12 2016, 12:59 PM

Reedy removed a project: Patch-For-Review.Nov 16 2016, 10:39 PM

Reedy mentioned this in T138423: Scanning QR code on RTL wiki results in odd username label.Nov 21 2016, 1:24 PM

Krinkle removed a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).May 25 2017, 2:13 PM

Reedy removed Reedy as the assignee of this task.Jun 19 2019, 9:31 PM

Aklapper moved this task from In Progress to Backlog on the MediaWiki-extensions-OATHAuth board.Jul 23 2022, 10:08 AM

Add variable to represent group of wikis, rather than using $wgDBnameOpen, LowPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Add variable to represent group of wikis, rather than using $wgDBname
Open, LowPublic
Actions

Related Objects
Search...