Page MenuHomePhabricator

Add showThumbnails attribute to slideshow galleries
Closed, ResolvedPublic

Description

Add option showthumbnails to keep thumbnails open by default, we'll still let the user close this using the toggle button.

Event Timeline

MarkTraceur added a subscriber: MarkTraceur.

Just a 2¢ here - should this be an option to keep the thumbnails open, or just to show them by default and allow them to be closed as normal?

Just a 2¢ here - should this be an option to keep the thumbnails open, or just to show them by default and allow them to be closed as normal?

I think the latter, show them by default, but allow closing.

I'd say the name of the option could be altered to reflect that, then, but otherwise seems fine to me.

Change 327897 had a related patch set uploaded (by Pppery):
Add showThumbnails option to slideshow galleries

https://gerrit.wikimedia.org/r/327897

@Aklapper Because I added a spurious blank line at the end of the commit message. Maybe gerritbot should be less strict.

Prtksxna updated the task description. (Show Details)

Change 327897 merged by jenkins-bot:
Add showThumbnails option to slideshow galleries

https://gerrit.wikimedia.org/r/327897