| Volker_E | |
| Oct 12 2016, 10:09 PM |
| F41739364: phabricator_pygments_less_comments.png | |
| Feb 1 2024, 12:12 PM |
Phabricator's Diffusion is currently handling the Less color coding incorrectly:
https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki.ui/components/buttons.less;6960b650ea22607b3901dbb33fb49e3015613df3
Single-line comments (//) are colored using class n and o and look different than a code block using /* */
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Phabricator: Add a few more languages to pygments dropdown box | operations/puppet | production | +19 -1 |
Change 321721 had a related patch set uploaded (by Paladox):
Phabricator: Add a few more languages to pygments dropdown box
Change 321721 merged by Dzahn:
Phabricator: Add a few more languages to pygments dropdown box
@Volker_E how does it not look correctly. It's now supported in https://gerrit.wikimedia.org/r/#/c/321721/5/modules/phabricator/data/fixed_settings.yaml
Unless it's because we did LESS instead of Less.
Or it might be fallbacking onto the php version
pygments may not be installed if it is using the php version.
@mmodell is pygments installed on production phabricator?
@Paladox The difference is that you proposed a patch (like with review in Gerrit) AND accepted it yourself. It's the same as +2ing your own commit in Gerrit and not aligned with our principles of code contribution here.
Apart from that I'm happy about the progress on the cause itself.
@Volker_E I meant the less file, I know about the review process.
That's why differential needs to be updated with +1 +2 -1 -2 since anyone can accept it.
// foo should be #74777d (for class c) I guess (like for /* foo */), but ends up #a21 (for class o) and #00702a (for class nt).
https://phabricator.wikimedia.org/config/edit/pygments.enabled/ says Local Config: true. We are on pygmentize 2.3.1.
Per https://github.com/pygments/pygments/issues/1046 this was fixed in https://github.com/pygments/pygments/commit/78d360e3f0d55d92d227b49c67779558f9fa5a14 included in pygmentize 2.8.0.
Upgrading to Debian Bullseye in T334519 won't fix this as it ships 2.7.1. Debian Bookworm would ship 2.14.0.
Funnily, we had T276298 which was to upgrade pygments for SyntaxHighlight and was targetting Buster. That apparently never got used.