Page MenuHomePhabricator
Create Task
Maniphest T148332

1.28-alpha / Call to undefined method DatabasePostgres::getSchemaPath()
Closed, ResolvedPublic
Actions

Description

This used to work with 1.26+ [0], now on MW-master it just throws [1]:

CREATE DATABASE
+php maintenance/install.php --dbtype postgres --dbuser postgres --dbname its_a_mw --pass nyan TravisWiki admin --scriptpath /TravisWiki
PHP 5.5.38 is installed.
Warning: Could not find APCu, XCache or WinCache.
Object caching is not enabled.
Found ImageMagick: /usr/bin/convert.
Image thumbnailing will be enabled if you enable uploads.
Found the Git version control software: /usr/bin/git.
Using server URL "/TravisWiki".
Warning: Your default directory for uploads (/home/travis/build/SemanticMediaWiki/mw/images/) is not checked for vulnerability
to arbitrary script execution during the CLI install.
Using the intl PECL extension for Unicode normalization.
The environment has been checked.
You can install MediaWiki.
Setting up database
done
Checking for language PL/pgSQL
done
Creating schema
done
Creating tables
PHP Fatal error:  Call to undefined method DatabasePostgres::getSchemaPath() in /home/travis/build/SemanticMediaWiki/mw/includes/installer/PostgresInstaller.php on line 609
PHP Stack trace:
PHP   1. {main}() /home/travis/build/SemanticMediaWiki/mw/maintenance/install.php:0
PHP   2. require_once() /home/travis/build/SemanticMediaWiki/mw/maintenance/install.php:156
PHP   3. CommandLineInstaller->execute() /home/travis/build/SemanticMediaWiki/mw/maintenance/doMaintenance.php:110
PHP   4. CliInstaller->execute() /home/travis/build/SemanticMediaWiki/mw/maintenance/install.php:142
PHP   5. Installer->performInstallation() /home/travis/build/SemanticMediaWiki/mw/includes/installer/CliInstaller.php:136
PHP   6. call_user_func:{/home/travis/build/SemanticMediaWiki/mw/includes/installer/Installer.php:1515}() /home/travis/build/SemanticMediaWiki/mw/includes/installer/Installer.php:1515
PHP   7. PostgresInstaller->createTables() /home/travis/build/SemanticMediaWiki/mw/includes/installer/Installer.php:1515

Fatal error: Call to undefined method DatabasePostgres::getSchemaPath() in /home/travis/build/SemanticMediaWiki/mw/includes/installer/PostgresInstaller.php on line 609

Call Stack:
    0.0003     283432   1. {main}() /home/travis/build/SemanticMediaWiki/mw/maintenance/install.php:0
    0.0027     743736   2. require_once('/home/travis/build/SemanticMediaWiki/mw/maintenance/doMaintenance.php') /home/travis/build/SemanticMediaWiki/mw/maintenance/install.php:156
    0.0727   12287376   3. CommandLineInstaller->execute() /home/travis/build/SemanticMediaWiki/mw/maintenance/doMaintenance.php:110
    0.2881   24001600   4. CliInstaller->execute() /home/travis/build/SemanticMediaWiki/mw/maintenance/install.php:142
    0.2881   24002776   5. Installer->performInstallation() /home/travis/build/SemanticMediaWiki/mw/includes/installer/CliInstaller.php:136
    0.3210   24453712   6. call_user_func:{/home/travis/build/SemanticMediaWiki/mw/includes/installer/Installer.php:1515}() /home/travis/build/SemanticMediaWiki/mw/includes/installer/Installer.php:1515
    0.3210   24454048   7. PostgresInstaller->createTables() /home/travis/build/SemanticMediaWiki/mw/includes/installer/Installer.php:1515

Did anyone test this before merging? Its the third time in two weeks that a Database related issue is blocking our integration tests.

[0] https://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/jobs/168044751
[1] https://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/jobs/168056742

Details

SubjectRepoBranchLines +/-
Revert "Move updater/installer specific methods out of DatabaseBase"mediawiki/coremaster+59 -64
Add two missing functions to DatabasePostgres.phpmediawiki/coremaster+16 -1
Customize query in gerrit

Related Objects

Event Timeline

mwjames created this task.Oct 16 2016, 4:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2016, 4:30 PM
Paladox subscribed.Oct 16 2016, 4:35 PM

Postgres is currently broken, even if that is fixed, see T147599

Paladox added projects: MediaWiki-Installer, MW-1.28-release.Oct 16 2016, 4:36 PM
gerritbot subscribed.Oct 16 2016, 4:45 PM

Change 316233 had a related patch set uploaded (by Paladox):
Add two missing functions to PostgresInstaller.php

https://gerrit.wikimedia.org/r/316233

gerritbot added a project: Patch-For-Review.Oct 16 2016, 4:45 PM
Paladox added a comment.Oct 16 2016, 5:34 PM

The above patches partially fixes it, but now I get error

702PHP Fatal error: Call to a member function defaultValue() on a non-object
in /home/travis/build/paladox/mw/includes/installer/PostgresUpdater.php on line 747

703PHP Stack trace:

704PHP 1. {main}() /home/travis/build/paladox/mw/maintenance/update.php:0

705PHP 2. require_once() /home/travis/build/paladox/mw/maintenance/update.php:216

706PHP 3. UpdateMediaWiki->execute() /home/travis/build/paladox/mw/maintenance/doMaintenance.php:110

707PHP 4. DatabaseUpdater->doUpdates() /home/travis/build/paladox/mw/maintenance/update.php:171

708PHP 5. DatabaseUpdater->runUpdates() /home/travis/build/paladox/mw/includes/installer/DatabaseUpdater.php:434

709PHP 6. call_user_func_array:{/home/travis/build/paladox/mw/includes/installer/DatabaseUpdater.php:473}() /home/travis/build/paladox/mw/includes/installer/DatabaseUpdater.php:473

710PHP 7. PostgresUpdater->addSequence() /home/travis/build/paladox/mw/includes/installer/DatabaseUpdater.php:473

711PHP 8. PostgresUpdater->setDefault() /home/travis/build/paladox/mw/includes/installer/PostgresUpdater.php:615

Paladox mentioned this in T147599: Cannot install 1.28 alpha with PostgreSQL database.Oct 16 2016, 6:16 PM
Paladox added a comment.Oct 17 2016, 4:07 PM

Commits rMWa2790b1b80c5c686951a7167e14d267a2f044bb9 or rMWf33c35f25ec05e68653899521c0aa267b35c4ef8 broke this, in my testing I missed those two and the one before rMWa2790b1b80c5c686951a7167e14d267a2f044bb9 worked.

Paladox added a comment.EditedOct 17 2016, 4:38 PM

This rMWacdfb5806a619f9d28c83e802f00ca1aaea834f4 broke this.

gerritbot added a comment.Oct 17 2016, 6:27 PM

Change 316396 had a related patch set uploaded (by Paladox):
Revert "Move updater/installer specific methods out of DatabaseBase"

https://gerrit.wikimedia.org/r/316396

gerritbot added a comment.Oct 17 2016, 8:57 PM

Change 316233 abandoned by Paladox:
Add two missing functions to DatabasePostgres.php

Reason:
Fixed in I64ccab7f9b74f60309ba0c9a8ce68337c42ffb0f

https://gerrit.wikimedia.org/r/316233

gerritbot added a comment.Oct 17 2016, 8:57 PM

Change 316396 abandoned by Paladox:
Revert "Move updater/installer specific methods out of DatabaseBase"

Reason:
Fixed in I64ccab7f9b74f60309ba0c9a8ce68337c42ffb0f

https://gerrit.wikimedia.org/r/316396

Paladox added a comment.Oct 17 2016, 8:58 PM

Fixed in https://gerrit.wikimedia.org/r/#/c/316399/

mwjames updated the task description. (Show Details)Oct 17 2016, 10:20 PM
Aklapper added a comment.Oct 18 2016, 10:19 AM
In T148332#2723123, @Paladox wrote:

This rMWacdfb5806a619f9d28c83e802f00ca1aaea834f4 broke this.

@Paladox: As I cannot understand that sentence, please avoid using a generic "this" but explicitly say what you refer to. Thanks.

Paladox closed this task as Resolved.Oct 19 2016, 9:22 AM
Paladox assigned this task to aaron.

This https://gerrit.wikimedia.org/r/316399 fixed the problem.

Closing as resolved.

mwjames mentioned this in T148628: 1.28-alpha / Error: 42P07 ERROR: relation "logging_log_id_seq" already exists.Oct 19 2016, 11:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits