Page MenuHomePhabricator
Create Task
Maniphest T148340

Stop conditionally registering hooks in FlaggedRevs
Closed, ResolvedPublic
Actions

Description

After T87915, it would be nice if we swapped all FR conditionally registered hooks to be unconditionally defined, and bring the conditional into the hook itself

Details

SubjectRepoBranchLines +/-
Stop conditionally registering UI hooksmediawiki/extensions/FlaggedRevsmaster+93 -76
Stop conditionally registering 3 hooksmediawiki/extensions/FlaggedRevsmaster+19 -27
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Oct 16 2016, 6:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2016, 6:34 PM
Reedy added a subtask: T87915: Convert FlaggedRevs to use extension registration.Oct 16 2016, 6:34 PM
Reedy triaged this task as High priority.Jun 25 2019, 1:16 AM
Reedy closed subtask T87915: Convert FlaggedRevs to use extension registration as Resolved.
Reedy added a project: Technical-Debt.
gerritbot added a comment.Jun 25 2019, 1:42 AM

Change 518860 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/FlaggedRevs@master] Stop conditionally registering 3 hooks

https://gerrit.wikimedia.org/r/518860

gerritbot added a project: Patch-For-Review.Jun 25 2019, 1:42 AM

Change 518861 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/FlaggedRevs@master] Stop conditionally registering UI hooks

https://gerrit.wikimedia.org/r/518861

gerritbot added a comment.Jun 25 2019, 2:33 AM

Change 518860 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Stop conditionally registering 3 hooks

https://gerrit.wikimedia.org/r/518860

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 25 2019, 3:00 AM
Jdforrester-WMF closed this task as Resolved.Jun 25 2019, 4:32 PM
Jdforrester-WMF assigned this task to Reedy.
Jdforrester-WMF removed a project: Patch-For-Review.
Legoktm awarded a token.Jun 25 2019, 4:36 PM
gerritbot added a comment.Jun 25 2019, 4:39 PM

Change 518861 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Stop conditionally registering UI hooks

https://gerrit.wikimedia.org/r/518861

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL