Page MenuHomePhabricator

Stop conditionally registering hooks in FlaggedRevs
Closed, ResolvedPublic

Description

After T87915, it would be nice if we swapped all FR conditionally registered hooks to be unconditionally defined, and bring the conditional into the hook itself

Details

Related Gerrit Patches:
mediawiki/extensions/FlaggedRevs : masterStop conditionally registering UI hooks
mediawiki/extensions/FlaggedRevs : masterStop conditionally registering 3 hooks

Event Timeline

Reedy created this task.Oct 16 2016, 6:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2016, 6:34 PM
Reedy triaged this task as High priority.Jun 25 2019, 1:16 AM
Reedy added a project: Technical-Debt.

Change 518860 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/FlaggedRevs@master] Stop conditionally registering 3 hooks

https://gerrit.wikimedia.org/r/518860

Change 518861 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/FlaggedRevs@master] Stop conditionally registering UI hooks

https://gerrit.wikimedia.org/r/518861

Change 518860 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Stop conditionally registering 3 hooks

https://gerrit.wikimedia.org/r/518860

Jdforrester-WMF closed this task as Resolved.Jun 25 2019, 4:32 PM
Jdforrester-WMF assigned this task to Reedy.
Jdforrester-WMF removed a project: Patch-For-Review.

Change 518861 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Stop conditionally registering UI hooks

https://gerrit.wikimedia.org/r/518861