Page MenuHomePhabricator

Add 'noflip' option to ResourceLoader modules to disable CSSJanus flipping globally for the module
Closed, ResolvedPublic

Description

External libraries such as video.js may apply their own RTL-specific styles which get munged by our CSSJanus into incorrect values (T148565).

Rather than editing the entire upstream stylesheet to add a bunch of /* @noflip */ rules, it'd be nice to set a 'noflip' => true flag on the module definition and let it Just Work.

Details

Related Gerrit Patches:

Event Timeline

brion created this task.Oct 18 2016, 7:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2016, 7:02 PM

Change 316611 had a related patch set uploaded (by Brion VIBBER):
Add 'noflip' option on RL modules to disable CSSJanus

https://gerrit.wikimedia.org/r/316611

Change 316611 merged by jenkins-bot:
Add 'noflip' option on RL modules to disable CSSJanus

https://gerrit.wikimedia.org/r/316611

Krinkle assigned this task to brion.Oct 19 2016, 5:58 PM
Krinkle triaged this task as Medium priority.
Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.
Krinkle added subscribers: Yurik, Catrope, Krinkle.
brion closed this task as Resolved.Oct 19 2016, 6:05 PM

Resolving as this was merged last night.