Page MenuHomePhabricator
Create Task
Maniphest T148637

Port redis statistics to Prometheus
Closed, ResolvedPublic
Actions

Description

Import a redis exporter (like https://github.com/oliver006/redis_exporter)

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

elukey created this task.Oct 19 2016, 1:01 PM

Please also take https://phabricator.wikimedia.org/T110169 in consideration

fgiunchedi added a comment.Nov 15 2016, 11:10 PM

I've tried running the above exporter in labs and mc2001, results for the latter are in P4446. Note the addr label is superfluous and can be discarded when prometheus polls (https://github.com/oliver006/redis_exporter/issues/32)

gerritbot added a comment.Dec 6 2016, 1:57 AM

Change 325466 had a related patch set uploaded (by Filippo Giunchedi):
prometheus: add redis_exporter class

https://gerrit.wikimedia.org/r/325466

gerritbot added a project: Patch-For-Review.Dec 6 2016, 1:57 AM
fgiunchedi closed this task as Resolved.Oct 5 2017, 3:56 PM
fgiunchedi claimed this task.

Will do as part of T177196

fgiunchedi renamed this task from Port redis statistics from ganglia to prometheus to Port redis statistics to Prometheus.Oct 19 2017, 3:36 PM
fgiunchedi reopened this task as Open.
fgiunchedi added a parent task: T177196: Port non-deprecated Diamond collectors to Prometheus.
Stashbot subscribed.Oct 27 2017, 1:11 PM

Mentioned in SAL (#wikimedia-releng) [2017-10-27T13:11:30Z] <godog> provision deployment-redis{03,04} with stretch - T148637

gerritbot added a comment.Oct 27 2017, 2:59 PM

Change 386869 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] hieradata: add redis stretch deployment-prep instances

https://gerrit.wikimedia.org/r/386869

gerritbot added a comment.Oct 27 2017, 2:59 PM

Change 386870 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] redis: add stretch support

https://gerrit.wikimedia.org/r/386870

fgiunchedi added a project: User-fgiunchedi.Oct 31 2017, 9:44 AM
fgiunchedi moved this task from Backlog to Doing on the User-fgiunchedi board.
gerritbot added a comment.Oct 31 2017, 9:51 AM

Change 386870 merged by Filippo Giunchedi:
[operations/puppet@production] redis: add stretch support

https://gerrit.wikimedia.org/r/386870

fgiunchedi created subtask T179371: Move deployment-prep redis instances to stretch.Oct 31 2017, 11:09 AM
gerritbot added a comment.Nov 9 2017, 3:00 PM

Change 325466 merged by Filippo Giunchedi:
[operations/puppet@production] prometheus: add redis_exporter class and profile

https://gerrit.wikimedia.org/r/325466

gerritbot added a comment.Nov 9 2017, 3:03 PM

Change 390255 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] prometheus: fix notify prometheus-redis-exporter

https://gerrit.wikimedia.org/r/390255

gerritbot added a comment.Nov 9 2017, 3:03 PM

Change 390255 merged by Filippo Giunchedi:
[operations/puppet@production] prometheus: fix notify prometheus-redis-exporter

https://gerrit.wikimedia.org/r/390255

gerritbot added a comment.Nov 9 2017, 3:19 PM

Change 390260 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] prometheus: have multi-instance redis-exporter running, stop default one

https://gerrit.wikimedia.org/r/390260

gerritbot added a comment.Nov 9 2017, 3:20 PM

Change 390260 merged by Filippo Giunchedi:
[operations/puppet@production] prometheus: have multi-instance redis-exporter running, stop default one

https://gerrit.wikimedia.org/r/390260

gerritbot added a comment.Nov 9 2017, 3:29 PM

Change 390262 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] prometheus: switch to systemd::service

https://gerrit.wikimedia.org/r/390262

gerritbot added a comment.Nov 9 2017, 3:31 PM

Change 390262 merged by Filippo Giunchedi:
[operations/puppet@production] prometheus: switch to systemd::service

https://gerrit.wikimedia.org/r/390262

gerritbot added a comment.Nov 9 2017, 3:47 PM

Change 390263 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] prometheus: pass -redis.addr to redis-exporter

https://gerrit.wikimedia.org/r/390263

gerritbot added a comment.Nov 9 2017, 3:48 PM

Change 390263 merged by Filippo Giunchedi:
[operations/puppet@production] prometheus: pass -redis.addr to redis-exporter

https://gerrit.wikimedia.org/r/390263

gerritbot added a comment.Nov 13 2017, 3:46 PM

Change 391024 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] prometheus: add redis jobs

https://gerrit.wikimedia.org/r/391024

gerritbot added a comment.Nov 16 2017, 12:02 PM

Change 391024 merged by Filippo Giunchedi:
[operations/puppet@production] prometheus: add redis jobs

https://gerrit.wikimedia.org/r/391024

gerritbot added a comment.Nov 16 2017, 3:10 PM

Change 391834 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] prometheus: drop addr/alias redis_exporter labels

https://gerrit.wikimedia.org/r/391834

Stashbot added a comment.Nov 16 2017, 3:10 PM

Mentioned in SAL (#wikimedia-operations) [2017-11-16T15:10:39Z] <godog> upgrade prometheus-redis-exporter to 0.13-1 - T148637

gerritbot added a comment.Nov 16 2017, 3:21 PM

Change 391834 merged by Filippo Giunchedi:
[operations/puppet@production] prometheus: drop addr/alias redis_exporter labels

https://gerrit.wikimedia.org/r/391834

gerritbot added a comment.Nov 20 2017, 11:40 AM

Change 392407 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] prometheus: fix relabeling for redis jobs

https://gerrit.wikimedia.org/r/392407

gerritbot added a comment.Nov 20 2017, 11:42 AM

Change 392407 merged by Filippo Giunchedi:
[operations/puppet@production] prometheus: fix relabeling for redis jobs

https://gerrit.wikimedia.org/r/392407

gerritbot added a comment.Nov 27 2017, 3:33 PM

Change 393605 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] redis: use hostname not fqdn in redis_exporter

https://gerrit.wikimedia.org/r/393605

gerritbot added a comment.Nov 27 2017, 3:33 PM

Change 393606 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] profile: add redis_exporter to redis multidc

https://gerrit.wikimedia.org/r/393606

gerritbot added a comment.Nov 28 2017, 2:08 PM

Change 393605 merged by Filippo Giunchedi:
[operations/puppet@production] redis: use hostname not fqdn in redis_exporter

https://gerrit.wikimedia.org/r/393605

gerritbot added a comment.Nov 28 2017, 2:58 PM

Change 393606 merged by Filippo Giunchedi:
[operations/puppet@production] profile: add redis_exporter to redis multidc

https://gerrit.wikimedia.org/r/393606

gerritbot added a comment.Nov 28 2017, 4:23 PM

Change 393794 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] role: split prometheus redis jobs

https://gerrit.wikimedia.org/r/393794

gerritbot added a comment.Nov 30 2017, 11:12 AM

Change 393794 merged by Filippo Giunchedi:
[operations/puppet@production] role: split prometheus redis jobs

https://gerrit.wikimedia.org/r/393794

fgiunchedi added a comment.Nov 30 2017, 11:31 AM

All redis (except for ores') have their metrics being pulled now!

fgiunchedi mentioned this in T177196: Port non-deprecated Diamond collectors to Prometheus.Dec 4 2017, 10:49 AM
gerritbot added a comment.Dec 5 2017, 4:14 PM

Change 395563 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] profile: add redis_exporter to ores::redis

https://gerrit.wikimedia.org/r/395563

gerritbot added a comment.Dec 5 2017, 4:22 PM

Change 395563 merged by Filippo Giunchedi:
[operations/puppet@production] profile: add redis_exporter to ores::redis

https://gerrit.wikimedia.org/r/395563

gerritbot added a comment.Dec 5 2017, 4:41 PM

Change 395569 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] prometheus: add ores redis job

https://gerrit.wikimedia.org/r/395569

gerritbot added a comment.Dec 11 2017, 10:22 AM

Change 395569 merged by Filippo Giunchedi:
[operations/puppet@production] prometheus: add ores redis job

https://gerrit.wikimedia.org/r/395569

fgiunchedi added a comment.Dec 18 2017, 3:55 PM

Initial dashboard at https://grafana-admin.wikimedia.org/dashboard/db/prometheus-redis

gerritbot added a comment.Dec 18 2017, 4:46 PM

Change 398871 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] prometheus: recording rules for redis

https://gerrit.wikimedia.org/r/398871

gerritbot added a comment.Dec 19 2017, 8:42 AM

Change 398871 merged by Filippo Giunchedi:
[operations/puppet@production] prometheus: recording rules for redis

https://gerrit.wikimedia.org/r/398871

fgiunchedi added a subscriber: • MoritzMuehlenhoff.Dec 19 2017, 11:23 AM

I "promoted" (renamed) the prometheus dashboard to "redis" and the previous to "redis-graphite": https://grafana.wikimedia.org/dashboard/db/redis cc @elukey @MoritzMuehlenhoff @Joe for feedback

fgiunchedi closed this task as Resolved.Dec 21 2017, 9:44 AM

All done! The dashboards will likely need some tuning but metrics are there.

fgiunchedi removed a subtask: T179371: Move deployment-prep redis instances to stretch.Dec 21 2017, 10:53 AM
Krenair mentioned this in T135427: Beta puppetmaster cherry-pick process.Jun 5 2018, 7:37 PM
Krenair subscribed.Jun 5 2018, 7:45 PM

It has come up while reviewing cherry-picks used in deployment-prep that https://gerrit.wikimedia.org/r/386869 was not merged

jijiki mentioned this in T110169: Monitor rdb hosts for memory/disk usage (redis_lock, aka redis_misc).Oct 29 2018, 9:01 AM
• MoritzMuehlenhoff mentioned this in T210991: Deprecate Diamond collectors in Tool Labs / Tool Forge.Dec 3 2018, 10:01 AM
bd808 mentioned this in T210993: Deprecate Diamond collectors in Cloud VPS.Jan 1 2020, 9:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits